ElkArte\Attachments\AttachmentsDirectory

Complexity

Total Complexity

143

Size/Duplication

Total Lines	959
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

34 Methods

Rating	Name	Duplication	Size	Complexity
A	getBaseDirs()	0	5	2
A	isCurrentDirectoryId()	0	3	1
A	getCurrent()	0	8	2
C	delete()	0	87	17
B	manageBySpace()	0	47	7
A	directoryExists()	0	9	3
A	autoManageEnabled()	0	8	2
A	getAttachmentsTree()	0	30	4
A	currentDirectoryId()	0	8	2
A	checkNewDir()	0	15	3
A	getPathById()	0	8	2
A	isCurrentBaseDir()	0	8	2
A	autoManageIsLevel()	0	3	1
A	createDirectory()	0	30	4
B	updateLastDirs()	0	32	11
A	initLastDir()	0	5	2
A	getPaths()	0	3	1
A	clear()	0	5	1
A	hasMultiPaths()	0	3	2
A	hasNumFilesLimit()	0	3	1
B	rename()	0	28	8
A	countSubdirs()	0	12	3
C	checkDirSpace()	0	35	16
A	isBaseDir()	0	3	1
A	hasSizeLimit()	0	3	1
A	remainingFiles()	0	8	2
A	hasFileTmpAttachments()	0	24	6
B	checkDirSize()	0	12	7
A	dirSpace()	0	9	2
F	automanageCheckDirectory()	0	88	19
A	remainingSpace()	0	8	2
A	hasBaseDir()	0	3	1
A	countDirs()	0	3	1
A	__construct()	0	38	4

<?php

/**
 * Handles the job of attachment directory management.
 *
 * @package   ElkArte Forum
 * @copyright ElkArte Forum contributors
 * @license   BSD http://opensource.org/licenses/BSD-3-Clause (see accompanying LICENSE.txt file)
 *
 * @version 2.0 dev
 *
 */

namespace ElkArte\Attachments;

use ElkArte\Database\QueryInterface;
use ElkArte\Errors\Errors;

The type ElkArte\Errors\Errors was not found. Maybe you did not declare it correctly or list all dependencies?

use ElkArte\Exceptions\Exception;
use ElkArte\Helper\FileFunctions;
use ElkArte\Helper\Util;

/**
 * Class AttachmentsDirectory
 *
 * The AttachmentsDirectory class is responsible for managing attachment directories and monitoring their health.
 */
class AttachmentsDirectory
{
	/** @var int Used to enable the auto sequence feature */
	public const AUTO_SEQUENCE = 1;

	/** @var int Used to enable the auto year feature */
	public const AUTO_YEAR = 2;

	/** @var int Used to enable the auto year-month feature */
	public const AUTO_YEAR_MONTH = 3;

	/** @var int Used to enable the auto random feature */
	public const AUTO_RAND = 4;

	/** @var int Used to enable the auto random feature */
	public const AUTO_RAND2 = 5;

	/** @var int Current size of data in a directory */
	protected static int $dir_size = 0;

	/** @var int Limits on the above */
	protected int $sizeLimit = 0;

	/** @var int Current number of files in a directory */
	protected static int $dir_files = 0;

	/** @var int Limits on the above */
	protected int $numFilesLimit = 0;

	/** @var int if auto manage attachment function is enabled and at what level
	 * 0 = normal/off, 1 = by space (#files/size), 2 = by years, 3 = by months 4 = random */
	protected int $automanage_attachments = 0;

	/** @var array Potential attachment directories */
	protected array $attachmentUploadDir = [];

	/** @var int Pointer to the above upload directory array */
	protected int $currentAttachmentUploadDir = 0;

	/** @var int|mixed If we are using subdirectories */
	protected mixed $useSubdirectories = 0;

	/** @var bool If to notify the admin when a directory is full */
	protected bool $attachment_full_notified = false;

	/** @var array|string Potential root/base directories to which we can add directories/files */
	protected array|string $baseDirectories = [];

	/** @var string Current base to use from the above array */
	protected string $basedirectory_for_attachments = '';

	/** @var array|mixed|string */
	protected mixed $last_dirs = [];

	/**
	 * The constructor for attachment directories, controls where to add files
	 * and monitors directory health
	 *
	 * @param array $options all the stuff
	 * @param QueryInterface $db
	 */
	public function __construct(array $options, protected QueryInterface $db)
	{
		$this->automanage_attachments = (int) ($options['automanage_attachments'] ?? $this->automanage_attachments);
		$this->sizeLimit = $options['attachmentDirSizeLimit'] ?? $this->sizeLimit;
		$this->numFilesLimit = $options['attachmentDirFileLimit'] ?? $this->numFilesLimit;

		$this->currentAttachmentUploadDir = $options['currentAttachmentUploadDir'] ?? $this->currentAttachmentUploadDir;
		$this->useSubdirectories = $options['use_subdirectories_for_attachments'] ?? $this->useSubdirectories;

		$this->last_dirs = $options['last_attachments_directory'] ?? serialize($this->last_dirs);
		$this->last_dirs = Util::unserialize($this->last_dirs);

		$this->baseDirectories = $options['attachment_basedirectories'] ?? serialize($this->baseDirectories);
		$this->baseDirectories = Util::unserialize($this->baseDirectories);

It seems like ElkArte\Helper\Util::unserialize($this->baseDirectories) can also be of type false. However, the property $baseDirectories is declared as type array|string. Maybe add an additional type check?

It seems like $this->baseDirectories can also be of type array; however, parameter $string of ElkArte\Helper\Util::unserialize() does only seem to accept string, maybe add an additional type check?

		$this->basedirectory_for_attachments = $options['basedirectory_for_attachments'] ?? $this->basedirectory_for_attachments;
		$this->attachment_full_notified = !empty($options['attachment_full_notified'] ?? $this->basedirectory_for_attachments);

		if (empty($options['attachmentUploadDir']))
		{
			$options['attachmentUploadDir'] = serialize([1 => BOARDDIR . '/attachments']);
		}

		// It should be added to the installation and upgrade scripts.
		// But since the converters need to be updated also. This is easier.
		if (empty($options['currentAttachmentUploadDir']))
		{
			$this->currentAttachmentUploadDir = 1;
			$options['attachmentUploadDir'] = serialize([1 => $options['attachmentUploadDir']]);

			updateSettings([
				'attachmentUploadDir' => $options['attachmentUploadDir'],
				'currentAttachmentUploadDir' => 1,
			]);
		}

		$current = Util::unserialize($options['attachmentUploadDir']);
		$this->attachmentUploadDir = $current ?: $options['attachmentUploadDir'];
	}

	/**
	 * Return how many files will still "fit" in the directory
	 *
	 * @param int $current_files
	 * @return false|mixed
	 */
	public function remainingFiles(int $current_files): mixed
	{
		if ($this->hasNumFilesLimit())
		{
			return max($this->numFilesLimit - $current_files, 0);
		}

		return false;
	}

	/**
	 * Returns if a file limit (count) has been placed on a directory
	 *
	 * @return bool
	 */
	public function hasNumFilesLimit(): bool
	{
		return !empty($this->numFilesLimit);
	}

	/**
	 * Returns how much physical space is remaining for a directory
	 *
	 * @param $current_dir_size
	 * @return false|mixed
	 */
	public function remainingSpace($current_dir_size): mixed
	{
		if ($this->hasSizeLimit())
		{
			return max($this->sizeLimit - $current_dir_size, 0);
		}

		return false;
	}

	/**
	 * Return if a directory physical space limit has been set
	 *
	 * @return bool
	 */
	public function hasSizeLimit(): bool
	{
		return !empty($this->sizeLimit);
	}

	/**
	 * Little utility function for the $id_folder computation for attachments.
	 *
	 * What it does:
	 *
	 * - This returns the id of the folder where the attachment or avatar will be saved.
	 * - If multiple attachment directories are not enabled, this will be 1 by default.
	 *
	 * @return int 1 if multiple attachment directories are not enabled,
	 * or the id of the current attachment directory otherwise.
	 */
	public function currentDirectoryId(): int
	{
		if (!array_key_exists($this->currentAttachmentUploadDir, $this->attachmentUploadDir))
		{
			$this->currentAttachmentUploadDir = max(array_keys($this->attachmentUploadDir));
		}

		return $this->currentAttachmentUploadDir;
	}

	/**
	 * Checks if a given id or named directory has been defined.  Does not
	 * check if it exists on disk.
	 *
	 * @param int|string $id
	 * @return bool
	 */
	public function directoryExists(int|string $id): bool
	{
		if (is_int($id))
		{
			return array_key_exists($id, $this->attachmentUploadDir);
		}

		return in_array($id, $this->attachmentUploadDir)
			|| in_array(BOARDDIR . DIRECTORY_SEPARATOR . $id, $this->attachmentUploadDir, true);
	}

	/**
	 * Loop through the attachment directory array to count any subdirectories
	 *
	 * @param string $dir
	 * @return int
	 */
	public function countSubdirs(string $dir): int
	{
		$expected_dirs = 0;
		foreach ($this->getPaths() as $sub)
		{
			if (strpos($sub, $dir . DIRECTORY_SEPARATOR) !== false)
			{
				$expected_dirs++;
			}
		}

		return $expected_dirs;
	}

	/**
	 * Returns the list of directories as an array.
	 *
	 * @return array the attachments directory/directories
	 */
	public function getPaths(): array
	{
		return $this->attachmentUploadDir;
	}

	/**
	 * Returns the directory name for a given key
	 *
	 * @param int $id key in our attachmentUploadDir array
	 * @return string
	 *
	 * @throws Exception
	 */
	public function getPathById(int $id): string
	{
		if (isset($this->attachmentUploadDir[$id]))
		{
			return $this->attachmentUploadDir[$id];
		}

		throw new Exception('dir_does_not_exists');
	}

	/**
	 * Return the base directory in use for attachments
	 *
	 * @return array
	 */
	public function getBaseDirs(): array
	{
		return is_array($this->baseDirectories)
			? $this->baseDirectories
			: [1 => $this->basedirectory_for_attachments];
	}

	/**
	 * Return if base directories have been defined
	 *
	 * @return bool
	 */
	public function hasBaseDir(): bool
	{
		return !empty($this->baseDirectories);
	}

	/**
	 * Return if a given directory is a defined base dir
	 *
	 * @param $dir
	 * @return bool
	 */
	public function isBaseDir($dir): bool
	{
		return in_array($dir, $this->baseDirectories, true);

It seems like $this->baseDirectories can also be of type string; however, parameter $haystack of in_array() does only seem to accept array, maybe add an additional type check?

	}

	/**
	 * Updates the last directories information
	 *
	 * @param int $dir_id The key in the last_dirs array
	 * @return void
	 */
	public function updateLastDirs(int $dir_id): void
	{
		if (!empty($this->last_dirs) && (isset($this->last_dirs[$dir_id]) || isset($this->last_dirs[0])))
		{
			$num = substr(strrchr($this->attachmentUploadDir[$dir_id], '_'), 1);
			if (is_numeric($num))
			{
				// Need to find the base folder.
				$bid = -1;
				$use_subdirectories = 0;
				foreach ($this->attachmentUploadDir as $base)
				{
					if (strpos($this->attachmentUploadDir[$dir_id], $base . DIRECTORY_SEPARATOR) !== false)
					{
						$use_subdirectories = 1;
						break;
					}
				}

				if ($use_subdirectories == 0 && strpos($this->attachmentUploadDir[$dir_id], BOARDDIR . DIRECTORY_SEPARATOR) !== false)
				{
					$bid = 0;
				}

				$this->last_dirs[$bid] = (int) $num;
				$this->basedirectory_for_attachments = empty($this->basedirectory_for_attachments) ? '' : $this->basedirectory_for_attachments;
				$this->useSubdirectories = (int) $this->useSubdirectories;

				updateSettings([
					'last_attachments_directory' => serialize($this->last_dirs),
					'basedirectory_for_attachments' => $bid == 0 ? $this->basedirectory_for_attachments : $this->attachmentUploadDir[$bid],
					'use_subdirectories_for_attachments' => $use_subdirectories,
				]);
			}
		}
	}

	/**
	 * If size/count limits are enabled, validates a given file will still fit
	 * within the given constraints.  If not will attempt to create new directories
	 * based on ACP options
	 *
	 * @param $thumb_size
	 */
	public function checkDirSize($thumb_size): void
	{
		if ($this->autoManageIsLevel(self::AUTO_SEQUENCE) && (!empty($this->sizeLimit) || !empty($this->numFilesLimit)))
		{
			self::$dir_size += $thumb_size;
			self::$dir_files++;

			// If the folder is full, try to create a new one and move the thumb to it.
			if ((self::$dir_size > $this->sizeLimit * 1024 || self::$dir_files + 2 > $this->numFilesLimit) && $this->manageBySpace())
			{
				self::$dir_size = 0;
				self::$dir_files = 0;
			}
		}
	}

	/**
	 * Returns if the current management level is a level
	 *
	 * Default = 1, By Year = 2, By Year and Month = 3, Rand = 4;
	 *
	 * @param $level
	 * @return bool
	 */
	public function autoManageIsLevel($level): bool
	{
		return $this->automanage_attachments === (int) $level;
	}

	/**
	 * Determines the current base directory and attachment directory
	 *
	 * What it does:
	 *
	 * - Increments the above directory to the next available slot
	 * - Uses createDirectory to create the incremental directory
	 *
	 */
	public function manageBySpace(): ?bool
	{
		if ($this->autoManageEnabled(self::AUTO_SEQUENCE))
		{
			return true;
		}

		$baseDirectory = empty($this->useSubdirectories) ? BOARDDIR : $this->basedirectory_for_attachments;

		// Just to be sure: I don't want directory separators at the end
		$sep = stripos(PHP_OS_FAMILY, 'WIN') === 0 ? '\/' : DIRECTORY_SEPARATOR;
		$baseDirectory = rtrim($baseDirectory, $sep);

		// Get the current base directory
		if (!empty($this->useSubdirectories) && !empty($this->baseDirectories))
		{
			$base_dir = array_search($this->basedirectory_for_attachments, $this->baseDirectories, true);

It seems like $this->baseDirectories can also be of type string; however, parameter $haystack of array_search() does only seem to accept array, maybe add an additional type check?

		}
		else
		{
			$base_dir = 0;
		}

		// Get the last attachment directory for that base directory
		$this->initLastDir($base_dir);

		// And increment it.
		$this->last_dirs[$base_dir]++;

		$uploadDirectory = $baseDirectory . DIRECTORY_SEPARATOR . 'attachments_' . $this->last_dirs[$base_dir];

		// make sure it exists and is writable
		try
		{
			$this->createDirectory($uploadDirectory);

			$this->currentAttachmentUploadDir = array_search($uploadDirectory, $this->attachmentUploadDir, true);

It seems like array_search($uploadDirectory, $this->attachmentUploadDir, true) can also be of type string. However, the property $currentAttachmentUploadDir is declared as type integer. Maybe add an additional type check?

			updateSettings([
				'last_attachments_directory' => serialize($this->last_dirs),
				'currentAttachmentUploadDir' => $this->currentAttachmentUploadDir,
			]);

			return true;
		}
		catch (Exception)
		{
			return false;
		}
	}

	/**
	 * If the auto manage function is enabled
	 *
	 * @param int|null $minLevel
	 * @return bool
	 */
	public function autoManageEnabled(int $minLevel = null): bool
	{
		if ($minLevel === null)
		{
			return !empty($this->automanage_attachments);
		}

		return $this->automanage_attachments > $minLevel;
	}

	/**
	 * Initializes the last directory for the given base directory
	 *
	 * @param string $base_dir the base directory
	 * @return void
	 */
	protected function initLastDir(string $base_dir): void
	{
		if (!isset($this->last_dirs[$base_dir]))
		{
			$this->last_dirs[$base_dir] = 0;
		}
	}

	/**
	 * Creates a directory as defined by the admin attach options
	 *
	 * What it does:
	 *
	 * - Attempts to make the directory writable
	 * - Places an .htaccess in new directories for security
	 *
	 * @param string $uploadDirectory
	 * @return bool
	 * @throws Exception
	 *
	 */
	public function createDirectory(string $uploadDirectory): bool
	{
		$fileFunctions = FileFunctions::instance();

		$uploadDirectory = str_replace('\\', DIRECTORY_SEPARATOR, $uploadDirectory);
		$uploadDirectory = rtrim($uploadDirectory, DIRECTORY_SEPARATOR);

		try
		{
			$result = $fileFunctions->createDirectory($uploadDirectory, true);
		}
		catch (Exception $exception)
		{
			Errors::instance()->log_error($exception->getMessage());
			throw $exception;
		}

		// Only update if it's a new directory
		if ($result && !in_array($uploadDirectory, $this->attachmentUploadDir, true))
		{
			$this->currentAttachmentUploadDir = max(array_keys($this->attachmentUploadDir)) + 1;
			$this->attachmentUploadDir[$this->currentAttachmentUploadDir] = $uploadDirectory;

			updateSettings([
				'attachmentUploadDir' => serialize($this->attachmentUploadDir),
				'currentAttachmentUploadDir' => $this->currentAttachmentUploadDir,
			], true);
		}

		return true;
	}

	/**
	 * Returns the number of attachment directories we have
	 *
	 * @return int
	 */
	public function countDirs(): int
	{
		return count($this->attachmentUploadDir);
	}

	/**
	 * Returns the attachment tree with modified paths
	 *
	 * @param array $file_tree the original attachment tree
	 * @return array the modified attachment tree
	 */
	public function getAttachmentsTree(array $file_tree): array
	{
		// Are we using multiple attachment directories?
		if ($this->hasMultiPaths())
		{
			unset($file_tree[strtr(BOARDDIR, ['\\' => '/'])]['contents']['attachments']);

			// @todo Should we suggest non-current directories be read only?
			foreach ($this->attachmentUploadDir as $dir)
			{
				$file_tree[strtr($dir, ['\\' => '/'])] = [
					'type' => 'dir',
					'writable_on' => 'restrictive',
				];
			}
		}
		else
		{
			if (substr($this->attachmentUploadDir[1], 0, strlen(BOARDDIR)) != BOARDDIR)
			{
				unset($file_tree[strtr(BOARDDIR, ['\\' => '/'])]['contents']['attachments']);
			}

			$file_tree[strtr($this->attachmentUploadDir[1], ['\\' => '/'])] = [
				'type' => 'dir',
				'writable_on' => 'restrictive',
			];
		}

		return $file_tree;
	}

	/**
	 * Checks if we have multiple paths for attachments
	 *
	 * @return bool
	 */
	public function hasMultiPaths(): bool
	{
		return $this->autoManageEnabled() && count($this->attachmentUploadDir) > 1;
	}

	/**
	 * Check and create a directory automatically.
	 *
	 * @param bool $is_admin_interface
	 * @return bool
	 */
	public function automanageCheckDirectory(bool $is_admin_interface = false): bool
	{
		if ($this->autoManageEnabled() === false)
		{
			return false;
		}

		if ($this->checkNewDir($is_admin_interface) === false)
		{
			return false;
		}

		// Get our date and random numbers for the directory choices
		$year = date('Y');
		$month = date('m');

		$rand = md5(mt_rand());
		$rand1 = $rand[1];
		$rand = $rand[0];

		if (!empty($this->baseDirectories) && !empty($this->useSubdirectories))
		{
			$base_dir = array_search($this->basedirectory_for_attachments, $this->baseDirectories, true);

It seems like $this->baseDirectories can also be of type string; however, parameter $haystack of array_search() does only seem to accept array, maybe add an additional type check?

		}
		else
		{
			$base_dir = 0;
		}

		$baseDirectory = empty($this->useSubdirectories) ? BOARDDIR : $this->basedirectory_for_attachments;

		// Just to be sure: I don't want directory separators at the end
		$sep = stripos(PHP_OS_FAMILY, 'WIN') === 0 ? '\/' : DIRECTORY_SEPARATOR;
		$baseDirectory = rtrim($baseDirectory, $sep);

		switch ($this->automanage_attachments)
		{
			case self::AUTO_SEQUENCE:
				$this->initLastDir($base_dir);
				$uploadDirectory = $baseDirectory . DIRECTORY_SEPARATOR . 'attachments_' . $this->last_dirs[$base_dir];
				break;
			case self::AUTO_YEAR:
				$uploadDirectory = $baseDirectory . DIRECTORY_SEPARATOR . $year;
				break;
			case self::AUTO_YEAR_MONTH:
				$uploadDirectory = $baseDirectory . DIRECTORY_SEPARATOR . $year . DIRECTORY_SEPARATOR . $month;
				break;
			case self::AUTO_RAND:
				$uploadDirectory = $baseDirectory . DIRECTORY_SEPARATOR . (empty($this->useSubdirectories) ? 'attachments-' : 'random_') . $rand;
				break;
			case self::AUTO_RAND2:
				$uploadDirectory = $baseDirectory . DIRECTORY_SEPARATOR . (empty($this->useSubdirectories) ? 'attachments-' : 'random_') . $rand . DIRECTORY_SEPARATOR . $rand1;
				break;
			default:
				$uploadDirectory = '';
		}

		if (!empty($uploadDirectory) && !in_array($uploadDirectory, $this->attachmentUploadDir, true))
		{
			try
			{
				$this->createDirectory($uploadDirectory);
				$outputCreation = true;
			}
			catch (Exception)
			{
				$outputCreation = false;
			}
		}
		elseif (in_array($uploadDirectory, $this->attachmentUploadDir, true))
		{
			$outputCreation = true;
		}
		else
		{
			$outputCreation = false;
		}

		if ($outputCreation)
		{
			$this->currentAttachmentUploadDir = array_search($uploadDirectory, $this->attachmentUploadDir, true);

It seems like array_search($uploadDirectory, $this->attachmentUploadDir, true) can also be of type string. However, the property $currentAttachmentUploadDir is declared as type integer. Maybe add an additional type check?

			updateSettings([
				'currentAttachmentUploadDir' => $this->currentAttachmentUploadDir,
			]);
		}

		return $outputCreation;
	}

	/**
	 * Should we try to create a new directory or not?
	 *
	 * False if Auto manage is off or No files were uploaded
	 * True if from the ACP or if files were uploaded
	 *
	 * @param bool $is_admin_interface
	 * @return bool
	 */
	protected function checkNewDir(bool $is_admin_interface): bool
	{
		// Not pretty, but since we don't want folders created for every post.
		// It'll do unless a better solution can be found.
		if ($is_admin_interface === true)
		{
			return true;
		}

		if ($this->autoManageEnabled() === false)
		{
			return false;
		}

		return $this->hasFileTmpAttachments();
	}

	/**
	 * Checks if there are any temporary file attachments
	 *
	 * @param bool $strict Whether to perform strict check on uploaded files
	 * @return bool Returns true if there are temporary file attachments, false otherwise
	 */
	public function hasFileTmpAttachments(bool $strict = true): bool
	{
		if (isset($_FILES['attachment']['tmp_name']))
		{
			foreach ($_FILES['attachment']['tmp_name'] as $tmp_name)
			{
				if (empty($tmp_name))
				{
					continue;
				}

				if (!$strict)
				{
					return true;
				}

				if (is_uploaded_file($tmp_name))
				{
					return true;
				}
			}
		}

		return false;
	}

	/**
	 * Checks if the current active directory has space allowed for a new attachment file
	 *
	 * @param TemporaryAttachment $sess_attach
	 * @throws Exception
	 */
	public function checkDirSpace(TemporaryAttachment $sess_attach): void
	{
		if (empty(self::$dir_size) || empty(self::$dir_files))
		{
			$this->dirSpace($sess_attach->getSize());
		}

		// Are we about to run out of room? Let's notify the admin then.
		if (($this->attachment_full_notified === false && !empty($this->sizeLimit) && $this->sizeLimit > 4000 && self::$dir_size > ($this->sizeLimit - 2000) * 1024)
			|| (!empty($this->numFilesLimit) && $this->numFilesLimit * .95 < self::$dir_files && $this->numFilesLimit > 500))
		{
			require_once(SUBSDIR . '/Admin.subs.php');
			emailAdmins('admin_attachments_full');
			updateSettings(['attachment_full_notified' => 1]);
		}

		// No room left.... What to do now???
		if ((!empty($this->numFilesLimit) && self::$dir_files + 2 > $this->numFilesLimit)
			|| (!empty($this->sizeLimit) && self::$dir_size > $this->sizeLimit * 1024))
		{
			// If we are managing the directories space automatically, lets get to it
			if ($this->autoManageIsLevel(self::AUTO_SEQUENCE))
			{
				// Move it to the new folder if we can. (Throws Exception if it fails)
				if ($this->manageBySpace())
				{
					$sess_attach->moveTo($this->getCurrent());
					$sess_attach->setIdFolder($this->currentAttachmentUploadDir);
					self::$dir_size = 0;
					self::$dir_files = 0;
				}
			}
			else
			{
				throw new Exception('ran_out_of_space');
			}
		}
	}

	/**
	 * Current space consumed by the files in a directory plus what a new file will add
	 *
	 * @param int $tmp_attach_size
	 * @return void
	 */
	protected function dirSpace(int $tmp_attach_size = 0): void
	{
		require_once(SUBSDIR . '/ManageAttachments.subs.php');
		$current_dir = attachDirProperties($this->currentAttachmentUploadDir);

		// Add 1 to file count only when a new file will be added
		self::$dir_files = $current_dir['files'] + (empty($tmp_attach_size) ? 0 : 1);

		self::$dir_size = $current_dir['size'] + $tmp_attach_size;
	}

	/**
	 * The current attachment path:
	 *
	 * What it does:
	 *
	 * @return string
	 * @todo not really true at the moment
	 *  - BOARDDIR . '/attachments', if nothing is set yet.
	 *  - if the forum is using multiple attachments directories,
	 *    then the current path is stored as unserialize($modSettings['attachmentUploadDir'])[$modSettings['currentAttachmentUploadDir']]
	 *  - otherwise, the current path is $modSettings['attachmentUploadDir'].
	 *
	 */
	public function getCurrent(): string
	{
		if (empty($this->attachmentUploadDir))
		{
			return BOARDDIR . '/attachments';
		}

		return $this->attachmentUploadDir[$this->currentAttachmentUploadDir];
	}

	/**
	 * Renames the directory for a given key and updates base directory path if necessary
	 *
	 * @param int $id Key in the attachmentUploadDir array
	 * @param string &$real_path Reference to the current directory path to be renamed
	 *
	 * @throws Exception When the directory cannot be renamed or already exists
	 */
	public function rename(int $id, string &$real_path): void
	{
		$fileFunctions = FileFunctions::instance();
		if (!empty($this->attachmentUploadDir[$id]) && $real_path !== $this->attachmentUploadDir[$id])
		{
			if (!$fileFunctions->isDir($real_path))
			{
				if (!@rename($this->attachmentUploadDir[$id], $real_path))
				{
					$real_path = $this->attachmentUploadDir[$id];
					throw new Exception('attach_dir_no_rename');
				}
			}
			else
			{
				$real_path = $this->attachmentUploadDir[$id];
				throw new Exception('attach_dir_exists_msg');
			}

			// Update the base directory path
			if (!empty($this->baseDirectories) && array_key_exists($id, $this->baseDirectories))

It seems like $this->baseDirectories can also be of type string; however, parameter $array of array_key_exists() does only seem to accept ArrayObject|array, maybe add an additional type check?

			{
				$base = $this->basedirectory_for_attachments === $this->attachmentUploadDir[$id] ? $real_path : $this->basedirectory_for_attachments;

				$this->baseDirectories[$id] = $real_path;
				updateSettings([
					'attachment_basedirectories' => serialize($this->baseDirectories),
					'basedirectory_for_attachments' => $base,
				]);
			}
		}
	}

	/**
	 * Remove a directory if its empty (not counting .htaccess or index.php)
	 *
	 * @param $id
	 * @param $real_path
	 * @return bool|null
	 * @throws Exception
	 */
	public function delete($id, &$real_path): ?bool
	{
		$real_path = $this->attachmentUploadDir[$id];

		// It's not a good idea to delete the current directory.
		if ($this->isCurrentDirectoryId($id))
		{
			throw new Exception('attach_dir_is_current');
		}

		// Or the current base directory
		if ($this->isCurrentBaseDir($id))
		{
			throw new Exception('attach_dir_is_current_bd');
		}

		// Or the board directory
		if ($real_path === realpath(BOARDDIR))
		{
			throw new Exception('attach_dir_no_delete');
		}

		// Let's not try to delete a path with files in it.
		$num_attach = countAttachmentsInFolders($id);

		// A check to see if it's a used base dir.
		if ($num_attach === 0 && !empty($this->baseDirectories))
		{
			// Count any sub-folders.
			foreach ($this->attachmentUploadDir as $sub)
			{
				if (strpos($sub, $real_path . DIRECTORY_SEPARATOR) !== false)
				{
					$num_attach++;
				}
			}
		}

		// It's safe to delete. So try to delete the folder also
		if ($num_attach === 0)
		{
			$fileFunctions = FileFunctions::instance();
			$doit = false;

			if ($fileFunctions->isDir($real_path))
			{
				$doit = true;
			}
			elseif ($fileFunctions->isDir(BOARDDIR . DIRECTORY_SEPARATOR . $real_path))
			{
				$doit = true;
				$real_path = BOARDDIR . DIRECTORY_SEPARATOR . $real_path;
			}

			// They have a path in the system that does not exist
			if ($doit === false && !$fileFunctions->fileExists($real_path))
			{
				$this->clear($id);
				return true;
			}

			if ($doit)
			{
				$fileFunctions->delete($real_path . '/.htaccess');
				$fileFunctions->delete($real_path . '/index.php');
				$result = $fileFunctions->rmDir($real_path);

				if (!$result)
				{
					throw new Exception('attach_dir_no_delete');
				}
			}

			// Remove it from the base directory list.
			if (!empty($result) && !empty($this->baseDirectories))
			{
				$this->clear($id);
				return true;
			}
		}
		else
		{
			throw new Exception('attach_dir_no_remove');
		}

		// Default: nothing changed
		return null;
	}

	/**
	 * Remove a directory from modSettings 'attachment_basedirectories'
	 *
	 * @param $id
	 */
	public function clear($id): void
	{
		unset($this->baseDirectories[$id]);
		updateSettings([
			'attachment_basedirectories' => serialize($this->baseDirectories)
		]);
	}

	/**
	 * Checks if the given ID is the current directory ID
	 *
	 * @param int $id The ID to check against the current directory ID
	 * @return bool Returns true if the given ID is the same as the current directory ID, otherwise returns false
	 */
	public function isCurrentDirectoryId(int $id): bool
	{
		return $this->currentAttachmentUploadDir == $id;
	}

	/**
	 * Returns if a given directory is the current base directory used for attachments
	 *
	 * @param int|string $id
	 * @return bool
	 */
	public function isCurrentBaseDir(int|string $id): bool
	{
		if (is_int($id))
		{
			return $this->basedirectory_for_attachments === $this->attachmentUploadDir[$id];
		}

		return $this->basedirectory_for_attachments === $id;
	}
}