TokenPersistenceTest::testSimpleCacheTokenPersistence() - Code Metrics - Inspection of "Token Persistence" - eljam/guzzle-jwt-middleware - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

unknown

created 2019-05-31 17:21 UTC

testSimpleCacheTokenPersistence() A

↳ Parent: TokenPersistenceTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.7666
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Eljam\GuzzleJwt\Tests\Persistence;

use Eljam\GuzzleJwt\JwtToken;
use Eljam\GuzzleJwt\Persistence\NullTokenPersistence;
use Eljam\GuzzleJwt\Persistence\SimpleCacheTokenPersistence;
use Symfony\Component\Cache\Simple\FilesystemCache;

/**
 * @author Nicolas Reynis (nreynis)
 */
class TokenPersistenceTest extends \PHPUnit_Framework_TestCase
{
    /**
     * testNullTokenPersistence.
     */
    public function testNullTokenPersistence()
    {
        $tokenPersistence = new NullTokenPersistence();
        $token = new JwtToken('foo', new \DateTime('now'));

        $tokenPersistence->saveToken($token);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}

        $this->assertFalse($tokenPersistence->hasToken());
        $this->assertNull($tokenPersistence->restoreToken());
    }

    /**
     * testSimpleCacheTokenPersistence.
     */
    public function testSimpleCacheTokenPersistence()
    {
        $simpleCache = new FilesystemCache();

        $tokenPersistence = new SimpleCacheTokenPersistence($simpleCache);
        $token = new JwtToken('foo', new \DateTime('now'));

        $tokenPersistence->saveToken($token);

        $this->assertTrue($tokenPersistence->hasToken());
        $this->assertEquals($tokenPersistence->restoreToken()->getToken(), $token->getToken());
		
		$tokenPersistence->deleteToken();
		
		$this->assertFalse($tokenPersistence->hasToken());
    }
}


1			<?php
2
3			namespace Eljam\GuzzleJwt\Tests\Persistence;
4
5			use Eljam\GuzzleJwt\JwtToken;
6			use Eljam\GuzzleJwt\Persistence\NullTokenPersistence;
7			use Eljam\GuzzleJwt\Persistence\SimpleCacheTokenPersistence;
8			use Symfony\Component\Cache\Simple\FilesystemCache;
9
10			/**
11			* @author Nicolas Reynis (nreynis)
12			*/
13			class TokenPersistenceTest extends \PHPUnit_Framework_TestCase
14			{
15			/**
16			* testNullTokenPersistence.
17			*/
18			public function testNullTokenPersistence()
19			{
20			$tokenPersistence = new NullTokenPersistence();
21			$token = new JwtToken('foo', new \DateTime('now'));
22
23			$tokenPersistence->saveToken($token);
			0 ignored issues – show Unused Code introduced 2019-05-31 11:13 UTC by Report Bug Copy Issue Report The call to the method `Eljam\GuzzleJwt\Persiste...ersistence::saveToken()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
24
25			$this->assertFalse($tokenPersistence->hasToken());
26			$this->assertNull($tokenPersistence->restoreToken());
27			}
28
29			/**
30			* testSimpleCacheTokenPersistence.
31			*/
32			public function testSimpleCacheTokenPersistence()
33			{
34			$simpleCache = new FilesystemCache();
			0 ignored issues – show Deprecated Code introduced 2019-05-31 17:18 UTC by Report Bug Copy Issue Report The class `Symfony\Component\Cache\Simple\FilesystemCache` has been deprecated with message: since Symfony 4.3, use FilesystemAdapter and type-hint for CacheInterface instead. This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
35			$tokenPersistence = new SimpleCacheTokenPersistence($simpleCache);
36			$token = new JwtToken('foo', new \DateTime('now'));
37
38			$tokenPersistence->saveToken($token);
39
40			$this->assertTrue($tokenPersistence->hasToken());
41			$this->assertEquals($tokenPersistence->restoreToken()->getToken(), $token->getToken());
42
43			$tokenPersistence->deleteToken();
44
45			$this->assertFalse($tokenPersistence->hasToken());
46			}
47			}
48

eljam / guzzle-jwt-middleware

Pull Request — master (#11)

testSimpleCacheTokenPersistence() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like