O2TI\SocialLogin\Controller\Endpoint\Index

Complexity

Total Complexity

2

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	execute()	0	9	1

<?php
/**
 * Copyright © 2019 O2TI. All rights reserved.
 * See LICENSE.txt for license details.
 */

namespace O2TI\SocialLogin\Controller\Endpoint;

use Magento\Framework\App\Action\Action;
use Magento\Framework\App\Action\Context;
use Magento\Framework\Url\DecoderInterface;
use O2TI\SocialLogin\Provider\Provider;

class Index extends Action

The class Magento\Framework\App\Action\Action has been deprecated: 103.0.0 Inheritance in controllers should be avoided in favor of composition

{
    /**
     * @var DecoderInterface
     */
    protected $urlDecoder;

    /**
     * @var Provider
     */
    protected $provider;

    /**
     * Construct.
     *
     * @param Context          $context
     * @param Provider         $provider
     * @param DecoderInterface $urlDecoder
     */
    public function __construct(
        Context $context,
        Provider $provider,
        DecoderInterface $urlDecoder
    ) {
        parent::__construct($context);
        $this->provider = $provider;
        $this->urlDecoder = $urlDecoder;
    }

    /**
     * Dispatch request.
     *
     * @return void
     */
    public function execute()
    {
        $provider = $this->_request->getParam('provider');
        $isSecure = $this->_request->isSecure();
        $referer = $this->_request->getParam('referer');

        $response = $this->provider->setAutenticateAndReferer($provider, $isSecure, $referer);

$isSecure of type boolean is incompatible with the type integer expected by parameter $isSecure of O2TI\SocialLogin\Provider\Provider::setAutenticateAndReferer().

        // phpcs:ignore
        return $this->_redirect($this->urlDecoder->decode($response['redirectUrl']));

The expression return $this->_redirect($this->urlDecoder->decode($response['redirectUrl'])) returns the type Magento\Framework\App\ResponseInterface which is incompatible with the documented return type void.

    }
}