Edit::getLabel() - Code Metrics - elisei/advanced-street-address - Measure and Improve Code Quality continuously with Scrutinizer

Edit::getLabel() A
last analyzed 2021-12-06 13:40 UTC

↳ Parent: Edit

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	1
dl	0
loc	3
rs	10

<?php
/**
 * Copyright © 2021 O2TI. All rights reserved.
 *
 * @author  Bruno Elisei <[email protected]>
 * See LICENSE.txt for license details.
 */

declare(strict_types=1);

namespace O2TI\AdvancedStreetAddress\Block\Customer\Address;

use Magento\Framework\App\Config\ScopeConfigInterface;
use Magento\Framework\View\Element\Template;
use Magento\Framework\View\Element\Template\Context;
use Magento\Store\Model\ScopeInterface;
use Magento\Store\Model\StoreManagerInterface;
use O2TI\AdvancedStreetAddress\Helper\Config;

/**
 *  Edit - Change Template Edit Account.
 */
class Edit extends Template
{
    /**
     * @var Config
     */
    private $config;

    /**
     * @var ScopeInterface
     */
    private $scopeConfig;

    /**
     * @var StoreManagerInterface
     */
    private $storeManagerInterface;

    /**
     * @param ScopeConfigInterface  $scopeConfig
     * @param StoreManagerInterface $storeManagerInterface
     * @param Context               $context
     * @param Config                $config
     * @param array                 $data
     */
    public function __construct(
        ScopeConfigInterface $scopeConfig,
        StoreManagerInterface $storeManagerInterface,
        Context $context,
        Config $config,
        array $data = []
    ) {
        $this->scopeConfig = $scopeConfig;

        $this->storeManagerInterface = $storeManagerInterface;
        $this->config = $config;
        parent::__construct($context, $data);
    }

    /**
     * Get if Use Label.
     *
     * @param int $position
     *
     * @return bool|null
     */
    public function getUseLabel(int $position): ?bool
    {
        return $this->config->getConfigForLabel($position, 'use_label');

    }

    /**
     * Get Label.
     *
     * @param int $position
     *
     * @return string|null
     */
    public function getLabel(int $position): ?string
    {
        return $this->config->getConfigForLabel($position, 'label');
    }

    /**
     * Get Is Required.
     *
     * @param int $position
     *
     * @return string
     */
    public function getIsRequired(int $position): ?string
    {
        if ($this->config->getConfigForValidation($position, 'is_required')) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            return 'required-entry';
        }

        return '';
    }

    /**
     * Get Max Length.
     *
     * @param int $position
     *
     * @return int|null
     */
    public function getMaxLength($position): ?int
    {
        return $this->config->getConfigForValidation($position, 'max_length');
    }
}


1			<?php
2			/**
3			* Copyright © 2021 O2TI. All rights reserved.
4			*
5			* @author Bruno Elisei <[email protected]>
6			* See LICENSE.txt for license details.
7			*/
8
9			declare(strict_types=1);
10
11			namespace O2TI\AdvancedStreetAddress\Block\Customer\Address;
12
13			use Magento\Framework\App\Config\ScopeConfigInterface;
14			use Magento\Framework\View\Element\Template;
15			use Magento\Framework\View\Element\Template\Context;
16			use Magento\Store\Model\ScopeInterface;
17			use Magento\Store\Model\StoreManagerInterface;
18			use O2TI\AdvancedStreetAddress\Helper\Config;
19
20			/**
21			* Edit - Change Template Edit Account.
22			*/
23			class Edit extends Template
24			{
25			/**
26			* @var Config
27			*/
28			private $config;
29
30			/**
31			* @var ScopeInterface
32			*/
33			private $scopeConfig;
34
35			/**
36			* @var StoreManagerInterface
37			*/
38			private $storeManagerInterface;
39
40			/**
41			* @param ScopeConfigInterface $scopeConfig
42			* @param StoreManagerInterface $storeManagerInterface
43			* @param Context $context
44			* @param Config $config
45			* @param array $data
46			*/
47			public function __construct(
48			ScopeConfigInterface $scopeConfig,
49			StoreManagerInterface $storeManagerInterface,
50			Context $context,
51			Config $config,
52			array $data = []
53			) {
54			$this->scopeConfig = $scopeConfig;
			0 ignored issues – show Documentation Bug introduced 2021-12-02 15:53 UTC by Report Bug Copy Issue Report It seems like `$scopeConfig` of type `Magento\Framework\App\Config\ScopeConfigInterface` is incompatible with the declared type `Magento\Store\Model\ScopeInterface` of property `$scopeConfig`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
55			$this->storeManagerInterface = $storeManagerInterface;
56			$this->config = $config;
57			parent::__construct($context, $data);
58			}
59
60			/**
61			* Get if Use Label.
62			*
63			* @param int $position
64			*
65			* @return bool\|null
66			*/
67			public function getUseLabel(int $position): ?bool
68			{
69			return $this->config->getConfigForLabel($position, 'use_label');
			0 ignored issues – show Bug Best Practice introduced 2021-12-02 15:53 UTC by Report Bug Copy Issue Report The expression `return $this->config->ge...$position, 'use_label')` could return the type `string` which is incompatible with the type-hinted return `boolean\|null`. Consider adding an additional type-check to rule them out. Loading history...
70			}
71
72			/**
73			* Get Label.
74			*
75			* @param int $position
76			*
77			* @return string\|null
78			*/
79			public function getLabel(int $position): ?string
80			{
81			return $this->config->getConfigForLabel($position, 'label');
82			}
83
84			/**
85			* Get Is Required.
86			*
87			* @param int $position
88			*
89			* @return string
90			*/
91			public function getIsRequired(int $position): ?string
92			{
93			if ($this->config->getConfigForValidation($position, 'is_required')) {
			0 ignored issues – show Bug Best Practice introduced 2021-12-02 15:53 UTC by Report Bug Copy Issue Report The expression `$this->config->getConfig...osition, 'is_required')` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
94			return 'required-entry';
95			}
96
97			return '';
98			}
99
100			/**
101			* Get Max Length.
102			*
103			* @param int $position
104			*
105			* @return int\|null
106			*/
107			public function getMaxLength($position): ?int
108			{
109			return $this->config->getConfigForValidation($position, 'max_length');
110			}
111			}
112

elisei / advanced-street-address

Edit::getLabel() A last analyzed 2021-12-06 13:40 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Edit::getLabel() A
last analyzed 2021-12-06 13:40 UTC