Issues in PayloadResponder.php (main) - Issues in main - elevenone/stardust - Measure and Improve Code Quality continuously with Scrutinizer

Issues (15)

app/Http/PayloadResponder.php (7 issues)

Labels

Severity

<?php

declare(strict_types = 1);

namespace App\Http;

use DarkMatter\Http\Response;
use DarkMatter\Payload\Payload;
use DarkMatter\Payload\Status;
use DarkMatter\Responder\HtmlResponder;
use DarkMatter\Components\PhtmlRenderer\Factory as RendererFactory;
filter:
    dependency_paths: ["lib/*"]

/**
 * @property string $view
 */

class PayloadResponder extends HtmlResponder
{
    /**
     * @var \DarkMatter\Components\PhtmlRenderer\PhtmlRenderer $renderer
filter:
    dependency_paths: ["lib/*"]
     */
    protected $renderer;

    public function __construct(array $config)
    {
        $this->renderer = (new RendererFactory($config))->makeRenderer();
        parent::__construct($config);
    }

    /**
     * Generates a payload response.
     *
     * @param Payload $payload
     * @return Response
     */
    public function __invoke(Payload $payload): Response
    {
        $body = $this->renderer->render('logs', [

            'logs' => $data['logs'] ?? [],

            'sources' => $data['sources'] ?? [],
            'levels' => $data['levels'] ?? [],
            'filters' => $data['filters'] ?? []
        ]);

        ///return $this->found(['body' => $body]);
//exit;
        // payload
        $payloadResult = $payload->getResult();

        if ($payload->getStatus() === Status::FOUND) {
            return $this->found($payloadResult);
        }

        return $this->error([$payloadResult['error'] ?? 'Unknown Error']);
    }

    /**
     * Respond with an not found message.
     *
     * @return Response
     */
    public function notFound(): Response
    {
        echo 'own notfound method';
        exit;
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
        $this->response->setStatus(404);
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
        $this->response->setBody('<html><title>404 Not found</title>404 Not found</html>');
        return $this->response;
    }






}


1			<?php
2
3			declare(strict_types = 1);
4
5			namespace App\Http;
6
7			use DarkMatter\Http\Response;
8			use DarkMatter\Payload\Payload;
9			use DarkMatter\Payload\Status;
10			use DarkMatter\Responder\HtmlResponder;
11			use DarkMatter\Components\PhtmlRenderer\Factory as RendererFactory;
			0 ignored issues – show Bug introduced 2020-11-01 18:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `DarkMatter\Components\PhtmlRenderer\Factory` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
12
13			/**
14			* @property string $view
15			*/
16
17			class PayloadResponder extends HtmlResponder
18			{
19			/**
20			* @var \DarkMatter\Components\PhtmlRenderer\PhtmlRenderer $renderer
			0 ignored issues – show Bug introduced 2020-11-01 18:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `DarkMatter\Components\PhtmlRenderer\PhtmlRenderer` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
21			*/
22			protected $renderer;
23
24			public function __construct(array $config)
25			{
26			$this->renderer = (new RendererFactory($config))->makeRenderer();
27			parent::__construct($config);
28			}
29
30			/**
31			* Generates a payload response.
32			*
33			* @param Payload $payload
34			* @return Response
35			*/
36			public function __invoke(Payload $payload): Response
37			{
38			$body = $this->renderer->render('logs', [
			0 ignored issues – show Unused Code introduced 2020-11-01 18:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The assignment to `$body` is dead and can be removed. Loading history...
39			'logs' => $data['logs'] ?? [],
			0 ignored issues – show Comprehensibility Best Practice introduced 2020-11-01 18:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$data` seems to never exist and therefore `isset` should always be `false`. Loading history...
40			'sources' => $data['sources'] ?? [],
41			'levels' => $data['levels'] ?? [],
42			'filters' => $data['filters'] ?? []
43			]);
44
45			///return $this->found(['body' => $body]);
46			//exit;
47			// payload
48			$payloadResult = $payload->getResult();
49
50			if ($payload->getStatus() === Status::FOUND) {
51			return $this->found($payloadResult);
52			}
53
54			return $this->error([$payloadResult['error'] ?? 'Unknown Error']);
55			}
56
57			/**
58			* Respond with an not found message.
59			*
60			* @return Response
61			*/
62			public function notFound(): Response
63			{
64			echo 'own notfound method';
65			exit;
			0 ignored issues – show Bug Best Practice introduced 2020-11-01 18:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `DarkMatter\Http\Response`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history... Best Practice introduced 2020-11-01 18:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history...
66			$this->response->setStatus(404);
			0 ignored issues – show Unused Code introduced 2020-11-01 18:15 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$this->response->setStatus(404)` is not reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
67			$this->response->setBody('<html><title>404 Not found</title>404 Not found</html>');
68			return $this->response;
69			}
70
71
72
73
74
75
76			}
77

elevenone / stardust

Issues (15)

app/Http/PayloadResponder.php (7 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like