HomeDomainPayloadTwo::getWelcomePayload() - Code Metrics - Inspection of "restucturing actions" - elevenone/stardust - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( a4880b...68f5b1 )

by Zsolt

created 2020-10-25 18:13 UTC

HomeDomainPayloadTwo::getWelcomePayload() A

↳ Parent: HomeDomainPayloadTwo

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	11
c	1
b	0
f	0
nc	1
nop	0
dl	0
loc	19
rs	9.9

<?php

declare(strict_types=1);

namespace App\Domain;

use DarkMatter\Domain\Domain;

use DarkMatter\Payload\Payload;
use DarkMatter\Payload\Status;

// https://github.com/radarphp/Radar.Adr/blob/2.x/src/Responder/Responder.php

/**
 * Class HomeDomain
 *
 * This is a very simple domain which is normally used to provide some kind of data for you views.
 *
 * @package DarkMatterApp\Domains
 */
class HomeDomainPayloadTwo extends Domain
{
    public function __construct(array $id)
    {
        $this->id = $id['id'];

    }

    /**
     * Retrieves welcome text.
     *
     * @return string
     */
    public function getWelcomePayload() : Payload
    {
        // get the data from the db or filesystem
        $payload_dymmy_data = [
            'body'  => 'welcome to stardust / darkmatter / respondertest / ID: ' . $this->id,
            'extras' => [
                'message'  => 'welcome to stardust / darkmatter / ID: ' . $this->id,
                'note'  => 'message from: ' . __CLASS__,
                'button' => '<a href="http://localhost:8000">index</a>',
                'button2' => '<a href="/payloadtest/">payloadtest</a>',
                'button3' => '<a href="/payloadtest/43545">payloadtest/43545</a>',
                'id' => $this->id
            ]
        ];

        // if we get the data or file or whatever, then set the payload STATUS to FOUND
        $payload = new Payload(Status::FOUND, $payload_dymmy_data);

        return $payload;

    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace App\Domain;
6
7			use DarkMatter\Domain\Domain;
8
9			use DarkMatter\Payload\Payload;
10			use DarkMatter\Payload\Status;
11
12			// https://github.com/radarphp/Radar.Adr/blob/2.x/src/Responder/Responder.php
13
14			/**
15			* Class HomeDomain
16			*
17			* This is a very simple domain which is normally used to provide some kind of data for you views.
18			*
19			* @package DarkMatterApp\Domains
20			*/
21			class HomeDomainPayloadTwo extends Domain
22			{
23			public function __construct(array $id)
24			{
25			$this->id = $id['id'];
			0 ignored issues – show Bug Best Practice introduced 2020-10-25 18:22 UTC by Report Bug Copy Issue Report The property `id` does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly. Loading history...
26			}
27
28			/**
29			* Retrieves welcome text.
30			*
31			* @return string
32			*/
33			public function getWelcomePayload() : Payload
34			{
35			// get the data from the db or filesystem
36			$payload_dymmy_data = [
37			'body' => 'welcome to stardust / darkmatter / respondertest / ID: ' . $this->id,
38			'extras' => [
39			'message' => 'welcome to stardust / darkmatter / ID: ' . $this->id,
40			'note' => 'message from: ' . __CLASS__,
41			'button' => '<a href="http://localhost:8000">index</a>',
42			'button2' => '<a href="/payloadtest/">payloadtest</a>',
43			'button3' => '<a href="/payloadtest/43545">payloadtest/43545</a>',
44			'id' => $this->id
45			]
46			];
47
48			// if we get the data or file or whatever, then set the payload STATUS to FOUND
49			$payload = new Payload(Status::FOUND, $payload_dymmy_data);
50
51			return $payload;
			0 ignored issues – show Bug Best Practice introduced 2020-10-25 18:22 UTC by Report Bug Copy Issue Report The expression `return $payload` returns the type `DarkMatter\Payload\Payload` which is incompatible with the documented return type `string`. Loading history...
52			}
53			}
54

elevenone / stardust

Push — main ( a4880b...68f5b1 )

HomeDomainPayloadTwo::getWelcomePayload() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like