PaginatorCompilerPassTest::testShouldAddPagination() - Code Metrics - Inspection of "Add Symfony 4's compatibility" - eleven-labs/api-service-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#6)

unknown

created 2020-09-04 11:50 UTC

testShouldAddPagination() A

↳ Parent: PaginatorCompilerPassTest

Complexity

Conditions	3
Paths	1

Size

Total Lines	53
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	35
nc	1
nop	0
dl	0
loc	53
rs	9.36
c	1
b	0
f	0

How to fix Long Method

<?php

namespace ElevenLabs\ApiServiceBundle\Tests\DependencyInjection\Compiler;

use ElevenLabs\ApiServiceBundle\DependencyInjection\Compiler\PaginatorCompilerPass;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;

/**
 * Class PaginatorCompilerPassTest.
 */
class PaginatorCompilerPassTest extends TestCase
{
    /**
     * @var ContainerBuilder|MockObject
     */
    private $containerBuilder;

    /**
     * @var Definition|MockObject
     */
    private $pagination;

    /**
     * @var Definition|MockObject
     */
    private $provider;

    public function setUp()
    {
        $this->pagination = $this->createMock(Definition::class);
        $this->provider = $this->createMock(Definition::class);
        $this->containerBuilder = $this->createMock(ContainerBuilder::class);
    }

    /**
     * @dataProvider dataProviderTestShouldNotAddPagination
     *
     * @param array $config
     *
     * @throws \Exception
     */
    public function testShouldNotAddPagination(array $config)
    {
        $this->containerBuilder
            ->expects($this->once())
            ->method('getExtensionConfig')
            ->with('api_service')
            ->willReturn([$config])
        ;
        $this->containerBuilder
            ->expects($this->once())
            ->method('findTaggedServiceIds')
            ->with('api_service.pagination_provider')
            ->willReturn([])
        ;
        $this->containerBuilder
            ->expects($this->once())
            ->method('getDefinition')
            ->with('api_service.pagination_provider.chain')
            ->willReturn($this->pagination)
        ;

        $compiler = new PaginatorCompilerPass();
        $compiler->process($this->containerBuilder);
    }

    public function dataProviderTestShouldNotAddPagination(): array
    {
        return [
            [
                [],
            ],
            [
                ['pagination' => []],
            ],
            [
                [
                    'pagination' => [
                        'hal' => [
                            'page' => '_links.self.href.page',
                            'perPage' => 'itemsPerPage',
                            'totalPages' => '_links.last.href.page',
                            'totalItems' => 'totalItems',
                        ],
                    ],
                ],
            ],
        ];
    }

    public function testShouldAddPagination()
    {
        $this->containerBuilder
            ->expects($this->once())
            ->method('getExtensionConfig')
            ->with('api_service')
            ->willReturn([
                [
                    'pagination' => [
                        'hal' => [
                            'page' => '_links.self.href.page',
                            'perPage' => 'itemsPerPage',
                            'totalPages' => '_links.last.href.page',
                            'totalItems' => 'totalItems',
                        ],
                    ],
                ]
            ])
        ;
        $this->containerBuilder
            ->expects($this->once())
            ->method('findTaggedServiceIds')
            ->with('api_service.pagination_provider')
            ->willReturn([
                'foo' => [['provider' => 'hal']]
            ])
        ;
        $this->containerBuilder
            ->expects($this->exactly(2))
            ->method('getDefinition')
            ->willReturnCallback(function ($id) {
                $this->assertTrue(\in_array($id, ['api_service.pagination_provider.chain', 'foo']));

                if ('api_service.pagination_provider.chain' === $id) {
                    $this->pagination->expects($this->once())->method('replaceArgument')->willReturnCallback(function ($key, $argument) {
                        $this->assertSame(0, $key);
                        $this->assertIsArray($argument);
                        $this->assertNotEmpty($argument);
                    });
                } else if ('foo' === $id) {
                    $this->pagination->expects($this->exactly(2))->method('replaceArgument')->willReturnCallback(function ($key, $argument) {
                        $this->assertSame(0, $key);
                        $this->assertIsArray($argument);
                        $this->assertNotEmpty($argument);
                    });
                }

                return $this->pagination;
            })
        ;

        $compiler = new PaginatorCompilerPass();
        $compiler->process($this->containerBuilder);
    }
}


1			<?php
2
3			namespace ElevenLabs\ApiServiceBundle\Tests\DependencyInjection\Compiler;
4
5			use ElevenLabs\ApiServiceBundle\DependencyInjection\Compiler\PaginatorCompilerPass;
6			use PHPUnit\Framework\MockObject\MockObject;
7			use PHPUnit\Framework\TestCase;
8			use Symfony\Component\DependencyInjection\ContainerBuilder;
9			use Symfony\Component\DependencyInjection\Definition;
10
11			/**
12			* Class PaginatorCompilerPassTest.
13			*/
14			class PaginatorCompilerPassTest extends TestCase
15			{
16			/**
17			* @var ContainerBuilder\|MockObject
18			*/
19			private $containerBuilder;
20
21			/**
22			* @var Definition\|MockObject
23			*/
24			private $pagination;
25
26			/**
27			* @var Definition\|MockObject
28			*/
29			private $provider;
30
31			public function setUp()
32			{
33			$this->pagination = $this->createMock(Definition::class);
34			$this->provider = $this->createMock(Definition::class);
35			$this->containerBuilder = $this->createMock(ContainerBuilder::class);
36			}
37
38			/**
39			* @dataProvider dataProviderTestShouldNotAddPagination
40			*
41			* @param array $config
42			*
43			* @throws \Exception
44			*/
45			public function testShouldNotAddPagination(array $config)
46			{
47			$this->containerBuilder
48			->expects($this->once())
49			->method('getExtensionConfig')
50			->with('api_service')
51			->willReturn([$config])
52			;
53			$this->containerBuilder
54			->expects($this->once())
55			->method('findTaggedServiceIds')
56			->with('api_service.pagination_provider')
57			->willReturn([])
58			;
59			$this->containerBuilder
60			->expects($this->once())
61			->method('getDefinition')
62			->with('api_service.pagination_provider.chain')
63			->willReturn($this->pagination)
64			;
65
66			$compiler = new PaginatorCompilerPass();
67			$compiler->process($this->containerBuilder);
68			}
69
70			public function dataProviderTestShouldNotAddPagination(): array
71			{
72			return [
73			[
74			[],
75			],
76			[
77			['pagination' => []],
78			],
79			[
80			[
81			'pagination' => [
82			'hal' => [
83			'page' => '_links.self.href.page',
84			'perPage' => 'itemsPerPage',
85			'totalPages' => '_links.last.href.page',
86			'totalItems' => 'totalItems',
87			],
88			],
89			],
90			],
91			];
92			}
93
94			public function testShouldAddPagination()
95			{
96			$this->containerBuilder
97			->expects($this->once())
98			->method('getExtensionConfig')
99			->with('api_service')
100			->willReturn([
101			[
102			'pagination' => [
103			'hal' => [
104			'page' => '_links.self.href.page',
105			'perPage' => 'itemsPerPage',
106			'totalPages' => '_links.last.href.page',
107			'totalItems' => 'totalItems',
108			],
109			],
110			]
111			])
112			;
113			$this->containerBuilder
114			->expects($this->once())
115			->method('findTaggedServiceIds')
116			->with('api_service.pagination_provider')
117			->willReturn([
118			'foo' => [['provider' => 'hal']]
119			])
120			;
121			$this->containerBuilder
122			->expects($this->exactly(2))
123			->method('getDefinition')
124			->willReturnCallback(function ($id) {
125			$this->assertTrue(\in_array($id, ['api_service.pagination_provider.chain', 'foo']));
126
127			if ('api_service.pagination_provider.chain' === $id) {
128			$this->pagination->expects($this->once())->method('replaceArgument')->willReturnCallback(function ($key, $argument) {
129			$this->assertSame(0, $key);
130			$this->assertIsArray($argument);
131			$this->assertNotEmpty($argument);
132			});
133			} else if ('foo' === $id) {
134			$this->pagination->expects($this->exactly(2))->method('replaceArgument')->willReturnCallback(function ($key, $argument) {
135			$this->assertSame(0, $key);
136			$this->assertIsArray($argument);
137			$this->assertNotEmpty($argument);
138			});
139			}
140
141			return $this->pagination;
142			})
143			;
144
145			$compiler = new PaginatorCompilerPass();
146			$compiler->process($this->containerBuilder);
147			}
148			}
149

eleven-labs / api-service-bundle

Pull Request — master (#6)

testShouldAddPagination() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like