Options::add() - Code Metrics - Inspection of "Moving builds to travis" - ekowabaka/clearice - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8bde3f...f8d0b5 )

by James Ekow Abaka

created 2015-11-22 16:02 UTC

Options::add() B

↳ Parent: Options

Complexity

Conditions	6
Paths	17

Size

Total Lines	18
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	17
CRAP Score	6

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	18
ccs	17
cts	17
cp	1
rs	8.8571
cc	6
eloc	12
nc	17
nop	1
crap	6

<?php

namespace clearice;

class Options //implements \ArrayAccess, \Iterator
{
    private $options = [];
    private $index = 0;

    
    /**
     * A map of all the options the parser recognises. 
     * The map is actually an array which associates short or long options with 
     * their appropriate parameters. Options which have both long and short 
     * versions would be repeated. This structure is used to quickly find the 
     * paramters of an option whether in the short form or long form. This 
     * parameter is automatically populated by the library as options are added.
     * 
     * @var array
     */    
    private $map;
    
    public function add($options)
    {
        foreach ($options as $option) {
            if (is_string($option)) {
                $option = $this->stringOptionToArray($option);
            }
            $option = $this->fillOption($option);
            $this->options[] = $option;
            $command = isset($option['command']) ? $option['command'] : '__default__';
            if (isset($option['short'])) {
                $this->map[$command][$option['short']] = $option;
            }
            if (isset($option['long'])) {
                $this->map[$command][$option['long']] = $option;
            }
        }        
        $this->options += $options;
    }

    private function fillOption($option)
    {
        $option['has_value'] = isset($option['has_value']) ? $option['has_value'] : false;
        $option['command'] = isset($option['command']) ? $option['command'] : null;
        $option['multi'] = isset($option['multi']) ? $option['multi'] : null;
        $option['group'] = isset($option['group']) ? $option['group'] : null;
        return $option;
    }
    
    public function getMap()
    {
        return $this->map;
    }
    
    private function stringOptionToArray($option)
    {
        $newOption = [];
        if (strlen($option) == 1) {
            $newOption['short'] = $option;
        } else {
            $newOption['long'] = $option;
        }
        return $newOption;
    }
    
    public function getArray()
    {
        return $this->options;
    }

}
// Incorrect placement according to PSR2
class MyClass
{
    public function foo()
    {

    }
    // This blank line is not allowed.

}

// Correct
class MyClass
{
    public function foo()
    {

    } // No blank lines after this line.
}



1		<?php
2
3		namespace clearice;
4
5		class Options //implements \ArrayAccess, \Iterator
6		{
7		private $options = [];
8		private $index = 0;
		0 ignored issues – show Unused Code introduced 2015-11-22 16:04 UTC by Report Bug Copy Issue Report The property `$index` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
9
10		/**
11		* A map of all the options the parser recognises.
12		* The map is actually an array which associates short or long options with
13		* their appropriate parameters. Options which have both long and short
14		* versions would be repeated. This structure is used to quickly find the
15		* paramters of an option whether in the short form or long form. This
16		* parameter is automatically populated by the library as options are added.
17		*
18		* @var array
19		*/
20		private $map;
21
22	27	public function add($options)
23		{
24	27	foreach ($options as $option) {
25	27	if (is_string($option)) {
26	4	$option = $this->stringOptionToArray($option);
27	4	}
28	27	$option = $this->fillOption($option);
29	27	$this->options[] = $option;
30	27	$command = isset($option['command']) ? $option['command'] : '__default__';
31	27	if (isset($option['short'])) {
32	26	$this->map[$command][$option['short']] = $option;
33	26	}
34	27	if (isset($option['long'])) {
35	27	$this->map[$command][$option['long']] = $option;
36	27	}
37	27	}
38	27	$this->options += $options;
39	27	}
40
41	27	private function fillOption($option)
42		{
43	27	$option['has_value'] = isset($option['has_value']) ? $option['has_value'] : false;
44	27	$option['command'] = isset($option['command']) ? $option['command'] : null;
45	27	$option['multi'] = isset($option['multi']) ? $option['multi'] : null;
46	27	$option['group'] = isset($option['group']) ? $option['group'] : null;
47	27	return $option;
48		}
49
50	24	public function getMap()
51		{
52	24	return $this->map;
53		}
54
55	4	private function stringOptionToArray($option)
56		{
57	4	$newOption = [];
58	4	if (strlen($option) == 1) {
59	1	$newOption['short'] = $option;
60	1	} else {
61	4	$newOption['long'] = $option;
62		}
63	4	return $newOption;
64		}
65
66	8	public function getArray()
67		{
68	8	return $this->options;
69		}
70
71		}
		0 ignored issues – show Coding Style introduced 2015-11-22 16:04 UTC by Report Bug Copy Issue Report According to PSR2, the closing brace of classes should be placed on the next line directly after the body. Below you find some examples: // Incorrect placement according to PSR2 class MyClass { public function foo() { } // This blank line is not allowed. } // Correct class MyClass { public function foo() { } // No blank lines after this line. } Loading history...
72
73

ekowabaka / clearice

Push — master ( 8bde3f...f8d0b5 )

Options::add() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like