FileLinkFormatConfigurationTrait::addFileLinkFormatConfigurationNodeFromDefaultsConfiguration() - Code Metrics - Inspection of "feat(all): rewrite configuration and options manag..." - ekino/drupal-debug - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#77)

by Thomas

created 2019-07-10 13:46 UTC

addFileLinkFormatConfigurationNodeFromDefaultsConfiguration() A

↳ Parent: FileLinkFormatConfigurationTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	2
dl	0
loc	3
ccs	2
cts	2
cp	1
crap	1
rs	10

<?php

declare(strict_types=1);

/*
 * This file is part of the ekino Drupal Debug project.
 *
 * (c) ekino
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Ekino\Drupal\Debug\Configuration;

use Ekino\Drupal\Debug\Configuration\Model\ActionConfiguration;
use Ekino\Drupal\Debug\Configuration\Model\DefaultsConfiguration as DefaultsConfigurationModel;
use Symfony\Component\Config\Definition\Builder\NodeBuilder;

trait FileLinkFormatConfigurationTrait
{
    private static function addFileLinkFormatConfigurationNode(NodeBuilder $nodeBuilder, ?string $defaultFileLinkFormat): NodeBuilder
    {
        return $nodeBuilder

            ->scalarNode('file_link_format')
                ->defaultValue($defaultFileLinkFormat)
            ->end();
    }

    private static function addFileLinkFormatConfigurationNodeFromDefaultsConfiguration(NodeBuilder $nodeBuilder, DefaultsConfigurationModel $defaultsConfiguration): NodeBuilder
    {
        return self::addFileLinkFormatConfigurationNode($nodeBuilder, $defaultsConfiguration->getFileLinkFormat());
    }

    private static function getConfiguredFileLinkFormat(ActionConfiguration $actionConfiguration): ?string
    {
        $processedConfiguration = $actionConfiguration->getProcessedConfiguration();

        return $processedConfiguration['file_link_format'];
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/*
6		* This file is part of the ekino Drupal Debug project.
7		*
8		* (c) ekino
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace Ekino\Drupal\Debug\Configuration;
15
16		use Ekino\Drupal\Debug\Configuration\Model\ActionConfiguration;
17		use Ekino\Drupal\Debug\Configuration\Model\DefaultsConfiguration as DefaultsConfigurationModel;
18		use Symfony\Component\Config\Definition\Builder\NodeBuilder;
19
20		trait FileLinkFormatConfigurationTrait
21		{
22	18	private static function addFileLinkFormatConfigurationNode(NodeBuilder $nodeBuilder, ?string $defaultFileLinkFormat): NodeBuilder
23		{
24		return $nodeBuilder
		0 ignored issues – show Bug Best Practice introduced 2019-07-10 13:51 UTC by Report Bug Copy Issue Report The expression `return $nodeBuilder->sca...tFileLinkFormat)->end()` returns the type `null` which is incompatible with the type-hinted return `Symfony\Component\Config...ion\Builder\NodeBuilder`. Loading history...
25	18	->scalarNode('file_link_format')
26	18	->defaultValue($defaultFileLinkFormat)
27	18	->end();
28		}
29
30	18	private static function addFileLinkFormatConfigurationNodeFromDefaultsConfiguration(NodeBuilder $nodeBuilder, DefaultsConfigurationModel $defaultsConfiguration): NodeBuilder
31		{
32	18	return self::addFileLinkFormatConfigurationNode($nodeBuilder, $defaultsConfiguration->getFileLinkFormat());
33		}
34
35		private static function getConfiguredFileLinkFormat(ActionConfiguration $actionConfiguration): ?string
36		{
37		$processedConfiguration = $actionConfiguration->getProcessedConfiguration();
38
39		return $processedConfiguration['file_link_format'];
40		}
41		}
42

ekino / drupal-debug

Pull Request — master (#77)

addFileLinkFormatConfigurationNodeFromDefaultsConfiguration() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like