Inspection of "Merge pull request #250 from jderusse/release" - ekino/EkinoNewRelicBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( be00cd...8a921f )

by Jérémy

created 2020-11-30 08:35 UTC

Status

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -28,7 +28,7 @@
 block discarded – undo
     public function testControllerAsClosure()
     {
         $request = new Request();
-        $request->attributes->set('_controller', function () {
+        $request->attributes->set('_controller', function() {
         });
 
         $strategy = new ControllerNamingStrategy();

Please login to merge, or discard this patch.

Tests/Listener/DeprecationListenerTest.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -25,7 +25,7 @@  discard block
 block discarded – undo
 
         $listener = new DeprecationListener($interactor);
 
-        \set_error_handler(function () { return false; });
+        \set_error_handler(function() { return false; });
         try {
             $listener->register();
             @\trigger_error('This is a deprecation', E_USER_DEPRECATED);
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
 
         $listener = new DeprecationListener($interactor);
 
-        \set_error_handler(function () { return false; });
+        \set_error_handler(function() { return false; });
         $e = \error_reporting(0);
         try {
             $listener->register();
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
 
         $listener = new DeprecationListener($interactor);
 
-        \set_error_handler(function () { return false; });
+        \set_error_handler(function() { return false; });
         try {
             $listener->register();
             @\trigger_error('This is a notice', E_USER_NOTICE);
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
 
         $listener = new DeprecationListener($interactor);
 
-        \set_error_handler(function () { return false; });
+        \set_error_handler(function() { return false; });
         try {
             $listener->register();
             $listener->unregister();

Please login to merge, or discard this patch.

Listener/DeprecationListener.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -33,7 +33,7 @@
 block discarded – undo
         }
         $this->isRegistered = true;
 
-        $prevErrorHandler = \set_error_handler(function ($type, $msg, $file, $line, $context = []) use (&$prevErrorHandler) {
+        $prevErrorHandler = \set_error_handler(function($type, $msg, $file, $line, $context = []) use (&$prevErrorHandler) {
             if (E_USER_DEPRECATED === $type) {
                 $this->interactor->noticeThrowable(new DeprecationException($msg, 0, $type, $file, $line));
             }

Please login to merge, or discard this patch.

Listener/CommandListener.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -61,10 +61,10 @@  discard block
 block discarded – undo
 
         // send parameters to New Relic
         foreach ($input->getOptions() as $key => $value) {
-            $key = '--'.$key;
+            $key = '--' . $key;
             if (\is_array($value)) {
                 foreach ($value as $k => $v) {
-                    $this->interactor->addCustomParameter($key.'['.$k.']', $v);
+                    $this->interactor->addCustomParameter($key . '[' . $k . ']', $v);
                 }
             } else {
                 $this->interactor->addCustomParameter($key, $value);
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
         foreach ($input->getArguments() as $key => $value) {
             if (\is_array($value)) {
                 foreach ($value as $k => $v) {
-                    $this->interactor->addCustomParameter($key.'['.$k.']', $v);
+                    $this->interactor->addCustomParameter($key . '[' . $k . ']', $v);
                 }
             } else {
                 $this->interactor->addCustomParameter($key, $value);

Please login to merge, or discard this patch.

Listener/ResponseListener.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -88,11 +88,11 @@
 block discarded – undo
                     $response->setContent(''); // free the memory
 
                     if (null === $this->newRelicTwigExtension || false === $this->newRelicTwigExtension->isHeaderCalled()) {
-                        $responseContent = \preg_replace('|<head>|i', '$0'.$this->interactor->getBrowserTimingHeader(), $responseContent);
+                        $responseContent = \preg_replace('|<head>|i', '$0' . $this->interactor->getBrowserTimingHeader(), $responseContent);
                     }
 
                     if (null === $this->newRelicTwigExtension || false === $this->newRelicTwigExtension->isFooterCalled()) {
-                        $responseContent = \preg_replace('|</body>|i', $this->interactor->getBrowserTimingFooter().'$0', $responseContent);
+                        $responseContent = \preg_replace('|</body>|i', $this->interactor->getBrowserTimingFooter() . '$0', $responseContent);
                     }
 
                     $response->setContent($responseContent);

Please login to merge, or discard this patch.

DependencyInjection/Configuration.php 1 patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

@@ -38,8 +38,8 @@  discard block
 block discarded – undo
                     ->prototype('scalar')
                     ->end()
                     ->beforeNormalization()
-                        ->ifTrue(function ($v) { return !\is_array($v); })
-                        ->then(function ($v) { return \array_values(\array_filter(\explode(';', (string) $v))); })
+                        ->ifTrue(function($v) { return !\is_array($v); })
+                        ->then(function($v) { return \array_values(\array_filter(\explode(';', (string) $v))); })
                     ->end()
                 ->end()
                 ->scalarNode('xmit')->defaultValue(false)->end()
@@ -57,8 +57,8 @@  discard block
 block discarded – undo
                             ->prototype('scalar')
                             ->end()
                             ->beforeNormalization()
-                                ->ifTrue(function ($v) { return !\is_array($v); })
-                                ->then(function ($v) { return (array) $v; })
+                                ->ifTrue(function($v) { return !\is_array($v); })
+                                ->then(function($v) { return (array) $v; })
                             ->end()
                         ->end()
                     ->end()
@@ -81,16 +81,16 @@  discard block
 block discarded – undo
                             ->prototype('scalar')
                             ->end()
                             ->beforeNormalization()
-                                ->ifTrue(function ($v) { return !\is_array($v); })
-                                ->then(function ($v) { return (array) $v; })
+                                ->ifTrue(function($v) { return !\is_array($v); })
+                                ->then(function($v) { return (array) $v; })
                             ->end()
                         ->end()
                         ->arrayNode('ignored_paths')
                             ->prototype('scalar')
                             ->end()
                             ->beforeNormalization()
-                                ->ifTrue(function ($v) { return !\is_array($v); })
-                                ->then(function ($v) { return (array) $v; })
+                                ->ifTrue(function($v) { return !\is_array($v); })
+                                ->then(function($v) { return (array) $v; })
                             ->end()
                         ->end()
                         ->scalarNode('using_symfony_cache')->defaultFalse()->end()
@@ -107,18 +107,18 @@  discard block
 block discarded – undo
                             ->canBeUnset()
                             ->beforeNormalization()
                                 ->ifString()
-                                ->then(function ($v) { return ['elements' => [$v]]; })
+                                ->then(function($v) { return ['elements' => [$v]]; })
                             ->end()
                             ->beforeNormalization()
-                                ->ifTrue(function ($v) { return \is_array($v) && \is_numeric(\key($v)); })
-                                ->then(function ($v) { return ['elements' => $v]; })
+                                ->ifTrue(function($v) { return \is_array($v) && \is_numeric(\key($v)); })
+                                ->then(function($v) { return ['elements' => $v]; })
                             ->end()
                             ->validate()
-                                ->ifTrue(function ($v) { return empty($v); })
+                                ->ifTrue(function($v) { return empty($v); })
                                 ->thenUnset()
                             ->end()
                             ->validate()
-                                ->always(function ($v) {
+                                ->always(function($v) {
                                     $isExclusive = null;
                                     if (isset($v['type'])) {
                                         $isExclusive = 'exclusive' === $v['type'];

Please login to merge, or discard this patch.

DependencyInjection/EkinoNewRelicExtension.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -44,7 +44,7 @@  discard block
 block discarded – undo
         $configuration = new Configuration();
         $config = $this->processConfiguration($configuration, $configs);
 
-        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
+        $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
         $loader->load('services.xml');
 
         $container->setAlias(NewRelicInteractorInterface::class, $this->getInteractorServiceId($config))->setPublic(false);
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
                 ->setDecoratedService(NewRelicInteractorInterface::class)
                 ->setArguments(
                     [
-                        '$interactor' => new Reference(LoggingInteractorDecorator::class.'.inner'),
+                        '$interactor' => new Reference(LoggingInteractorDecorator::class . '.inner'),
                         '$logger' => new Reference('logger', ContainerInterface::NULL_ON_INVALID_REFERENCE),
                     ]
                 )

Please login to merge, or discard this patch.

DependencyInjection/Compiler/MonologHandlerPass.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -29,7 +29,7 @@  discard block
 block discarded – undo
         $configuration = $container->getParameter('ekino.new_relic.monolog');
         if ($container->hasDefinition('ekino.new_relic.logs_handler') && $container->hasParameter('ekino.new_relic.application_name')) {
             $container->findDefinition('ekino.new_relic.logs_handler')
-                ->setArgument('$level', \is_int($configuration['level']) ? $configuration['level'] : \constant('Monolog\Logger::'.\strtoupper($configuration['level'])))
+                ->setArgument('$level', \is_int($configuration['level']) ? $configuration['level'] : \constant('Monolog\Logger::' . \strtoupper($configuration['level'])))
                 ->setArgument('$bubble', true)
                 ->setArgument('$appName', $container->getParameter('ekino.new_relic.application_name'));
         }
@@ -44,9 +44,9 @@  discard block
 block discarded – undo
 
         foreach ($channels as $channel) {
             try {
-                $def = $container->getDefinition('app' === $channel ? 'monolog.logger' : 'monolog.logger.'.$channel);
+                $def = $container->getDefinition('app' === $channel ? 'monolog.logger' : 'monolog.logger.' . $channel);
             } catch (InvalidArgumentException $e) {
-                $msg = 'NewRelicBundle configuration error: The logging channel "'.$channel.'" does not exist.';
+                $msg = 'NewRelicBundle configuration error: The logging channel "' . $channel . '" does not exist.';
                 throw new \InvalidArgumentException($msg, 0, $e);
             }
             $def->addMethodCall('pushHandler', [new Reference('ekino.new_relic.logs_handler')]);

Please login to merge, or discard this patch.

Tests/NewRelic/LoggingInteractorDecoratorTest.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -52,7 +52,7 @@  discard block
 block discarded – undo
                 continue;
             }
 
-            $arguments = \array_map(function (\ReflectionParameter $parameter) {
+            $arguments = \array_map(function(\ReflectionParameter $parameter) {
                 return $this->getTypeStub($parameter->getType());
             }, $method->getParameters());
 
@@ -82,11 +82,11 @@  discard block
 block discarded – undo
             case 'Throwable':
                 return new \Exception();
             case 'callable':
-                return function () {};
+                return function() {};
             case 'array':
                 return \array_fill(0, 2, \uniqid('', true));
             default:
-                throw new \UnexpectedValueException('Unknown type. '.$type->getName());
+                throw new \UnexpectedValueException('Unknown type. ' . $type->getName());
         }
     }
 }

Please login to merge, or discard this patch.

		@@ -61,10 +61,10 @@ discard block
		block discarded – undo
61	61
62	62	// send parameters to New Relic
63	63	foreach ($input->getOptions() as $key => $value) {
64		- $key = '--'.$key;
	64	+ $key = '--' . $key;
65	65	if (\is_array($value)) {
66	66	foreach ($value as $k => $v) {
67		- $this->interactor->addCustomParameter($key.'['.$k.']', $v);
	67	+ $this->interactor->addCustomParameter($key . '[' . $k . ']', $v);
68	68	}
69	69	} else {
70	70	$this->interactor->addCustomParameter($key, $value);
		@@ -74,7 +74,7 @@ discard block
		block discarded – undo
74	74	foreach ($input->getArguments() as $key => $value) {
75	75	if (\is_array($value)) {
76	76	foreach ($value as $k => $v) {
77		- $this->interactor->addCustomParameter($key.'['.$k.']', $v);
	77	+ $this->interactor->addCustomParameter($key . '[' . $k . ']', $v);
78	78	}
79	79	} else {
80	80	$this->interactor->addCustomParameter($key, $value);

		@@ -28,7 +28,7 @@
		block discarded – undo
28	28	public function testControllerAsClosure()
29	29	{
30	30	$request = new Request();
31		- $request->attributes->set('_controller', function () {
	31	+ $request->attributes->set('_controller', function() {
32	32	});
33	33
34	34	$strategy = new ControllerNamingStrategy();

		@@ -25,7 +25,7 @@ discard block
		block discarded – undo
25	25
26	26	$listener = new DeprecationListener($interactor);
27	27
28		- \set_error_handler(function () { return false; });
	28	+ \set_error_handler(function() { return false; });
29	29	try {
30	30	$listener->register();
31	31	@\trigger_error('This is a deprecation', E_USER_DEPRECATED);
		@@ -42,7 +42,7 @@ discard block
		block discarded – undo
42	42
43	43	$listener = new DeprecationListener($interactor);
44	44
45		- \set_error_handler(function () { return false; });
	45	+ \set_error_handler(function() { return false; });
46	46	$e = \error_reporting(0);
47	47	try {
48	48	$listener->register();
		@@ -61,7 +61,7 @@ discard block
		block discarded – undo
61	61
62	62	$listener = new DeprecationListener($interactor);
63	63
64		- \set_error_handler(function () { return false; });
	64	+ \set_error_handler(function() { return false; });
65	65	try {
66	66	$listener->register();
67	67	@\trigger_error('This is a notice', E_USER_NOTICE);
		@@ -98,7 +98,7 @@ discard block
		block discarded – undo
98	98
99	99	$listener = new DeprecationListener($interactor);
100	100
101		- \set_error_handler(function () { return false; });
	101	+ \set_error_handler(function() { return false; });
102	102	try {
103	103	$listener->register();
104	104	$listener->unregister();

		@@ -33,7 +33,7 @@
		block discarded – undo
33	33	}
34	34	$this->isRegistered = true;
35	35
36		- $prevErrorHandler = \set_error_handler(function ($type, $msg, $file, $line, $context = []) use (&$prevErrorHandler) {
	36	+ $prevErrorHandler = \set_error_handler(function($type, $msg, $file, $line, $context = []) use (&$prevErrorHandler) {
37	37	if (E_USER_DEPRECATED === $type) {
38	38	$this->interactor->noticeThrowable(new DeprecationException($msg, 0, $type, $file, $line));
39	39	}

		@@ -88,11 +88,11 @@
		block discarded – undo
88	88	$response->setContent(''); // free the memory
89	89
90	90	if (null === $this->newRelicTwigExtension \|\| false === $this->newRelicTwigExtension->isHeaderCalled()) {
91		- $responseContent = \preg_replace('\|<head>\|i', '$0'.$this->interactor->getBrowserTimingHeader(), $responseContent);
	91	+ $responseContent = \preg_replace('\|<head>\|i', '$0' . $this->interactor->getBrowserTimingHeader(), $responseContent);
92	92	}
93	93
94	94	if (null === $this->newRelicTwigExtension \|\| false === $this->newRelicTwigExtension->isFooterCalled()) {
95		- $responseContent = \preg_replace('\|</body>\|i', $this->interactor->getBrowserTimingFooter().'$0', $responseContent);
	95	+ $responseContent = \preg_replace('\|</body>\|i', $this->interactor->getBrowserTimingFooter() . '$0', $responseContent);
96	96	}
97	97
98	98	$response->setContent($responseContent);

		@@ -38,8 +38,8 @@ discard block
		block discarded – undo
38	38	->prototype('scalar')
39	39	->end()
40	40	->beforeNormalization()
41		- ->ifTrue(function ($v) { return !\is_array($v); })
42		- ->then(function ($v) { return \array_values(\array_filter(\explode(';', (string) $v))); })
	41	+ ->ifTrue(function($v) { return !\is_array($v); })
	42	+ ->then(function($v) { return \array_values(\array_filter(\explode(';', (string) $v))); })
43	43	->end()
44	44	->end()
45	45	->scalarNode('xmit')->defaultValue(false)->end()
		@@ -57,8 +57,8 @@ discard block
		block discarded – undo
57	57	->prototype('scalar')
58	58	->end()
59	59	->beforeNormalization()
60		- ->ifTrue(function ($v) { return !\is_array($v); })
61		- ->then(function ($v) { return (array) $v; })
	60	+ ->ifTrue(function($v) { return !\is_array($v); })
	61	+ ->then(function($v) { return (array) $v; })
62	62	->end()
63	63	->end()
64	64	->end()
		@@ -81,16 +81,16 @@ discard block
		block discarded – undo
81	81	->prototype('scalar')
82	82	->end()
83	83	->beforeNormalization()
84		- ->ifTrue(function ($v) { return !\is_array($v); })
85		- ->then(function ($v) { return (array) $v; })
	84	+ ->ifTrue(function($v) { return !\is_array($v); })
	85	+ ->then(function($v) { return (array) $v; })
86	86	->end()
87	87	->end()
88	88	->arrayNode('ignored_paths')
89	89	->prototype('scalar')
90	90	->end()
91	91	->beforeNormalization()
92		- ->ifTrue(function ($v) { return !\is_array($v); })
93		- ->then(function ($v) { return (array) $v; })
	92	+ ->ifTrue(function($v) { return !\is_array($v); })
	93	+ ->then(function($v) { return (array) $v; })
94	94	->end()
95	95	->end()
96	96	->scalarNode('using_symfony_cache')->defaultFalse()->end()
		@@ -107,18 +107,18 @@ discard block
		block discarded – undo
107	107	->canBeUnset()
108	108	->beforeNormalization()
109	109	->ifString()
110		- ->then(function ($v) { return ['elements' => [$v]]; })
	110	+ ->then(function($v) { return ['elements' => [$v]]; })
111	111	->end()
112	112	->beforeNormalization()
113		- ->ifTrue(function ($v) { return \is_array($v) && \is_numeric(\key($v)); })
114		- ->then(function ($v) { return ['elements' => $v]; })
	113	+ ->ifTrue(function($v) { return \is_array($v) && \is_numeric(\key($v)); })
	114	+ ->then(function($v) { return ['elements' => $v]; })
115	115	->end()
116	116	->validate()
117		- ->ifTrue(function ($v) { return empty($v); })
	117	+ ->ifTrue(function($v) { return empty($v); })
118	118	->thenUnset()
119	119	->end()
120	120	->validate()
121		- ->always(function ($v) {
	121	+ ->always(function($v) {
122	122	$isExclusive = null;
123	123	if (isset($v['type'])) {
124	124	$isExclusive = 'exclusive' === $v['type'];

		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44	$configuration = new Configuration();
45	45	$config = $this->processConfiguration($configuration, $configs);
46	46
47		- $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
	47	+ $loader = new Loader\XmlFileLoader($container, new FileLocator(__DIR__ . '/../Resources/config'));
48	48	$loader->load('services.xml');
49	49
50	50	$container->setAlias(NewRelicInteractorInterface::class, $this->getInteractorServiceId($config))->setPublic(false);
		@@ -55,7 +55,7 @@ discard block
		block discarded – undo
55	55	->setDecoratedService(NewRelicInteractorInterface::class)
56	56	->setArguments(
57	57	[
58		- '$interactor' => new Reference(LoggingInteractorDecorator::class.'.inner'),
	58	+ '$interactor' => new Reference(LoggingInteractorDecorator::class . '.inner'),
59	59	'$logger' => new Reference('logger', ContainerInterface::NULL_ON_INVALID_REFERENCE),
60	60	]
61	61	)

		@@ -29,7 +29,7 @@ discard block
		block discarded – undo
29	29	$configuration = $container->getParameter('ekino.new_relic.monolog');
30	30	if ($container->hasDefinition('ekino.new_relic.logs_handler') && $container->hasParameter('ekino.new_relic.application_name')) {
31	31	$container->findDefinition('ekino.new_relic.logs_handler')
32		- ->setArgument('$level', \is_int($configuration['level']) ? $configuration['level'] : \constant('Monolog\Logger::'.\strtoupper($configuration['level'])))
	32	+ ->setArgument('$level', \is_int($configuration['level']) ? $configuration['level'] : \constant('Monolog\Logger::' . \strtoupper($configuration['level'])))
33	33	->setArgument('$bubble', true)
34	34	->setArgument('$appName', $container->getParameter('ekino.new_relic.application_name'));
35	35	}
		@@ -44,9 +44,9 @@ discard block
		block discarded – undo
44	44
45	45	foreach ($channels as $channel) {
46	46	try {
47		- $def = $container->getDefinition('app' === $channel ? 'monolog.logger' : 'monolog.logger.'.$channel);
	47	+ $def = $container->getDefinition('app' === $channel ? 'monolog.logger' : 'monolog.logger.' . $channel);
48	48	} catch (InvalidArgumentException $e) {
49		- $msg = 'NewRelicBundle configuration error: The logging channel "'.$channel.'" does not exist.';
	49	+ $msg = 'NewRelicBundle configuration error: The logging channel "' . $channel . '" does not exist.';
50	50	throw new \InvalidArgumentException($msg, 0, $e);
51	51	}
52	52	$def->addMethodCall('pushHandler', [new Reference('ekino.new_relic.logs_handler')]);

		@@ -52,7 +52,7 @@ discard block
		block discarded – undo
52	52	continue;
53	53	}
54	54
55		- $arguments = \array_map(function (\ReflectionParameter $parameter) {
	55	+ $arguments = \array_map(function(\ReflectionParameter $parameter) {
56	56	return $this->getTypeStub($parameter->getType());
57	57	}, $method->getParameters());
58	58
		@@ -82,11 +82,11 @@ discard block
		block discarded – undo
82	82	case 'Throwable':
83	83	return new \Exception();
84	84	case 'callable':
85		- return function () {};
	85	+ return function() {};
86	86	case 'array':
87	87	return \array_fill(0, 2, \uniqid('', true));
88	88	default:
89		- throw new \UnexpectedValueException('Unknown type. '.$type->getName());
	89	+ throw new \UnexpectedValueException('Unknown type. ' . $type->getName());
90	90	}
91	91	}
92	92	}

ekino / EkinoNewRelicBundle

Push — master ( be00cd...8a921f )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +13 added lines, -13 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch