Issues in CommandListenerTest.php - Fixed Issues - Inspection of "Merge pull request #158 from jderusse/fix-cs" - ekino/EkinoNewRelicBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6d867d...10a7e6 )

by Jérémy

created 2018-03-24 11:29 UTC

Tests/Listener/CommandListenerTest.php (1 issue)

Labels

Bug 1

Severity

Major 1

<?php

/*
 * This file is part of Ekino New Relic bundle.
 *
 * (c) Ekino - Thomas Rabaix <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Ekino\Bundle\NewRelicBundle\Tests\Listener;

use Ekino\Bundle\NewRelicBundle\Exception\ThrowableException;
filter:
    dependency_paths: ["lib/*"]
use Ekino\Bundle\NewRelicBundle\Listener\CommandListener;
use Ekino\Bundle\NewRelicBundle\NewRelic\NewRelic;
use Ekino\Bundle\NewRelicBundle\NewRelic\NewRelicInteractorInterface;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Event\ConsoleCommandEvent;
use Symfony\Component\Console\Event\ConsoleErrorEvent;
use Symfony\Component\Console\Input\ArrayInput;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputDefinition;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

class CommandListenerTest extends TestCase
{
    public function testCommandMarkedAsBackgroundJob()
    {
        if (!class_exists('Symfony\Component\Console\Event\ConsoleCommandEvent')) {
            $this->markTestSkipped('Console Events is only available from Symfony 2.3');
        }

        $parameters = array(
            '--foo' => true,
            '--foobar' => array('baz', 'baz_2'),
            'name' => 'bar',
        );

        $definition = new InputDefinition(array(
            new InputOption('foo'),
            new InputOption('foobar', 'fb', InputOption::VALUE_REQUIRED | InputOption::VALUE_IS_ARRAY),
            new InputArgument('name', InputArgument::REQUIRED),
         ));

        $interactor = $this->getMockBuilder(NewRelicInteractorInterface::class)->getMock();
        $interactor->expects($this->once())->method('setTransactionName')->with($this->equalTo('test:newrelic'));
        $interactor->expects($this->once())->method('enableBackgroundJob');

        $interactor->expects($this->at(3))->method('addCustomParameter')->with('--foo', true);
        $interactor->expects($this->at(4))->method('addCustomParameter')->with('--foobar[0]', 'baz');
        $interactor->expects($this->at(5))->method('addCustomParameter')->with('--foobar[1]', 'baz_2');
        $interactor->expects($this->at(6))->method('addCustomParameter')->with('name', 'bar');

        $command = new Command('test:newrelic');
        $input = new ArrayInput($parameters, $definition);

        $output = $this->getMockBuilder(OutputInterface::class)->getMock();

        $event = new ConsoleCommandEvent($command, $input, $output);

        $listener = new CommandListener(new NewRelic('App name', 'Token'), $interactor, array());
        $listener->onConsoleCommand($event);
    }

    public function testIgnoreBackgroundJob ()
    {
        $interactor = $this->getMockBuilder(NewRelicInteractorInterface::class)->getMock();
        $interactor->expects($this->never())->method('startTransaction');

        $command = new Command('test:ignored-commnand');
        $input = new ArrayInput(array(), new InputDefinition(array()));

        $output = $this->getMockBuilder(OutputInterface::class)->getMock();

        $event = new ConsoleCommandEvent($command, $input, $output);

        $listener = new CommandListener(new NewRelic('App name', 'Token'), $interactor, array('test:ignored-command'));
        $listener->onConsoleCommand($event);
    }

    public function testConsoleError()
    {
        $exception = new \Exception('', 1);

        $newrelic = $this->getMockBuilder(NewRelic::class)->disableOriginalConstructor()->getMock();
        $interactor = $this->getMockBuilder(NewRelicInteractorInterface::class)->getMock();
        $interactor->expects($this->once())->method('noticeThrowable')->with($exception);

        $command = new Command('test:exception');

        $input = new ArrayInput(array(), new InputDefinition(array()));
        $output = $this->getMockBuilder(OutputInterface::class)->getMock();


        $event = new ConsoleErrorEvent($input, $output, $exception, $command);

        $listener = new CommandListener($newrelic, $interactor, array('test:exception'));
        $listener->onConsoleError($event);
    }

    public function testConsoleErrorsWithThrowable()
    {
        $exception = new \Error();

        $newrelic = $this->getMockBuilder(NewRelic::class)->disableOriginalConstructor()->getMock();
        $interactor = $this->getMockBuilder(NewRelicInteractorInterface::class)->getMock();
        $interactor->expects($this->once())->method('noticeThrowable')->with($exception);
        $command = new Command('test:exception');

        $input = new ArrayInput(array(), new InputDefinition(array()));
        $output = $this->getMockBuilder(OutputInterface::class)->getMock();

        $event = new ConsoleErrorEvent($input, $output, $exception, $command);

        $listener = new CommandListener($newrelic, $interactor, array('test:exception'));
        $listener->onConsoleError($event);
    }
}


1			<?php
2
3			/*
4			* This file is part of Ekino New Relic bundle.
5			*
6			* (c) Ekino - Thomas Rabaix <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Ekino\Bundle\NewRelicBundle\Tests\Listener;
13
14			use Ekino\Bundle\NewRelicBundle\Exception\ThrowableException;
			0 ignored issues – show Bug introduced 2018-03-19 14:09 UTC by Report Bug Copy Issue Report Show Similar Issues like this The type `Ekino\Bundle\NewRelicBun...tion\ThrowableException` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
15			use Ekino\Bundle\NewRelicBundle\Listener\CommandListener;
16			use Ekino\Bundle\NewRelicBundle\NewRelic\NewRelic;
17			use Ekino\Bundle\NewRelicBundle\NewRelic\NewRelicInteractorInterface;
18			use PHPUnit\Framework\TestCase;
19			use Symfony\Component\Console\Command\Command;
20			use Symfony\Component\Console\Event\ConsoleCommandEvent;
21			use Symfony\Component\Console\Event\ConsoleErrorEvent;
22			use Symfony\Component\Console\Input\ArrayInput;
23			use Symfony\Component\Console\Input\InputArgument;
24			use Symfony\Component\Console\Input\InputDefinition;
25			use Symfony\Component\Console\Input\InputOption;
26			use Symfony\Component\Console\Output\OutputInterface;
27
28			class CommandListenerTest extends TestCase
29			{
30			public function testCommandMarkedAsBackgroundJob()
31			{
32			if (!class_exists('Symfony\Component\Console\Event\ConsoleCommandEvent')) {
33			$this->markTestSkipped('Console Events is only available from Symfony 2.3');
34			}
35
36			$parameters = array(
37			'--foo' => true,
38			'--foobar' => array('baz', 'baz_2'),
39			'name' => 'bar',
40			);
41
42			$definition = new InputDefinition(array(
43			new InputOption('foo'),
44			new InputOption('foobar', 'fb', InputOption::VALUE_REQUIRED \| InputOption::VALUE_IS_ARRAY),
45			new InputArgument('name', InputArgument::REQUIRED),
46			));
47
48			$interactor = $this->getMockBuilder(NewRelicInteractorInterface::class)->getMock();
49			$interactor->expects($this->once())->method('setTransactionName')->with($this->equalTo('test:newrelic'));
50			$interactor->expects($this->once())->method('enableBackgroundJob');
51
52			$interactor->expects($this->at(3))->method('addCustomParameter')->with('--foo', true);
53			$interactor->expects($this->at(4))->method('addCustomParameter')->with('--foobar[0]', 'baz');
54			$interactor->expects($this->at(5))->method('addCustomParameter')->with('--foobar[1]', 'baz_2');
55			$interactor->expects($this->at(6))->method('addCustomParameter')->with('name', 'bar');
56
57			$command = new Command('test:newrelic');
58			$input = new ArrayInput($parameters, $definition);
59
60			$output = $this->getMockBuilder(OutputInterface::class)->getMock();
61
62			$event = new ConsoleCommandEvent($command, $input, $output);
63
64			$listener = new CommandListener(new NewRelic('App name', 'Token'), $interactor, array());
65			$listener->onConsoleCommand($event);
66			}
67
68			public function testIgnoreBackgroundJob ()
69			{
70			$interactor = $this->getMockBuilder(NewRelicInteractorInterface::class)->getMock();
71			$interactor->expects($this->never())->method('startTransaction');
72
73			$command = new Command('test:ignored-commnand');
74			$input = new ArrayInput(array(), new InputDefinition(array()));
75
76			$output = $this->getMockBuilder(OutputInterface::class)->getMock();
77
78			$event = new ConsoleCommandEvent($command, $input, $output);
79
80			$listener = new CommandListener(new NewRelic('App name', 'Token'), $interactor, array('test:ignored-command'));
81			$listener->onConsoleCommand($event);
82			}
83
84			public function testConsoleError()
85			{
86			$exception = new \Exception('', 1);
87
88			$newrelic = $this->getMockBuilder(NewRelic::class)->disableOriginalConstructor()->getMock();
89			$interactor = $this->getMockBuilder(NewRelicInteractorInterface::class)->getMock();
90			$interactor->expects($this->once())->method('noticeThrowable')->with($exception);
91
92			$command = new Command('test:exception');
93
94			$input = new ArrayInput(array(), new InputDefinition(array()));
95			$output = $this->getMockBuilder(OutputInterface::class)->getMock();
96
97
98			$event = new ConsoleErrorEvent($input, $output, $exception, $command);
99
100			$listener = new CommandListener($newrelic, $interactor, array('test:exception'));
101			$listener->onConsoleError($event);
102			}
103
104			public function testConsoleErrorsWithThrowable()
105			{
106			$exception = new \Error();
107
108			$newrelic = $this->getMockBuilder(NewRelic::class)->disableOriginalConstructor()->getMock();
109			$interactor = $this->getMockBuilder(NewRelicInteractorInterface::class)->getMock();
110			$interactor->expects($this->once())->method('noticeThrowable')->with($exception);
111			$command = new Command('test:exception');
112
113			$input = new ArrayInput(array(), new InputDefinition(array()));
114			$output = $this->getMockBuilder(OutputInterface::class)->getMock();
115
116			$event = new ConsoleErrorEvent($input, $output, $exception, $command);
117
118			$listener = new CommandListener($newrelic, $interactor, array('test:exception'));
119			$listener->onConsoleError($event);
120			}
121			}
122

ekino / EkinoNewRelicBundle

Push — master ( 6d867d...10a7e6 )

Tests/Listener/CommandListenerTest.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like