Factory::buildFromResponse() - Code Metrics - Inspection of "Unnullableify Handler's $lastEvents" - ekinhbayar/gitamp - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#63)

by Paul

created 2020-11-30 17:05 UTC

Factory::buildFromResponse() A

↳ Parent: Factory

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	4
nc	1
nop	2
dl	0
loc	8
ccs	3
cts	3
cp	1
crap	1
rs	10
c	0
b	0
f	0

<?php declare(strict_types=1);

namespace ekinhbayar\GitAmp\Response;

use Amp\Promise;
use ekinhbayar\GitAmp\Event\Factory as EventFactory;
use Amp\Http\Client\Response;
use Psr\Log\LoggerInterface;
use function Amp\call;

class Factory
{
    private EventFactory $eventFactory;

    private LoggerInterface $logger;

    public function __construct(EventFactory $eventFactory, LoggerInterface $logger)
    {
        $this->eventFactory = $eventFactory;
        $this->logger       = $logger;
    }

    public function build(): Results
    {
        return new Results($this->eventFactory, $this->logger);
    }

    public function buildFromResponse(string $eventNamespace, Response $response): Promise
    {
        return call(function() use ($eventNamespace, $response) {
            $results = $this->build();

            yield $results->appendResponse($eventNamespace, $response);

            return $results;
        });
    }
}


1		<?php declare(strict_types=1);
2
3		namespace ekinhbayar\GitAmp\Response;
4
5		use Amp\Promise;
6		use ekinhbayar\GitAmp\Event\Factory as EventFactory;
7		use Amp\Http\Client\Response;
8		use Psr\Log\LoggerInterface;
9		use function Amp\call;
10
11		class Factory
12		{
13		private EventFactory $eventFactory;
14
15		private LoggerInterface $logger;
16
17	3	public function __construct(EventFactory $eventFactory, LoggerInterface $logger)
18		{
19	3	$this->eventFactory = $eventFactory;
20	3	$this->logger = $logger;
21		}
22
23	2	public function build(): Results
24		{
25	2	return new Results($this->eventFactory, $this->logger);
26	2	}
27
28	2	public function buildFromResponse(string $eventNamespace, Response $response): Promise
29		{
30	2	return call(function() use ($eventNamespace, $response) {
31	2	$results = $this->build();
32
33		yield $results->appendResponse($eventNamespace, $response);
34
35		return $results;
36		});
37		}
38		}
39

ekinhbayar / gitamp

Pull Request — master (#63)

Factory::buildFromResponse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like