Issues in server.php - All Issues - Inspection of "Moved origin builder to dedicated class" - ekinhbayar/gitamp - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 50dac6...4872ea )

by Pieter

created 2017-03-04 17:37 UTC

server.php (2 issues)

Labels

Documentation 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php declare(strict_types = 1);

use Aerys\Host;
use Auryn\Injector;
use ekinhbayar\GitAmp\Github\Credentials;
use ekinhbayar\GitAmp\Http\Origin;
use ekinhbayar\GitAmp\Log\Request as RequestLogger;
use ekinhbayar\GitAmp\Storage\Counter;
use ekinhbayar\GitAmp\Storage\NativeCounter;
use ekinhbayar\GitAmp\Websocket\Handler;
use Monolog\Logger;
use Monolog\Handler\StreamHandler;
use Psr\Log\LoggerInterface;
use function Aerys\root;
use function Aerys\router;
use function Aerys\websocket;

$configuration = require_once __DIR__ . '/config.php';

$injector = new Injector;

$injector->alias(Counter::class, NativeCounter::class);

$injector->alias(Credentials::class, get_class($configuration['github']));

$injector->share($configuration['github']);

$injector->alias(LoggerInterface::class, Logger::class);
$injector->share(Logger::class);

$injector->delegate(Logger::class, function() use ($configuration) {
    $logger = new Logger('gitamp');

    $logger->pushHandler(new StreamHandler('php://stdout', $configuration['logLevel']));

    return $logger;
});

$injector->define(Handler::class, [
    ':origin' => (new Origin($configuration))->get(),
]);

$injector->define(Client::class, [
    ':uri' => $configuration['redis']
]);

$websocket = $injector->make(Handler::class);

$router = router()->get('/ws', websocket($websocket));

$requestLogger = new RequestLogger();

if (isset($configuration['ssl'])) {
    (new Host())
        ->name($configuration['hostname'])
        ->expose($configuration['expose']['ip'], $configuration['expose']['port'])
        ->use($requestLogger)
        ->redirect('https://' . $configuration['hostname'])
    ;

    (new Host())
        ->name($configuration['hostname'])
        ->expose($configuration['ssl']['ip'], $configuration['ssl']['port'])
        ->encrypt($configuration['ssl']['certificate'], $configuration['ssl']['key'])
        ->use($requestLogger)
        ->use($router)
        ->use(root(__DIR__ . '/public'))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    ;
} else {
    (new Host())
        ->name($configuration['hostname'])
        ->expose($configuration['expose']['ip'], $configuration['expose']['port'])
        ->use($requestLogger)
        ->use($router)
        ->use(root(__DIR__ . '/public'))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    ;
}

$logger = $injector->make(LoggerInterface::class);

\Amp\onError(function(Throwable $e) use ($logger) {
    $logger->emergency('GitAmp blew up', ['exception' => $e]);
});


1			<?php declare(strict_types = 1);
2
3			use Aerys\Host;
4			use Auryn\Injector;
5			use ekinhbayar\GitAmp\Github\Credentials;
6			use ekinhbayar\GitAmp\Http\Origin;
7			use ekinhbayar\GitAmp\Log\Request as RequestLogger;
8			use ekinhbayar\GitAmp\Storage\Counter;
9			use ekinhbayar\GitAmp\Storage\NativeCounter;
10			use ekinhbayar\GitAmp\Websocket\Handler;
11			use Monolog\Logger;
12			use Monolog\Handler\StreamHandler;
13			use Psr\Log\LoggerInterface;
14			use function Aerys\root;
15			use function Aerys\router;
16			use function Aerys\websocket;
17
18			$configuration = require_once __DIR__ . '/config.php';
19
20			$injector = new Injector;
21
22			$injector->alias(Counter::class, NativeCounter::class);
23
24			$injector->alias(Credentials::class, get_class($configuration['github']));
25
26			$injector->share($configuration['github']);
27
28			$injector->alias(LoggerInterface::class, Logger::class);
29			$injector->share(Logger::class);
30
31			$injector->delegate(Logger::class, function() use ($configuration) {
32			$logger = new Logger('gitamp');
33
34			$logger->pushHandler(new StreamHandler('php://stdout', $configuration['logLevel']));
35
36			return $logger;
37			});
38
39			$injector->define(Handler::class, [
40			':origin' => (new Origin($configuration))->get(),
41			]);
42
43			$injector->define(Client::class, [
44			':uri' => $configuration['redis']
45			]);
46
47			$websocket = $injector->make(Handler::class);
48
49			$router = router()->get('/ws', websocket($websocket));
50
51			$requestLogger = new RequestLogger();
52
53			if (isset($configuration['ssl'])) {
54			(new Host())
55			->name($configuration['hostname'])
56			->expose($configuration['expose']['ip'], $configuration['expose']['port'])
57			->use($requestLogger)
58			->redirect('https://' . $configuration['hostname'])
59			;
60
61			(new Host())
62			->name($configuration['hostname'])
63			->expose($configuration['ssl']['ip'], $configuration['ssl']['port'])
64			->encrypt($configuration['ssl']['certificate'], $configuration['ssl']['key'])
65			->use($requestLogger)
66			->use($router)
67			->use(root(__DIR__ . '/public'))
			0 ignored issues – show Documentation introduced 2017-01-05 19:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this `\Aerys\root(__DIR__ . '/public')` is of type `object<Aerys\Bootable>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
68			;
69			} else {
70			(new Host())
71			->name($configuration['hostname'])
72			->expose($configuration['expose']['ip'], $configuration['expose']['port'])
73			->use($requestLogger)
74			->use($router)
75			->use(root(__DIR__ . '/public'))
			0 ignored issues – show Documentation introduced 2017-01-06 21:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this `\Aerys\root(__DIR__ . '/public')` is of type `object<Aerys\Bootable>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
76			;
77			}
78
79			$logger = $injector->make(LoggerInterface::class);
80
81			\Amp\onError(function(Throwable $e) use ($logger) {
82			$logger->emergency('GitAmp blew up', ['exception' => $e]);
83			});
84

ekinhbayar / gitamp

Push — master ( 50dac6...4872ea )

server.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like