PullRequestEvent::__construct() - Code Metrics - Inspection of "Removed cs fixer dep" - ekinhbayar/gitamp - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 657f5c...767802 )

by Ekin

created 2017-07-02 11:21 UTC

PullRequestEvent::__construct() A

↳ Parent: PullRequestEvent

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	10

Duplication

Lines	14
Ratio	100 %

Code Coverage

Tests	10
CRAP Score	1

Importance

Changes

Metric	Value
dl	14
loc	14
ccs	10
cts	10
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	1
crap	1

<?php declare(strict_types = 1);

namespace ekinhbayar\GitAmp\Event\GitHub;

use ekinhbayar\GitAmp\Event\BaseEvent;
use ekinhbayar\GitAmp\Presentation\Information;
use ekinhbayar\GitAmp\Presentation\Type;
use ekinhbayar\GitAmp\Presentation\Ring;
use ekinhbayar\GitAmp\Presentation\Sound\BaseSound;
use ekinhbayar\GitAmp\Presentation\Sound\Swell;
use ekinhbayar\GitAmp\Presentation\Sound\SwellEgg;

class PullRequestEvent extends BaseEvent
{
    public function __construct(array $event)

    {
        parent::__construct(
            (int) $event['id'],
            new Type(2),
            new Information(
                $event['payload']['pull_request']['html_url'],
                $event['payload']['pull_request']['title'],
                $this->buildMessage($event)
            ),
            new Ring(10000, 600),
            $this->buildSound($event)
        );
    }

    private function buildMessage(array $event): string

    {
        return \sprintf(
            '%s %s a PR for %s',
            $event['actor']['login'],
            $event['payload']['action'],
            $event['repo']['name']
        );
    }

    private function buildSound(array $event): BaseSound
    {
        if ($event['repo']['name'] === 'ekinhbayar/gitamp') {
            return new SwellEgg();
        }

        return new Swell();
    }
}


1			<?php declare(strict_types = 1);
2
3			namespace ekinhbayar\GitAmp\Event\GitHub;
4
5			use ekinhbayar\GitAmp\Event\BaseEvent;
6			use ekinhbayar\GitAmp\Presentation\Information;
7			use ekinhbayar\GitAmp\Presentation\Type;
8			use ekinhbayar\GitAmp\Presentation\Ring;
9			use ekinhbayar\GitAmp\Presentation\Sound\BaseSound;
10			use ekinhbayar\GitAmp\Presentation\Sound\Swell;
11			use ekinhbayar\GitAmp\Presentation\Sound\SwellEgg;
12
13			class PullRequestEvent extends BaseEvent
14			{
15	2	View Code Duplication	public function __construct(array $event)
			0 ignored issues – show Duplication introduced 2017-07-01 19:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
16			{
17	2		parent::__construct(
18	2		(int) $event['id'],
19	2		new Type(2),
20	2		new Information(
21	2		$event['payload']['pull_request']['html_url'],
22	2		$event['payload']['pull_request']['title'],
23	2		$this->buildMessage($event)
24			),
25	2		new Ring(10000, 600),
26	2		$this->buildSound($event)
27			);
28			}
29
30	2	View Code Duplication	private function buildMessage(array $event): string
			0 ignored issues – show Duplication introduced 2017-07-01 19:16 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
31			{
32	2		return \sprintf(
33	2		'%s %s a PR for %s',
34	2		$event['actor']['login'],
35	2		$event['payload']['action'],
36	2		$event['repo']['name']
37			);
38			}
39
40	2		private function buildSound(array $event): BaseSound
41			{
42	2		if ($event['repo']['name'] === 'ekinhbayar/gitamp') {
43	1		return new SwellEgg();
44			}
45
46	1		return new Swell();
47			}
48			}
49

ekinhbayar / gitamp

Push — master ( 657f5c...767802 )

PullRequestEvent::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like