ekinhbayar\GitAmp\Storage\RedisCounter

Complexity

Total Complexity

10

Size/Duplication

Total Lines	60
Duplicated Lines	45 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

0%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	increment()	9	9	2
A	decrement()	9	9	2
A	get()	0	11	3
A	set()	9	9	2

<?php declare(strict_types=1);

namespace ekinhbayar\GitAmp\Storage;

use Amp\Promise;
use Amp\Redis\Client;
use Amp\Redis\RedisException;
use function Amp\resolve;

class RedisCounter implements Counter {
    const SCRIPT_DECREMENT = <<<SCRIPT
local count = redis.call('decr', KEYS[1])

if count == 0 then
    redis.call('del', KEYS[1])
    return 0
else
    return count
end
SCRIPT;

    private $redis;

    public function __construct(Client $redis) {
        $this->redis = $redis;
    }

    public function increment(string $key): Promise {

This method seems to be duplicated in your project.

        return resolve(function () use ($key) {
            try {
                return yield $this->redis->incr($key);
            } catch (RedisException $e) {
                throw new StorageFailedException("Failed to increment counter.", 0, $e);

The string literal Failed to increment counter. does not require double quotes, as per coding-style, please use single quotes.

            }
        });
    }

    public function decrement(string $key): Promise {

This method seems to be duplicated in your project.

        return resolve(function () use ($key) {
            try {
                return yield $this->redis->eval(self::SCRIPT_DECREMENT, [$key], []);
            } catch (RedisException $e) {
                throw new StorageFailedException("Failed to decrement counter.", 0, $e);

The string literal Failed to decrement counter. does not require double quotes, as per coding-style, please use single quotes.

            }
        });
    }

    public function get(string $key): Promise {
        return resolve(function () use ($key) {
            try {
                $result = yield $this->redis->get($key);

                return empty($result) ? 0 : (int) $result;
            } catch (RedisException $e) {
                throw new StorageFailedException("Failed to get counter.", 0, $e);

The string literal Failed to get counter. does not require double quotes, as per coding-style, please use single quotes.

            }
        });
    }

    public function set(string $key, int $val): Promise {

This method seems to be duplicated in your project.

        return resolve(function () use ($key, $val) {
            try {
                return yield $this->redis->set($key, $val);
            } catch (RedisException $e) {
                throw new StorageFailedException("Failed to set counter value.", 0, $e);

The string literal Failed to set counter value. does not require double quotes, as per coding-style, please use single quotes.

            }
        });
    }
}