Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php declare(strict_types=1); |
||
13 | class WatchEvent extends BaseEvent |
||
14 | { |
||
15 | private const SPECIAL_REPOSITORIES = [ |
||
16 | 'ekinhbayar/gitamp', |
||
17 | 'amphp/amp', |
||
18 | ]; |
||
19 | |||
20 | 2 | public function __construct(array $event) |
|
21 | { |
||
22 | 2 | parent::__construct( |
|
23 | 2 | (int) $event['id'], |
|
24 | 2 | new Type(7), |
|
25 | 2 | new Information($this->buildUrl($event), $this->buildPayload(), $this->buildMessage($event)), |
|
26 | 2 | new Ring(3000, 80), |
|
27 | 2 | $this->buildSound($event), |
|
28 | ); |
||
|
|||
29 | } |
||
30 | |||
31 | 2 | private function buildUrl(array $event): string |
|
32 | { |
||
33 | 2 | return 'https://github.com/' . $event['repo']['name']; |
|
34 | } |
||
35 | |||
36 | 2 | private function buildPayload(): string |
|
37 | { |
||
38 | 2 | return 'not sure if stupid but works anyway'; |
|
39 | } |
||
40 | |||
41 | 2 | private function buildMessage(array $event): string |
|
42 | { |
||
43 | 2 | return \sprintf('%s watched %s', $event['actor']['login'], $event['repo']['name']); |
|
44 | } |
||
45 | |||
46 | 2 | private function buildSound(array $event): BaseSound |
|
47 | { |
||
48 | 2 | if (\in_array($event['repo']['name'], self::SPECIAL_REPOSITORIES, true)) { |
|
49 | 1 | return new SwellEgg(); |
|
50 | } |
||
55 |