Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php declare(strict_types=1); |
||
| 13 | class IssuesEvent extends BaseEvent |
||
| 14 | { |
||
| 15 | private const SPECIAL_REPOSITORIES = [ |
||
| 16 | 'ekinhbayar/gitamp', |
||
| 17 | 'amphp/amp', |
||
| 18 | ]; |
||
| 19 | |||
| 20 | 2 | public function __construct(array $event) |
|
| 21 | { |
||
| 22 | 2 | parent::__construct( |
|
| 23 | 2 | (int) $event['id'], |
|
| 24 | 2 | new Type(3), |
|
| 25 | 2 | new Information( |
|
| 26 | 2 | $event['payload']['issue']['html_url'], |
|
| 27 | 2 | $event['payload']['issue']['title'], |
|
| 28 | 2 | $this->buildMessage($event) |
|
| 29 | ), |
||
| 30 | 2 | new Ring(3000, 80), |
|
| 31 | 2 | $this->buildSound($event), |
|
| 32 | ); |
||
|
|
|||
| 33 | } |
||
| 34 | |||
| 35 | 2 | private function buildMessage(array $event): string |
|
| 36 | { |
||
| 37 | 2 | return \sprintf( |
|
| 38 | 2 | '%s %s an issue in %s', |
|
| 39 | 2 | $event['actor']['login'], |
|
| 40 | 2 | $event['payload']['action'], |
|
| 41 | 2 | $event['repo']['name'], |
|
| 42 | ); |
||
| 43 | } |
||
| 44 | |||
| 45 | 2 | private function buildSound(array $event): BaseSound |
|
| 46 | { |
||
| 47 | 2 | if (\in_array($event['repo']['name'], self::SPECIAL_REPOSITORIES, true)) { |
|
| 48 | 1 | return new ClavEgg(); |
|
| 49 | } |
||
| 54 |