cached

Complexity

Total Complexity

4

Size/Duplication

Total Lines	13
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__call__()	0	8	3
A	decorator()	0	6	2
A	__init__()	0	2	1

#!/usr/bin/env python

from __future__ import print_function
from flask import Flask, request, abort
from werkzeug.contrib.cache import SimpleCache
import logging
import sys
import json
import geoip2.database
from tabulate import tabulate

try:
    import psycopg2
    from psycopg2 import extras as pgextras
except ImportError:

The variable ImportError does not seem to be defined.

    print("psycopg2 needed to run server")
    sys.exit(1)

app = Flask(__name__)

The variable __name__ does not seem to be defined.

cache = SimpleCache()
logger = logging.getLogger(__name__)


CACHE_TIMEOUT = 300


class cached(object):

The variable object does not seem to be defined.

    def __init__(self, timeout=None):
        self.timeout = timeout or CACHE_TIMEOUT

The variable CACHE_TIMEOUT does not seem to be defined.

The variable timeout does not seem to be defined.

    def __call__(self, f):
        def decorator(*args, **kwargs):
            response = cache.get(request.path)

The variable request does not seem to be defined.

            if response is None:
                response = f(*args, **kwargs)

The variable args does not seem to be defined.

The variable kwargs does not seem to be defined.

                cache.set(request.path, response, self.timeout)
            return response
        return decorator

The variable decorator does not seem to be defined.

def dictToHstore(in_dict):
    single_kvs = []
    for key in in_dict.iterkeys():
        if in_dict[key]:
            single_kvs.append("{0}=>{1}".format(key, in_dict[key]))
    hstore_str = "'{0}'".format(", ".join(single_kvs))
    return hstore_str


@app.route("/rules", methods=["GET"])
@cached()
def get_rules():
    try:
        connv = psycopg2.connect("dbname=traceroutedb user=postgres host=localhost")
    except psycopg2.OperationalError as e:

The variable psycopg2 does not seem to be defined.

        logging.error(str(e))
        abort(503)
    cur = connv.cursor()
    cur.execute("SELECT * FROM endpoints;")
    rows = cur.fetchall()
    connv.close()
    return json.dumps(rows)


@app.route("/trace", methods=["POST"])
def receive_traces():
    config = app.config["trdb"]
    if config.get("mmdb", False):
        reader = config["mmdb"]

    if request.method == "POST":

The variable request does not seem to be defined.

        cur = conn.cursor()
        data = request.get_json(force=True)

        trace = data["data"]
        reporter = data["reporter"]
        kvs = {"note": data.get("note"), "ext_ip": data.get("ext_ip")}

        if config.debug:
            print("SELECT nextval('traceroute_id_seq');")
            trace_id = "DEBUG_ID"
        else:
            try:
                cur.execute("SELECT nextval('traceroute_id_seq');")
            except psycopg2.ProgrammingError as e:

The variable psycopg2 does not seem to be defined.

                logging.error(str(e))
                conn.rollback()
                abort(503)
            trace_id = cur.fetchone()[0]

        trace_sql = "INSERT INTO traceroute VALUES ({0}, '{1}', '{2}', now(), '{3}', {4}::HSTORE);".format(trace_id, trace["src_ip"], trace["dst_ip"], reporter, dictToHstore(kvs))
        if config.debug:
            print(trace_sql)
        else:
            try:
                cur.execute(trace_sql)
            except psycopg2.ProgrammingError as e:
                logging.error(str(e))
                conn.rollback()
                abort(503)

        hops = trace["hops"]
        for key in hops.keys():
            hop = hops[key]
            for probe in hop:
                if probe["ip"] is None or probe["rtt"] is None:
                    continue
                else:
                    try:
                        probe["isp"] = reader.isp(probe["ip"])
                    except:
                        pass

This except handler seems to be unused and could be removed.

                kvs = {}
                time = probe.get("rtt", None)
                if time is not None and time != "None":
                    kvs["time"] = time

                anno = probe.get("anno", None)
                if anno:
                    kvs["anno"] = anno

                try:
                    asn = probe.get("isp").raw.get("autonomous_system_number", None)
                    if asn:
                        kvs["asn"] = asn
                except:
                    pass

This except handler seems to be unused and could be removed.

                kvs = dictToHstore(kvs)
                if config.debug:
                    print("INSERT INTO hop VALUES (nextval('probe_id_seq'), {0}, {1}, {2}, '{3}', now());".format(trace_id, key, kvs, probe["ip"]))
                else:
                    try:
                        cur.execute("INSERT INTO hop VALUES (nextval('probe_id_seq'), {0}, {1}, {2}, '{3}', now());".format(trace_id, key, kvs, probe["ip"]))
                    except psycopg2.ProgrammingError as e:
                        logging.error(str(e))
                        conn.rollback()
                        abort(503)
    conn.commit()
    cur.close()
    conn.commit()
    print("ip:", request.remote_addr, "submitted result for:", trace["src_ip"], ">", trace["dst_ip"], "trace_id:", trace_id)

The variable trace does not seem to be defined in case request.method == "POST" on line 72 is False. Are you sure this can never be the case?

The variable trace_id does not seem to be defined in case request.method == "POST" on line 72 is False. Are you sure this can never be the case?

    return 'OK'


@app.route("/trace/<trace_id>", methods=["GET"])
def lookup_trace(trace_id):
    cur = conn.cursor(cursor_factory=pgextras.DictCursor)

The variable pgextras does not seem to be defined.

    pgextras.register_hstore(cur)
    cur.execute("SELECT * FROM trv_trace WHERE traceroute_id = {id} ORDER BY traceroute_id,hop_number;".format(id=trace_id))
    rows = cur.fetchall()
    if "table" in request.args:
        headers = ["reporter", "traceroute_id", "origin_ip", "dest_ip", "probe_id",
                   "hop_number", "host", "hop_kvs"]
        return tabulate(rows, headers, tablefmt="psql")
    else:
        out = [json.dumps(x) for x in rows]

The variable x does not seem to be defined.

        return "\n".join(out)


try:
    conn = psycopg2.connect("dbname=traceroutedb user=postgres host=localhost")
except psycopg2.OperationalError as e:

The variable psycopg2 does not seem to be defined.

    logging.error(str(e))
    sys.exit(1)


def run_server(config, app=app):

app is re-defining a name which is already available in the outer-scope (previously defined on line 19).

The variable app does not seem to be defined.

    if config.debug:
        logger.setLevel(logging.DEBUG)

The variable logging does not seem to be defined.

    app.config["trdb"] = config
    if config.mmdb:
        reader = geoip2.database.Reader(config.mmdb)
        app.config["trdb"]["mmdb"] = reader

    app.run(port=9001, debug=config.debug, host='::')