MessageIDValidation::isValid() - Code Metrics - Inspection of "MessageIDParser passing tests." - egulias/EmailValidator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — message-id-validator ( 1cb5b2...07464f )

by Eduardo Gulias

created 2021-02-21 21:46 UTC

MessageIDValidation::isValid() A

↳ Parent: MessageIDValidation

Complexity

Conditions	3
Paths	5

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3.1825

Importance

Changes

Metric	Value
dl	0
loc	18
ccs	8
cts	11
cp	0.7272
rs	9.6666
c	0
b	0
f	0
cc	3
nc	5
nop	2
crap	3.1825

<?php

namespace Egulias\EmailValidator\Validation;

use Egulias\EmailValidator\EmailLexer;
use Egulias\EmailValidator\MessageIDParser;
use Egulias\EmailValidator\Result\InvalidEmail;
use Egulias\EmailValidator\Result\Reason\ExceptionFound;

class MessageIDValidation implements EmailValidation
{
    public function isValid(string $email, EmailLexer $emailLexer): bool
    {
        $this->parser = new MessageIDParser($emailLexer);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        try {
            $result = $this->parser->parse($email);
            $this->warnings = $this->parser->getWarnings();
class MyClass { }

$x = new MyClass();
$x->foo = true;
            if ($result->isInvalid()) {
                /** @psalm-suppress PropertyTypeCoercion */
                $this->error = $result;
class MyClass { }

$x = new MyClass();
$x->foo = true;
                return false;
            }
        } catch (\Exception $invalid) {
            $this->error = new InvalidEmail(new ExceptionFound($invalid), '');
            return false;
        }

        return true;
    }

    public function getWarnings(): array
    {
        return [];
    }

    public function getError(): ?InvalidEmail
    {
        return null;
    }
}


1		<?php
2
3		namespace Egulias\EmailValidator\Validation;
4
5		use Egulias\EmailValidator\EmailLexer;
6		use Egulias\EmailValidator\MessageIDParser;
7		use Egulias\EmailValidator\Result\InvalidEmail;
8		use Egulias\EmailValidator\Result\Reason\ExceptionFound;
9
10		class MessageIDValidation implements EmailValidation
11		{
12	4	public function isValid(string $email, EmailLexer $emailLexer): bool
13		{
14	4	$this->parser = new MessageIDParser($emailLexer);
		0 ignored issues – show Bug introduced 2021-02-21 21:48 UTC by Report Bug Copy Issue Report The property `parser` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
15		try {
16	4	$result = $this->parser->parse($email);
17	4	$this->warnings = $this->parser->getWarnings();
		0 ignored issues – show Bug introduced 2021-02-21 21:48 UTC by Report Bug Copy Issue Report The property `warnings` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
18	4	if ($result->isInvalid()) {
19		/** @psalm-suppress PropertyTypeCoercion */
20	1	$this->error = $result;
		0 ignored issues – show Bug introduced 2021-02-21 21:48 UTC by Report Bug Copy Issue Report The property `error` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
21	4	return false;
22		}
23		} catch (\Exception $invalid) {
24		$this->error = new InvalidEmail(new ExceptionFound($invalid), '');
25		return false;
26		}
27
28	3	return true;
29		}
30
31		public function getWarnings(): array
32		{
33		return [];
34		}
35
36		public function getError(): ?InvalidEmail
37		{
38		return null;
39		}
40		}
41

egulias / EmailValidator

Push — message-id-validator ( 1cb5b2...07464f )

MessageIDValidation::isValid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like