DNSCheckValidationTest::testDNSWarnings() - Code Metrics - Inspection of "small code improvement" - egulias/EmailValidator - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — moving_tests_around (1c37ee)

by Eduardo Gulias

created 2016-05-14 23:02 UTC

DNSCheckValidationTest::testDNSWarnings() A

↳ Parent: DNSCheckValidationTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	7
rs	9.4285
cc	1
eloc	5
nc	1
nop	0

<?php

namespace Egulias\Tests\EmailValidator\Validation;

use Egulias\EmailValidator\EmailLexer;
use Egulias\EmailValidator\Exception\NoDNSRecord;
use Egulias\EmailValidator\Validation\DNSCheckValidation;
use Egulias\EmailValidator\Warning\NoDNSMXRecord;

class DNSCheckValidationTest extends \PHPUnit_Framework_TestCase
{
    public function testValidDNS()
    {
        $validation = new DNSCheckValidation();
        $this->assertTrue($validation->isValid("[email protected]", new EmailLexer()));
    }
    
    public function testInvalidDNS()
    {
        $validation = new DNSCheckValidation();
        $this->assertFalse($validation->isValid("[email protected]", new EmailLexer()));
    }
    
    public function testDNSWarnings()
    {
        $validation = new DNSCheckValidation();
        $expectedWarnings = [NoDNSMXRecord::CODE => new NoDNSMXRecord()];
        $validation->isValid("[email protected]", new EmailLexer());
        $this->assertEquals($expectedWarnings, $validation->getWarnings());
    }
    
    public function testNoDNSError()
    {
        $validation = new DNSCheckValidation();
        $expectedError = new NoDNSRecord();
        $validation->isValid("[email protected]", new EmailLexer());
        $this->assertEquals($expectedError, $validation->getError());
    }
}


1			<?php
2
3			namespace Egulias\Tests\EmailValidator\Validation;
4
5			use Egulias\EmailValidator\EmailLexer;
6			use Egulias\EmailValidator\Exception\NoDNSRecord;
7			use Egulias\EmailValidator\Validation\DNSCheckValidation;
8			use Egulias\EmailValidator\Warning\NoDNSMXRecord;
9
10			class DNSCheckValidationTest extends \PHPUnit_Framework_TestCase
11			{
12			public function testValidDNS()
13			{
14			$validation = new DNSCheckValidation();
15			$this->assertTrue($validation->isValid("[email protected]", new EmailLexer()));
16			}
17
18			public function testInvalidDNS()
19			{
20			$validation = new DNSCheckValidation();
21			$this->assertFalse($validation->isValid("[email protected]", new EmailLexer()));
22			}
23
24			public function testDNSWarnings()
25			{
26			$validation = new DNSCheckValidation();
27			$expectedWarnings = [NoDNSMXRecord::CODE => new NoDNSMXRecord()];
28			$validation->isValid("[email protected]", new EmailLexer());
29			$this->assertEquals($expectedWarnings, $validation->getWarnings());
30			}
31
32			public function testNoDNSError()
33			{
34			$validation = new DNSCheckValidation();
35			$expectedError = new NoDNSRecord();
36			$validation->isValid("[email protected]", new EmailLexer());
37			$this->assertEquals($expectedError, $validation->getError());
38			}
39			}
40

egulias / EmailValidator

Branch — moving_tests_around (1c37ee)

DNSCheckValidationTest::testDNSWarnings() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like