LocalComment::endOfLoopValidations() - Code Metrics - Inspection of "Parsing comments, at last!" - egulias/EmailValidator - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Push — 3.0.0-dev ( 61798f...c8e7f0 )

by Eduardo Gulias

created 2020-07-26 14:16 UTC

LocalComment::endOfLoopValidations() A

↳ Parent: LocalComment

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	3
Ratio	37.5 %

Importance

Changes

Metric	Value
dl	3
loc	8
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace Egulias\EmailValidator\Parser;

use Egulias\EmailValidator\EmailLexer;
use Egulias\EmailValidator\Result\Result;
use Egulias\EmailValidator\Result\ValidEmail;
use Egulias\EmailValidator\Warning\CFWSNearAt;
use Egulias\EmailValidator\Result\InvalidEmail;
use Egulias\EmailValidator\Result\Reason\ExpectingATEXT;

class LocalComment implements CommentStrategy
{
    private $warnings = [];

    public function exitCondition(EmailLexer $lexer, int $openedParenthesis) : bool
    {
        return !$lexer->isNextToken(EmailLexer::S_AT);
    }

    public function endOfLoopValidations(EmailLexer $lexer) : Result
    {
        if (!$lexer->isNextToken(EmailLexer::S_AT)) {

            return new InvalidEmail(new ExpectingATEXT('ATEX is not expected after closing comments'), $lexer->token['value']);
        }
        $this->warnings[CFWSNearAt::CODE] = new CFWSNearAt();
        return new ValidEmail();
    }

    public function getWarnings(): array
    {
        return $this->warnings;
    }
}

1		<?php
2
3		namespace Egulias\EmailValidator\Parser;
4
5		use Egulias\EmailValidator\EmailLexer;
6		use Egulias\EmailValidator\Result\Result;
7		use Egulias\EmailValidator\Result\ValidEmail;
8		use Egulias\EmailValidator\Warning\CFWSNearAt;
9		use Egulias\EmailValidator\Result\InvalidEmail;
10		use Egulias\EmailValidator\Result\Reason\ExpectingATEXT;
11
12		class LocalComment implements CommentStrategy
13		{
14		private $warnings = [];
15
16		public function exitCondition(EmailLexer $lexer, int $openedParenthesis) : bool
17		{
18		return !$lexer->isNextToken(EmailLexer::S_AT);
19		}
20
21		public function endOfLoopValidations(EmailLexer $lexer) : Result
22		{
23	View Code Duplication	if (!$lexer->isNextToken(EmailLexer::S_AT)) {
		0 ignored issues – show Duplication introduced 2020-07-26 14:18 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
24		return new InvalidEmail(new ExpectingATEXT('ATEX is not expected after closing comments'), $lexer->token['value']);
25		}
26		$this->warnings[CFWSNearAt::CODE] = new CFWSNearAt();
27		return new ValidEmail();
28		}
29
30		public function getWarnings(): array
31		{
32		return $this->warnings;
33		}
34		}

egulias / EmailValidator

Push — 3.0.0-dev ( 61798f...c8e7f0 )

LocalComment::endOfLoopValidations() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like