Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
16 | class FoldingWhiteSpace extends PartParser |
||
17 | { |
||
18 | 166 | public function parse() : Result |
|
19 | { |
||
20 | 166 | if (!$this->isFWS()) { |
|
21 | 165 | return new ValidEmail(); |
|
22 | } |
||
23 | |||
24 | 22 | $previous = $this->lexer->getPrevious(); |
|
25 | |||
26 | 22 | $resultCRLF = $this->checkCRLFInFWS(); |
|
27 | 22 | if ($resultCRLF->isInvalid()) { |
|
28 | 1 | return $resultCRLF; |
|
29 | } |
||
30 | |||
31 | 21 | if ($this->lexer->token['type'] === EmailLexer::S_CR) { |
|
32 | 3 | return new InvalidEmail(new CRNoLF(), $this->lexer->token['value']); |
|
33 | } |
||
34 | |||
35 | 18 | View Code Duplication | if ($this->lexer->isNextToken(EmailLexer::GENERIC) && $previous['type'] !== EmailLexer::S_AT) { |
|
|||
36 | 8 | return new InvalidEmail(new AtextAfterCFWS(), $this->lexer->token['value']); |
|
37 | } |
||
38 | |||
39 | 12 | View Code Duplication | if ($this->lexer->token['type'] === EmailLexer::S_LF || $this->lexer->token['type'] === EmailLexer::C_NUL) { |
40 | return new InvalidEmail(new ExpectingCTEXT(), $this->lexer->token['value']); |
||
41 | } |
||
42 | |||
43 | 12 | if ($this->lexer->isNextToken(EmailLexer::S_AT) || $previous['type'] === EmailLexer::S_AT) { |
|
44 | 3 | $this->warnings[CFWSNearAt::CODE] = new CFWSNearAt(); |
|
45 | } else { |
||
46 | 9 | $this->warnings[CFWSWithFWS::CODE] = new CFWSWithFWS(); |
|
47 | } |
||
48 | |||
49 | 12 | return new ValidEmail(); |
|
50 | } |
||
51 | |||
52 | 22 | protected function checkCRLFInFWS() : Result |
|
53 | { |
||
54 | 22 | if ($this->lexer->token['type'] !== EmailLexer::CRLF) { |
|
55 | 21 | return new ValidEmail(); |
|
56 | } |
||
57 | |||
58 | 1 | View Code Duplication | if (!$this->lexer->isNextTokenAny(array(EmailLexer::S_SP, EmailLexer::S_HTAB))) { |
59 | 1 | return new InvalidEmail(new CRLFX2(), $this->lexer->token['value']); |
|
60 | } |
||
61 | |||
62 | //this has no coverage. Condition is repeated from above one |
||
63 | View Code Duplication | if (!$this->lexer->isNextTokenAny(array(EmailLexer::S_SP, EmailLexer::S_HTAB))) { |
|
64 | return new InvalidEmail(new CRLFAtTheEnd(), $this->lexer->token['value']); |
||
65 | } |
||
66 | |||
67 | return new ValidEmail(); |
||
68 | } |
||
69 | |||
70 | 166 | protected function isFWS() : bool |
|
82 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.