egulias /
EmailValidator
| Conditions | 10 |
| Paths | 33 |
| Total Lines | 40 |
| Code Lines | 22 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 22 |
| CRAP Score | 10.0082 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 32 | 15 | public function parse(): Result |
|
| 33 | { |
||
| 34 | 15 | if ($this->lexer->current->isA(EmailLexer::S_OPENPARENTHESIS)) { |
|
|
Bug
introduced
by
|
|||
| 35 | 13 | $this->openedParenthesis++; |
|
| 36 | 13 | if ($this->noClosingParenthesis()) { |
|
| 37 | 5 | return new InvalidEmail(new UnclosedComment(), $this->lexer->current->value); |
|
| 38 | } |
||
| 39 | } |
||
| 40 | |||
| 41 | 10 | if ($this->lexer->current->isA(EmailLexer::S_CLOSEPARENTHESIS)) { |
|
| 42 | 2 | return new InvalidEmail(new UnOpenedComment(), $this->lexer->current->value); |
|
| 43 | } |
||
| 44 | |||
| 45 | 8 | $this->warnings[WarningComment::CODE] = new WarningComment(); |
|
| 46 | |||
| 47 | 8 | $moreTokens = true; |
|
| 48 | 8 | while ($this->commentStrategy->exitCondition($this->lexer, $this->openedParenthesis) && $moreTokens) { |
|
| 49 | |||
| 50 | 8 | if ($this->lexer->isNextToken(EmailLexer::S_OPENPARENTHESIS)) { |
|
| 51 | 1 | $this->openedParenthesis++; |
|
| 52 | } |
||
| 53 | 8 | $this->warnEscaping(); |
|
| 54 | 8 | if ($this->lexer->isNextToken(EmailLexer::S_CLOSEPARENTHESIS)) { |
|
| 55 | 8 | $this->openedParenthesis--; |
|
| 56 | } |
||
| 57 | 8 | $moreTokens = $this->lexer->moveNext(); |
|
| 58 | } |
||
| 59 | |||
| 60 | 8 | if ($this->openedParenthesis >= 1) { |
|
| 61 | return new InvalidEmail(new UnclosedComment(), $this->lexer->current->value); |
||
| 62 | } |
||
| 63 | 8 | if ($this->openedParenthesis < 0) { |
|
| 64 | 3 | return new InvalidEmail(new UnOpenedComment(), $this->lexer->current->value); |
|
| 65 | } |
||
| 66 | |||
| 67 | 5 | $finalValidations = $this->commentStrategy->endOfLoopValidations($this->lexer); |
|
| 68 | |||
| 69 | 5 | $this->warnings = array_merge($this->warnings, $this->commentStrategy->getWarnings()); |
|
| 70 | |||
| 71 | 5 | return $finalValidations; |
|
| 72 | } |
||
| 104 |
Loading history...