AbstractOrderedExtension - Code Metrics - egeloen/ivory-ordered-form - Measure and Improve Code Quality continuously with Scrutinizer

AbstractOrderedExtension A
last analyzed 2017-02-27 21:33 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	2
lcom	0
cbo	2
dl	0
loc	20
ccs	7
cts	7
cp	1
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	buildForm()	0	4	1
A	configureOptions()	0	6	1

<?php

/*
 * This file is part of the Ivory Ordered Form package.
 *
 * (c) Eric GELOEN <[email protected]>
 *
 * For the full copyright and license information, please read the LICENSE
 * file that was distributed with this source code.
 */

namespace Ivory\OrderedForm\Extension;

use Symfony\Component\Form\AbstractTypeExtension;
use Symfony\Component\Form\FormBuilderInterface;
use Symfony\Component\OptionsResolver\OptionsResolver;

/**
 * @author GeLo <[email protected]>
 */
abstract class AbstractOrderedExtension extends AbstractTypeExtension
{
    /**
     * {@inheritdoc}
     */
    public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder->setPosition($options['position']);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     * {@inheritdoc}
     */
    public function configureOptions(OptionsResolver $resolver)
    {
        $resolver
            ->setDefault('position', null)
            ->setAllowedTypes('position', ['null', 'string', 'array']);
    }
}


1		<?php
2
3		/*
4		* This file is part of the Ivory Ordered Form package.
5		*
6		* (c) Eric GELOEN <[email protected]>
7		*
8		* For the full copyright and license information, please read the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Ivory\OrderedForm\Extension;
13
14		use Symfony\Component\Form\AbstractTypeExtension;
15		use Symfony\Component\Form\FormBuilderInterface;
16		use Symfony\Component\OptionsResolver\OptionsResolver;
17
18		/**
19		* @author GeLo <[email protected]>
20		*/
21		abstract class AbstractOrderedExtension extends AbstractTypeExtension
22		{
23		/**
24		* {@inheritdoc}
25		*/
26	468	public function buildForm(FormBuilderInterface $builder, array $options)
27		{
28	468	$builder->setPosition($options['position']);
		0 ignored issues – show Bug introduced 2015-11-29 18:38 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Form\FormBuilderInterface` as the method `setPosition()` does only exist in the following implementations of said interface: `Ivory\OrderedForm\Builder\OrderedButtonBuilder`, `Ivory\OrderedForm\Builder\OrderedFormBuilder`, `Ivory\OrderedForm\Builde...eredSubmitButtonBuilder`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
29	468	}
30
31		/**
32		* {@inheritdoc}
33		*/
34	468	public function configureOptions(OptionsResolver $resolver)
35		{
36		$resolver
37	468	->setDefault('position', null)
38	468	->setAllowedTypes('position', ['null', 'string', 'array']);
39	468	}
40		}
41

egeloen / ivory-ordered-form

GitHub Access Token became invalid

AbstractOrderedExtension A last analyzed 2017-02-27 21:33 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like

AbstractOrderedExtension A
last analyzed 2017-02-27 21:33 UTC