These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
1 | <?php |
||
2 | |||
3 | /* |
||
4 | * This file is part of the Ivory Http Adapter package. |
||
5 | * |
||
6 | * (c) Eric GELOEN <[email protected]> |
||
7 | * |
||
8 | * For the full copyright and license information, please read the LICENSE |
||
9 | * file that was distributed with this source code. |
||
10 | */ |
||
11 | |||
12 | namespace Ivory\HttpAdapter\Event\Cookie\Jar; |
||
13 | |||
14 | use Ivory\HttpAdapter\Event\Cookie\CookieFactoryInterface; |
||
15 | |||
16 | /** |
||
17 | * @author GeLo <[email protected]> |
||
18 | */ |
||
19 | class SessionCookieJar extends AbstractPersistentCookieJar |
||
20 | { |
||
21 | /** |
||
22 | * @var string |
||
23 | */ |
||
24 | private $key; |
||
25 | |||
26 | /** |
||
27 | * @param string $key |
||
28 | * @param CookieFactoryInterface|null $cookieFactory |
||
29 | */ |
||
30 | 63 | public function __construct($key, CookieFactoryInterface $cookieFactory = null) |
|
31 | { |
||
32 | 63 | $this->setKey($key); |
|
33 | |||
34 | 63 | parent::__construct($cookieFactory); |
|
35 | 63 | } |
|
36 | |||
37 | /** |
||
38 | * @return string |
||
39 | */ |
||
40 | 18 | public function getKey() |
|
41 | { |
||
42 | 18 | return $this->key; |
|
43 | } |
||
44 | |||
45 | /** |
||
46 | * @param string $key |
||
47 | */ |
||
48 | 63 | public function setKey($key) |
|
49 | { |
||
50 | 63 | $this->key = $key; |
|
51 | 63 | } |
|
52 | |||
53 | /** |
||
54 | * {@inheritdoc} |
||
55 | */ |
||
56 | 63 | public function load() |
|
0 ignored issues
–
show
|
|||
57 | { |
||
58 | 63 | $this->unserialize(isset($_SESSION[$this->key]) ? $_SESSION[$this->key] : null); |
|
59 | 63 | } |
|
60 | |||
61 | /** |
||
62 | * {@inheritdoc} |
||
63 | */ |
||
64 | 36 | public function save() |
|
0 ignored issues
–
show
save uses the super-global variable $_SESSION which is generally not recommended.
Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad
class Router
{
public function generate($path)
{
return $_SERVER['HOST'].$path;
}
}
// Better
class Router
{
private $host;
public function __construct($host)
{
$this->host = $host;
}
public function generate($path)
{
return $this->host.$path;
}
}
class Controller
{
public function myAction(Request $request)
{
// Instead of
$page = isset($_GET['page']) ? intval($_GET['page']) : 1;
// Better (assuming you use the Symfony2 request)
$page = $request->query->get('page', 1);
}
}
Loading history...
|
|||
65 | { |
||
66 | 36 | $_SESSION[$this->key] = $this->serialize(); |
|
67 | 36 | } |
|
68 | } |
||
69 |
Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: