egeloen / ivory-http-adapter

src/Event/Subscriber/RetrySubscriber.php

<?php

/*
 * This file is part of the Ivory Http Adapter package.
 *
 * (c) Eric GELOEN <geloen.eric@gmail.com>
 *
 * For the full copyright and license information, please read the LICENSE
 * file that was distributed with this source code.
 */

namespace Ivory\HttpAdapter\Event\Subscriber;

use Ivory\HttpAdapter\Event\Events;
use Ivory\HttpAdapter\Event\RequestErroredEvent;
use Ivory\HttpAdapter\Event\MultiRequestErroredEvent;
use Ivory\HttpAdapter\Event\Retry\Retry;
use Ivory\HttpAdapter\Event\Retry\RetryInterface;
use Ivory\HttpAdapter\HttpAdapterException;
use Ivory\HttpAdapter\MultiHttpAdapterException;
use Symfony\Component\EventDispatcher\EventSubscriberInterface;

/**
 * Retry subscriber.
 *
 * @author GeLo <geloen.eric@gmail.com>
 */
class RetrySubscriber implements EventSubscriberInterface
{
    /** @var \Ivory\HttpAdapter\Event\Retry\RetryInterface */
    private $retry;

    /**
     * Creates a retry subscriber.
     *
     * @param \Ivory\HttpAdapter\Event\Retry\RetryInterface|null $retry The retry.
     */
    public function __construct(RetryInterface $retry = null)
    {
        $this->retry = $retry ?: new Retry();
    }

    /**
     * Gets the retry.
     *
     * @return \Ivory\HttpAdapter\Event\Retry\RetryInterface The retry.
     */
    public function getRetry()
    {
        return $this->retry;
    }

    /**
     * {@inheritdoc}
     */
    public function onRequestErrored(RequestErroredEvent $event)
    {
        if (($request = $this->retry->retry($event->getException()->getRequest())) === false) {

It seems like $event->getException()->getRequest() can be null; however, retry() does not accept null, maybe add an additional type check?

            return;
        }

        $event->getException()->setRequest($request);

It seems like $request defined by $this->retry->retry($event->getException()->getRequest()) on line 58 can also be of type boolean; however, Ivory\HttpAdapter\HttpAdapterException::setRequest() does only seem to accept null|object<Ivory\HttpAdapter\Message\InternalRequestInterface>, maybe add an additional type check?

        try {
            $event->setResponse($event->getHttpAdapter()->sendRequest($request));

It seems like $request defined by $this->retry->retry($event->getException()->getRequest()) on line 58 can also be of type boolean; however, Ivory\HttpAdapter\PsrHttpAdapterInterface::sendRequest() does only seem to accept object<Psr\Http\Message\RequestInterface>, maybe add an additional type check?

        } catch (HttpAdapterException $e) {
            $event->setException($e);
        }
    }

    /**
     * On multi request errored event.
     *
     * @param \Ivory\HttpAdapter\Event\MultiRequestErroredEvent $event The multi request errored event.
     */
    public function onMultiResponseErrored(MultiRequestErroredEvent $event)
    {
        $retryRequests = array();

        foreach ($event->getExceptions() as $exception) {
            if (($request = $this->retry->retry($exception->getRequest(), false)) !== false) {

It seems like $exception->getRequest() can be null; however, retry() does not accept null, maybe add an additional type check?

                $retryRequests[] = $request;
                $event->removeException($exception);
            }
        }

        if (empty($retryRequests)) {
            return;
        }

        try {
            $event->addResponses($event->getHttpAdapter()->sendRequests($retryRequests));
        } catch (MultiHttpAdapterException $e) {
            $event->addResponses($e->getResponses());
            $event->addExceptions($e->getExceptions());
        }
    }

    /**
     * {@inheritdoc}
     */
    public static function getSubscribedEvents()
    {
        return array(
            Events::REQUEST_ERRORED       => array('onRequestErrored', 0),
            Events::MULTI_REQUEST_ERRORED => array('onMultiResponseErrored', 0),
        );
    }
}