Issues in SessionCookieJar.php - All Issues - Inspection of "[Travis] Simplify matrix" - egeloen/ivory-http-adapter - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#129)

by Eric

created 2017-01-13 20:48 UTC

src/Event/Cookie/Jar/SessionCookieJar.php (2 issues)

Labels

Coding Style 2

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the Ivory Http Adapter package.
 *
 * (c) Eric GELOEN <[email protected]>
 *
 * For the full copyright and license information, please read the LICENSE
 * file that was distributed with this source code.
 */

namespace Ivory\HttpAdapter\Event\Cookie\Jar;

use Ivory\HttpAdapter\Event\Cookie\CookieFactoryInterface;

/**
 * Session cookie jar.
 *
 * @author GeLo <[email protected]>
 */
class SessionCookieJar extends AbstractPersistentCookieJar
{
    /** @var string */
    private $key;

    /**
     * Creates a session cookie jar.
     *
     * @param string                                                      $key           The key.
     * @param \Ivory\HttpAdapter\Event\Cookie\CookieFactoryInterface|null $cookieFactory The cookie factory.
     */
    public function __construct($key, CookieFactoryInterface $cookieFactory = null)
    {
        $this->setKey($key);

        parent::__construct($cookieFactory);
    }

    /**
     * Gets the key.
     *
     * @return string The key.
     */
    public function getKey()
    {
        return $this->key;
    }

    /**
     * Sets the key.
     *
     * @param string $key The key.
     */
    public function setKey($key)
    {
        $this->key = $key;
    }

    /**
     * {@inheritdoc}
     */
    public function load()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->unserialize(isset($_SESSION[$this->key]) ? $_SESSION[$this->key] : null);
    }

    /**
     * {@inheritdoc}
     */
    public function save()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $_SESSION[$this->key] = $this->serialize();
    }
}


1		<?php
2
3		/*
4		* This file is part of the Ivory Http Adapter package.
5		*
6		* (c) Eric GELOEN <[email protected]>
7		*
8		* For the full copyright and license information, please read the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Ivory\HttpAdapter\Event\Cookie\Jar;
13
14		use Ivory\HttpAdapter\Event\Cookie\CookieFactoryInterface;
15
16		/**
17		* Session cookie jar.
18		*
19		* @author GeLo <[email protected]>
20		*/
21		class SessionCookieJar extends AbstractPersistentCookieJar
22		{
23		/** @var string */
24		private $key;
25
26		/**
27		* Creates a session cookie jar.
28		*
29		* @param string $key The key.
30		* @param \Ivory\HttpAdapter\Event\Cookie\CookieFactoryInterface\|null $cookieFactory The cookie factory.
31		*/
32	133	public function __construct($key, CookieFactoryInterface $cookieFactory = null)
33		{
34	133	$this->setKey($key);
35
36	133	parent::__construct($cookieFactory);
37	133	}
38
39		/**
40		* Gets the key.
41		*
42		* @return string The key.
43		*/
44	38	public function getKey()
45		{
46	38	return $this->key;
47		}
48
49		/**
50		* Sets the key.
51		*
52		* @param string $key The key.
53		*/
54	133	public function setKey($key)
55		{
56	133	$this->key = $key;
57	133	}
58
59		/**
60		* {@inheritdoc}
61		*/
62	133	public function load()
		0 ignored issues – show Coding Style introduced 2017-01-12 20:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this `load` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
63		{
64	133	$this->unserialize(isset($_SESSION[$this->key]) ? $_SESSION[$this->key] : null);
65	133	}
66
67		/**
68		* {@inheritdoc}
69		*/
70	133	public function save()
		0 ignored issues – show Coding Style introduced 2017-01-12 20:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this `save` uses the super-global variable `$_SESSION` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
71		{
72	133	$_SESSION[$this->key] = $this->serialize();
73	133	}
74		}
75

egeloen / ivory-http-adapter

Pull Request — master (#129)

src/Event/Cookie/Jar/SessionCookieJar.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like