MessageFactory::getBaseUri() - Code Metrics - egeloen/ivory-http-adapter - Measure and Improve Code Quality continuously with Scrutinizer

MessageFactory::getBaseUri() A
last analyzed 2017-02-11 21:03 UTC

↳ Parent: MessageFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php

/*
 * This file is part of the Ivory Http Adapter package.
 *
 * (c) Eric GELOEN <[email protected]>
 *
 * For the full copyright and license information, please read the LICENSE
 * file that was distributed with this source code.
 */

namespace Ivory\HttpAdapter\Message;

use Ivory\HttpAdapter\Normalizer\HeadersNormalizer;
use Psr\Http\Message\StreamInterface;
use Zend\Diactoros\Stream;
use Zend\Diactoros\Uri;

/**
 * @author GeLo <[email protected]>
 */
class MessageFactory implements MessageFactoryInterface
{
    /**
     * @var Uri|null
     */
    private $baseUri;

    /**
     * @param string $baseUri
     */
    public function __construct($baseUri = null)
    {
        $this->setBaseUri($baseUri);
    }

    /**
     * {@inheritdoc}
     */
    public function hasBaseUri()
    {
        return $this->baseUri !== null;
    }

    /**
     * {@inheritdoc}
     */
    public function getBaseUri()
    {
        return $this->baseUri;
    }

    /**
     * {@inheritdoc}
     */
    public function setBaseUri($baseUri = null)
    {
        if (is_string($baseUri)) {
            $baseUri = new Uri($baseUri);
        }

        $this->baseUri = $baseUri;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * {@inheritdoc}
     */
    public function createRequest(
        $uri,
        $method = RequestInterface::METHOD_GET,
        $protocolVersion = RequestInterface::PROTOCOL_VERSION_1_1,
        array $headers = [],
        $body = null,
        array $parameters = []
    ) {
        return (new Request(
            $this->createUri($uri),

            $method,
            $this->createStream($body),

            HeadersNormalizer::normalize($headers),
            $parameters
        ))->withProtocolVersion($protocolVersion);
    }

    /**
     * {@inheritdoc}
     */
    public function createInternalRequest(
        $uri,
        $method = RequestInterface::METHOD_GET,
        $protocolVersion = RequestInterface::PROTOCOL_VERSION_1_1,
        array $headers = [],
        $datas = [],
        array $files = [],
        array $parameters = []
    ) {
        $body = null;

        if (!is_array($datas)) {
            $body = $this->createStream($datas);
            $datas = $files = [];
        }

        return (new InternalRequest(
            $this->createUri($uri),

            $method,
            $body !== null ? $body : 'php://memory',
            $datas,
            $files,
            HeadersNormalizer::normalize($headers),
            $parameters
        ))->withProtocolVersion($protocolVersion);
    }

    /**
     * {@inheritdoc}
     */
    public function createResponse(
        $statusCode = 200,
        $protocolVersion = RequestInterface::PROTOCOL_VERSION_1_1,
        array $headers = [],
        $body = null,
        array $parameters = []
    ) {
        return (new Response(
            $this->createStream($body),

            $statusCode,
            HeadersNormalizer::normalize($headers),
            $parameters
        ))->withProtocolVersion($protocolVersion);
    }

    /**
     * @param string $uri
     *
     * @return string
     */
    private function createUri($uri)
    {
        if ($this->hasBaseUri() && (stripos($uri, $baseUri = (string) $this->getBaseUri()) === false)) {
            return $baseUri.$uri;
        }

        return $uri;
    }

    /**
     * @param resource|string|StreamInterface|null $body
     *
     * @return StreamInterface
     */
    private function createStream($body)
    {
        if ($body instanceof StreamInterface) {
            $body->rewind();

            return $body;
        }

        if (is_resource($body)) {
            return $this->createStream(new Stream($body));
        }

        $stream = new Stream('php://memory', 'rw');

        if ($body === null) {
            return $stream;
        }

        $stream->write((string) $body);

        return $this->createStream($stream);
    }
}


1		<?php
2
3		/*
4		* This file is part of the Ivory Http Adapter package.
5		*
6		* (c) Eric GELOEN <[email protected]>
7		*
8		* For the full copyright and license information, please read the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Ivory\HttpAdapter\Message;
13
14		use Ivory\HttpAdapter\Normalizer\HeadersNormalizer;
15		use Psr\Http\Message\StreamInterface;
16		use Zend\Diactoros\Stream;
17		use Zend\Diactoros\Uri;
18
19		/**
20		* @author GeLo <[email protected]>
21		*/
22		class MessageFactory implements MessageFactoryInterface
23		{
24		/**
25		* @var Uri\|null
26		*/
27		private $baseUri;
28
29		/**
30		* @param string $baseUri
31		*/
32	16340	public function __construct($baseUri = null)
33		{
34	16340	$this->setBaseUri($baseUri);
35	16340	}
36
37		/**
38		* {@inheritdoc}
39		*/
40	15471	public function hasBaseUri()
41	4	{
42	15471	return $this->baseUri !== null;
43		}
44
45		/**
46		* {@inheritdoc}
47		*/
48	36	public function getBaseUri()
49		{
50	36	return $this->baseUri;
51		}
52
53		/**
54		* {@inheritdoc}
55		*/
56	16340	public function setBaseUri($baseUri = null)
57		{
58	16340	if (is_string($baseUri)) {
59	36	$baseUri = new Uri($baseUri);
60	28	}
61
62	16340	$this->baseUri = $baseUri;
		0 ignored issues – show Documentation Bug introduced 2017-01-27 13:23 UTC by Report Bug Copy Issue Report It seems like `$baseUri` can also be of type `object<Psr\Http\Message\UriInterface>`. However, the property `$baseUri` is declared as type `object<Zend\Diactoros\Uri>\|null`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
63	16340	}
64
65		/**
66		* {@inheritdoc}
67		*/
68	4236	public function createRequest(
69		$uri,
70		$method = RequestInterface::METHOD_GET,
71		$protocolVersion = RequestInterface::PROTOCOL_VERSION_1_1,
72		array $headers = [],
73		$body = null,
74		array $parameters = []
75		) {
76	4236	return (new Request(
77	4236	$this->createUri($uri),
		0 ignored issues – show Bug introduced 2016-05-06 16:33 UTC by Report Bug Copy Issue Report It seems like `$uri` defined by parameter `$uri` on line 69 can also be of type `object`; however, `Ivory\HttpAdapter\Messag...ageFactory::createUri()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
78	3264	$method,
79	4236	$this->createStream($body),
		0 ignored issues – show Bug introduced 2017-01-27 13:23 UTC by Report Bug Copy Issue Report It seems like `$body` defined by parameter `$body` on line 73 can also be of type `object<Guzzle\Stream\StreamInterface>`; however, `Ivory\HttpAdapter\Messag...Factory::createStream()` does only seem to accept `resource\|string\|object<P...e\StreamInterface>\|null`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
80	4236	HeadersNormalizer::normalize($headers),
81		$parameters
82	4236	))->withProtocolVersion($protocolVersion);
83		}
84
85		/**
86		* {@inheritdoc}
87		*/
88	15408	public function createInternalRequest(
89		$uri,
90		$method = RequestInterface::METHOD_GET,
91		$protocolVersion = RequestInterface::PROTOCOL_VERSION_1_1,
92		array $headers = [],
93		$datas = [],
94		array $files = [],
95		array $parameters = []
96		) {
97	15408	$body = null;
98
99	15408	if (!is_array($datas)) {
100	4227	$body = $this->createStream($datas);
101	4227	$datas = $files = [];
102	3257	}
103
104	15408	return (new InternalRequest(
105	15408	$this->createUri($uri),
		0 ignored issues – show Bug introduced 2016-05-06 16:33 UTC by Report Bug Copy Issue Report It seems like `$uri` defined by parameter `$uri` on line 89 can also be of type `object`; however, `Ivory\HttpAdapter\Messag...ageFactory::createUri()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
106	11872	$method,
107	15408	$body !== null ? $body : 'php://memory',
108	11872	$datas,
109	11872	$files,
110	15408	HeadersNormalizer::normalize($headers),
111		$parameters
112	15408	))->withProtocolVersion($protocolVersion);
113		}
114
115		/**
116		* {@inheritdoc}
117		*/
118	14841	public function createResponse(
119		$statusCode = 200,
120		$protocolVersion = RequestInterface::PROTOCOL_VERSION_1_1,
121		array $headers = [],
122		$body = null,
123		array $parameters = []
124		) {
125	14841	return (new Response(
126	14841	$this->createStream($body),
		0 ignored issues – show Bug introduced 2017-01-27 13:23 UTC by Report Bug Copy Issue Report It seems like `$body` defined by parameter `$body` on line 122 can also be of type `object<Guzzle\Stream\StreamInterface>`; however, `Ivory\HttpAdapter\Messag...Factory::createStream()` does only seem to accept `resource\|string\|object<P...e\StreamInterface>\|null`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
127	11435	$statusCode,
128	14841	HeadersNormalizer::normalize($headers),
129		$parameters
130	14841	))->withProtocolVersion($protocolVersion);
131		}
132
133		/**
134		* @param string $uri
135		*
136		* @return string
137		*/
138	15435	private function createUri($uri)
139		{
140	15435	if ($this->hasBaseUri() && (stripos($uri, $baseUri = (string) $this->getBaseUri()) === false)) {
141	18	return $baseUri.$uri;
142		}
143
144	15417	return $uri;
145		}
146
147		/**
148		* @param resource\|string\|StreamInterface\|null $body
149		*
150		* @return StreamInterface
151		*/
152	14886	private function createStream($body)
153		{
154	14886	if ($body instanceof StreamInterface) {
155	14259	$body->rewind();
156
157	14259	return $body;
158		}
159
160	14868	if (is_resource($body)) {
161	3426	return $this->createStream(new Stream($body));
162		}
163
164	12401	$stream = new Stream('php://memory', 'rw');
165
166	12401	if ($body === null) {
167	1227	return $stream;
168		}
169
170	11774	$stream->write((string) $body);
171
172	11774	return $this->createStream($stream);
173		}
174		}
175

egeloen / ivory-http-adapter

MessageFactory::getBaseUri() A last analyzed 2017-02-11 21:03 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

MessageFactory::getBaseUri() A
last analyzed 2017-02-11 21:03 UTC