Complex classes like DistanceMatrixRequest often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use DistanceMatrixRequest, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
21 | class DistanceMatrixRequest |
||
22 | { |
||
23 | /** |
||
24 | * @var Coordinate[]|string[] |
||
25 | */ |
||
26 | private $origins = []; |
||
27 | |||
28 | /** |
||
29 | * @var Coordinate[]|string[] |
||
30 | */ |
||
31 | private $destinations = []; |
||
32 | |||
33 | /** |
||
34 | * @var \DateTime|null |
||
35 | */ |
||
36 | private $departureTime; |
||
37 | |||
38 | /** |
||
39 | * @var \DateTime|null |
||
40 | */ |
||
41 | private $arrivalTime; |
||
42 | |||
43 | /** |
||
44 | * @var string|null |
||
45 | */ |
||
46 | private $travelMode; |
||
47 | |||
48 | /** |
||
49 | * @var string|null |
||
50 | */ |
||
51 | private $avoid; |
||
52 | |||
53 | /** |
||
54 | * @var string|null |
||
55 | */ |
||
56 | private $region; |
||
57 | |||
58 | /** |
||
59 | * @var string|null |
||
60 | */ |
||
61 | private $unitSystem; |
||
62 | |||
63 | /** |
||
64 | * @var string|null |
||
65 | */ |
||
66 | private $language; |
||
67 | |||
68 | /** |
||
69 | * @param Coordinate[]|string[] $origins |
||
70 | * @param Coordinate[]|string[] $destinations |
||
71 | */ |
||
72 | public function __construct(array $origins, array $destinations) |
||
77 | |||
78 | /** |
||
79 | * @return bool |
||
80 | */ |
||
81 | public function hasOrigins() |
||
85 | |||
86 | /** |
||
87 | * @return Coordinate[]|string[] |
||
88 | */ |
||
89 | public function getOrigins() |
||
93 | |||
94 | /** |
||
95 | * @param Coordinate[]|string[] $origins |
||
96 | */ |
||
97 | public function setOrigins(array $origins) |
||
102 | |||
103 | /** |
||
104 | * @param Coordinate[]|string[] $origins |
||
105 | */ |
||
106 | public function addOrigins(array $origins) |
||
112 | |||
113 | /** |
||
114 | * @param Coordinate|string $origin |
||
115 | * |
||
116 | * @return bool |
||
117 | */ |
||
118 | public function hasOrigin($origin) |
||
122 | |||
123 | /** |
||
124 | * @param Coordinate|string $origin |
||
125 | */ |
||
126 | public function addOrigin($origin) |
||
132 | |||
133 | /** |
||
134 | * @param Coordinate|string $origin |
||
135 | */ |
||
136 | public function removeOrigin($origin) |
||
141 | |||
142 | /** |
||
143 | * @return bool |
||
144 | */ |
||
145 | public function hasDestinations() |
||
149 | |||
150 | /** |
||
151 | * @return Coordinate[]|string[] |
||
152 | */ |
||
153 | public function getDestinations() |
||
157 | |||
158 | /** |
||
159 | * @param Coordinate[]|string[] $destinations |
||
160 | */ |
||
161 | public function setDestinations(array $destinations) |
||
166 | |||
167 | /** |
||
168 | * @param Coordinate[]|string[] $destinations |
||
169 | */ |
||
170 | public function addDestinations(array $destinations) |
||
176 | |||
177 | /** |
||
178 | * @param Coordinate|string $destination |
||
179 | * |
||
180 | * @return bool |
||
181 | */ |
||
182 | public function hasDestination($destination) |
||
186 | |||
187 | /** |
||
188 | * @param Coordinate|string $destination |
||
189 | */ |
||
190 | public function addDestination($destination) |
||
196 | |||
197 | /** |
||
198 | * @param Coordinate|string $destination |
||
199 | */ |
||
200 | public function removeDestination($destination) |
||
205 | |||
206 | /** |
||
207 | * @return bool |
||
208 | */ |
||
209 | public function hasDepartureTime() |
||
213 | |||
214 | /** |
||
215 | * @return \DateTime|null |
||
216 | */ |
||
217 | public function getDepartureTime() |
||
221 | |||
222 | /** |
||
223 | * @param \DateTime|null $departureTime |
||
224 | */ |
||
225 | public function setDepartureTime(\DateTime $departureTime = null) |
||
229 | |||
230 | /** |
||
231 | * @return bool |
||
232 | */ |
||
233 | public function hasArrivalTime() |
||
237 | |||
238 | /** |
||
239 | * @return \DateTime|null |
||
240 | */ |
||
241 | public function getArrivalTime() |
||
245 | |||
246 | /** |
||
247 | * @param \DateTime|null $arrivalTime |
||
248 | */ |
||
249 | public function setArrivalTime(\DateTime $arrivalTime = null) |
||
253 | |||
254 | /** |
||
255 | * @return bool |
||
256 | */ |
||
257 | public function hasTravelMode() |
||
261 | |||
262 | /** |
||
263 | * @return string|null |
||
264 | */ |
||
265 | public function getTravelMode() |
||
269 | |||
270 | /** |
||
271 | * @param string|null $travelMode |
||
272 | */ |
||
273 | public function setTravelMode($travelMode = null) |
||
277 | |||
278 | /** |
||
279 | * @return bool |
||
280 | */ |
||
281 | public function hasAvoid() |
||
285 | |||
286 | /** |
||
287 | * @return string|null |
||
288 | */ |
||
289 | public function getAvoid() |
||
293 | |||
294 | /** |
||
295 | * @param string|null $avoid |
||
296 | */ |
||
297 | public function setAvoid($avoid = null) |
||
301 | |||
302 | /** |
||
303 | * @return bool |
||
304 | */ |
||
305 | public function hasRegion() |
||
309 | |||
310 | /** |
||
311 | * @return string|null |
||
312 | */ |
||
313 | public function getRegion() |
||
317 | |||
318 | /** |
||
319 | * @param string|null $region |
||
320 | */ |
||
321 | public function setRegion($region = null) |
||
325 | |||
326 | /** |
||
327 | * @return bool |
||
328 | */ |
||
329 | public function hasUnitSystem() |
||
333 | |||
334 | /** |
||
335 | * @return string|null |
||
336 | */ |
||
337 | public function getUnitSystem() |
||
341 | |||
342 | /** |
||
343 | * @param string|null $unitSystem |
||
344 | */ |
||
345 | public function setUnitSystem($unitSystem = null) |
||
349 | |||
350 | /** |
||
351 | * @return bool |
||
352 | */ |
||
353 | public function hasLanguage() |
||
357 | |||
358 | /** |
||
359 | * @return string|null |
||
360 | */ |
||
361 | public function getLanguage() |
||
365 | |||
366 | /** |
||
367 | * @param string|null $language |
||
368 | */ |
||
369 | public function setLanguage($language = null) |
||
373 | |||
374 | /** |
||
375 | * @return mixed[] |
||
376 | */ |
||
377 | public function buildQuery() |
||
414 | |||
415 | /** |
||
416 | * @param Coordinate[]|string[] $places |
||
417 | * |
||
418 | * @return string[] |
||
419 | */ |
||
420 | private function buildPlaces(array $places) |
||
430 | |||
431 | /** |
||
432 | * @param Coordinate|string $place |
||
433 | * |
||
434 | * @return string |
||
435 | */ |
||
436 | private function buildPlace($place) |
||
444 | } |
||
445 |