Conditions | 1 |
Paths | 1 |
Total Lines | 64 |
Code Lines | 41 |
Lines | 0 |
Ratio | 0 % |
Changes | 2 | ||
Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
64 | protected function createSubscribers() |
||
65 | { |
||
66 | $formatter = $this->getFormatter(); |
||
67 | $jsonBuilder = $this->getJsonBuilder(); |
||
68 | |||
69 | // Base collectors |
||
70 | $boundCollector = new AutocompleteBoundCollector(); |
||
71 | $coordinateCollector = new AutocompleteCoordinateCollector($boundCollector); |
||
72 | |||
73 | // Event collectors |
||
74 | $domEventCollector = new AutocompleteDomEventCollector(); |
||
75 | $domEventOnceCollector = new AutocompleteDomEventOnceCollector(); |
||
76 | $eventCollector = new AutocompleteEventCollector(); |
||
77 | $eventOnceCollector = new AutocompleteEventOnceCollector(); |
||
78 | |||
79 | // Base renderers |
||
80 | $coordinateRenderer = new CoordinateRenderer($formatter); |
||
81 | $boundRenderer = new BoundRenderer($formatter); |
||
82 | |||
83 | // Event renderers |
||
84 | $domEventOnceRenderer = new DomEventOnceRenderer($formatter); |
||
85 | $domEventRenderer = new DomEventRenderer($formatter); |
||
86 | $eventOnceRenderer = new EventOnceRenderer($formatter); |
||
87 | $eventRenderer = new EventRenderer($formatter); |
||
88 | |||
89 | // Html renderers |
||
90 | $tagRenderer = new TagRenderer($formatter); |
||
91 | $autocompleteHtmlRenderer = new AutocompleteHtmlRenderer($formatter, $tagRenderer); |
||
92 | $javascriptTagRenderer = new JavascriptTagRenderer($formatter, $tagRenderer); |
||
93 | |||
94 | // Utility renderers |
||
95 | $callbackRenderer = new CallbackRenderer($formatter); |
||
96 | $requirementRenderer = new RequirementRenderer($formatter); |
||
97 | |||
98 | // Autocomplete renderers |
||
99 | $autocompleteContainerRenderer = new AutocompleteContainerRenderer($formatter, $jsonBuilder); |
||
100 | $autocompleteRenderer = new AutocompleteRenderer($formatter, $jsonBuilder, $requirementRenderer); |
||
101 | |||
102 | return array_merge([ |
||
103 | // Base |
||
104 | new AutocompleteBaseSubscriber($formatter), |
||
105 | new AutocompleteCoordinateSubscriber($formatter, $coordinateCollector, $coordinateRenderer), |
||
106 | new AutocompleteBoundSubscriber($formatter, $boundCollector, $boundRenderer), |
||
107 | |||
108 | // Event |
||
109 | new AutocompleteDomEventOnceSubscriber($formatter, $domEventOnceCollector, $domEventOnceRenderer), |
||
110 | new AutocompleteDomEventSubscriber($formatter, $domEventCollector, $domEventRenderer), |
||
111 | new AutocompleteEventOnceSubscriber($formatter, $eventOnceCollector, $eventOnceRenderer), |
||
112 | new AutocompleteEventSubscriber($formatter), |
||
113 | new AutocompleteSimpleEventSubscriber($formatter, $eventCollector, $eventRenderer), |
||
114 | |||
115 | // Autocomplete |
||
116 | new AutocompleteContainerSubscriber($formatter, $autocompleteContainerRenderer), |
||
117 | new AutocompleteHtmlSubscriber($formatter, $autocompleteHtmlRenderer), |
||
118 | new AutocompleteInitSubscriber($formatter), |
||
119 | new AutocompleteJavascriptSubscriber( |
||
120 | $formatter, |
||
121 | $autocompleteRenderer, |
||
122 | $callbackRenderer, |
||
123 | $javascriptTagRenderer |
||
124 | ), |
||
125 | new AutocompleteSubscriber($formatter, $autocompleteRenderer), |
||
126 | ], parent::createSubscribers()); |
||
127 | } |
||
128 | } |
||
129 |