Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
24 | View Code Duplication | class AutocompleteDomEventOnceSubscriber extends AbstractSubscriber |
|
|
|||
25 | { |
||
26 | /** |
||
27 | * @var AutocompleteDomEventOnceCollector |
||
28 | */ |
||
29 | private $domEventOnceCollector; |
||
30 | |||
31 | /** |
||
32 | * @var DomEventOnceRenderer |
||
33 | */ |
||
34 | private $domEventOnceRenderer; |
||
35 | |||
36 | /** |
||
37 | * @param Formatter $formatter |
||
38 | * @param AutocompleteDomEventOnceCollector $domEventOnceCollector |
||
39 | * @param DomEventOnceRenderer $domEventOnceRenderer |
||
40 | */ |
||
41 | public function __construct( |
||
51 | |||
52 | /** |
||
53 | * @return AutocompleteDomEventOnceCollector |
||
54 | */ |
||
55 | public function getDomEventOnceCollector() |
||
59 | |||
60 | /** |
||
61 | * @param AutocompleteDomEventOnceCollector $domEventOnceCollector |
||
62 | */ |
||
63 | public function setDomEventOnceCollector(AutocompleteDomEventOnceCollector $domEventOnceCollector) |
||
67 | |||
68 | /** |
||
69 | * @return DomEventOnceRenderer |
||
70 | */ |
||
71 | public function getDomEventOnceRenderer() |
||
75 | |||
76 | /** |
||
77 | * @param DomEventOnceRenderer $domEventOnceRenderer |
||
78 | */ |
||
79 | public function setDomEventOnceRenderer(DomEventOnceRenderer $domEventOnceRenderer) |
||
83 | |||
84 | /** |
||
85 | * @param PlaceAutocompleteEvent $event |
||
86 | */ |
||
87 | public function handleAutocomplete(PlaceAutocompleteEvent $event) |
||
101 | |||
102 | /** |
||
103 | * {@inheritdoc} |
||
104 | */ |
||
105 | public static function getSubscribedEvents() |
||
109 | } |
||
110 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.