PlaceSearchService::buildResult() - Code Metrics - Inspection of "[Service] Add Place support" - egeloen/ivory-google-map - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#177)

by Eric

created 2016-08-31 11:47 UTC

PlaceSearchService::buildResult() F

↳ Parent: PlaceSearchService

Complexity

Conditions	13
Paths	4096

Size

Total Lines	56
Code Lines	29

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	56
rs	3.3579
cc	13
eloc	29
nc	4096
nop	1

How to fix Long Method Complexity

<?php

/*
 * This file is part of the Ivory Google Map package.
 *
 * (c) Eric GELOEN <[email protected]>
 *
 * For the full copyright and license information, please read the LICENSE
 * file that was distributed with this source code.
 */

namespace Ivory\GoogleMap\Service\Place\Search;

use Ivory\GoogleMap\Base\Coordinate;
use Ivory\GoogleMap\Service\Base\Geometry;
use Ivory\GoogleMap\Service\Place\AbstractPlaceParsableService;
use Ivory\GoogleMap\Service\Place\Base\AlternatePlaceId;
use Ivory\GoogleMap\Service\Place\Base\OpeningHours;
use Ivory\GoogleMap\Service\Place\Base\Photo;
use Ivory\GoogleMap\Service\Place\Base\Place;
use Ivory\GoogleMap\Service\Place\Search\Request\PlaceSearchRequestInterface;
use Ivory\GoogleMap\Service\Place\Search\Response\PlaceSearchResponse;
use Ivory\GoogleMap\Service\Place\Search\Response\PlaceSearchResponseIterator;

/**
 * @author GeLo <[email protected]>
 */
class PlaceSearchService extends AbstractPlaceParsableService
{
    /**
     * {@inheritdoc}
     */
    public function setHttps($https)
    {
        if (!$https) {
            throw new \InvalidArgumentException('The http scheme is not supported.');
        }

        parent::setHttps($https);
    }

    /**
     * @param PlaceSearchRequestInterface $request
     *
     * @return PlaceSearchResponseIterator
     */
    public function process(PlaceSearchRequestInterface $request)

    {
        $httpRequest = $this->createRequest($request);
        $httpResponse = $this->getClient()->sendRequest($httpRequest);

        $data = $this->parse((string) $httpResponse->getBody(), [
            'pluralization_rules' => [
                'html_attribution' => 'html_attributions',
                'photo'            => 'photos',
                'result'           => 'results',
                'type'             => 'types',
            ],
        ]);

        $response = $this->buildResponse($data);
        $response->setRequest($request);

        return new PlaceSearchResponseIterator($this, $response);
    }

    /**
     * @param mixed[] $data
     *
     * @return PlaceSearchResponse
     */
    private function buildResponse(array $data)

    {
        $response = new PlaceSearchResponse();
        $response->setStatus($data['status']);
        $response->setResults($this->buildResults($data['results']));

        if (isset($data['html_attributions'])) {
            $response->setHtmlAttributions($data['html_attributions']);
        }

        if (isset($data['next_page_token'])) {
            $response->setNextPageToken($data['next_page_token']);
        }

        return $response;
    }

    /**
     * @param mixed[] $data
     *
     * @return Place[]
     */
    private function buildResults(array $data)
    {
        $results = [];

        foreach ($data as $result) {
            $results[] = $this->buildResult($result);
        }

        return $results;
    }

    /**
     * @param mixed[] $data
     *
     * @return Place
     */
    private function buildResult(array $data)
    {
        $result = new Place();
        $result->setPlaceId($data['place_id']);
        $result->setGeometry($this->buildGeometry($data['geometry']));

        if (isset($data['name'])) {
            $result->setName($data['name']);
        }

        if (isset($data['formatted_address'])) {
            $result->setFormattedAddress($data['formatted_address']);
        }

        if (isset($data['icon'])) {
            $result->setIcon($data['icon']);
        }

        if (isset($data['scope'])) {
            $result->setScope($data['scope']);
        }

        if (isset($data['price_level'])) {
            $result->setPriceLevel($data['price_level']);
        }

        if (isset($data['rating'])) {
            $result->setRating($data['rating']);
        }

        if (isset($data['vicinity'])) {
            $result->setVicinity($data['vicinity']);
        }

        if (isset($data['permanently_closed'])) {
            $result->setPermanentlyClose($data['permanently_closed']);
        }

        if (isset($data['types'])) {
            $result->setTypes($data['types']);
        }

        if (isset($data['photos'])) {
            $result->setPhotos($this->buildPhotos($data['photos']));
        }

        if (isset($data['alt_ids'])) {
            $result->setAlternatePlaceIds($this->buildAlternativePlaceIds($data['alt_ids']));
        }

        if (isset($data['opening_hours'])) {
            $result->setOpeningHours($this->buildOpeningHours($data['opening_hours']));
        }

        return $result;
    }

    /**
     * @param mixed[] $data
     *
     * @return Photo[]
     */
    private function buildPhotos(array $data)
    {
        $photos = [];

        foreach ($data as $photo) {
            $photos[] = $this->buildPhoto($photo);
        }

        return $photos;
    }

    /**
     * @param mixed[] $data
     *
     * @return Photo
     */
    private function buildPhoto(array $data)

    {
        $photo = new Photo();
        $photo->setReference($data['photo_reference']);
        $photo->setWidth($data['width']);
        $photo->setHeight($data['height']);
        $photo->setHtmlAttributions($data['html_attributions']);

        return $photo;
    }

    /**
     * @param mixed[] $data
     *
     * @return AlternatePlaceId[]
     */
    private function buildAlternativePlaceIds(array $data)
    {
        $alternativePlaceIds = [];

        foreach ($data as $alternativePlaceId) {
            $alternativePlaceIds[] = $this->buildAlternativePlaceId($alternativePlaceId);
        }

        return $alternativePlaceIds;
    }

    /**
     * @param mixed[] $data
     *
     * @return AlternatePlaceId
     */
    private function buildAlternativePlaceId(array $data)

    {
        $alternativePlaceId = new AlternatePlaceId();
        $alternativePlaceId->setPlaceId($data['place_id']);
        $alternativePlaceId->setScope($data['scope']);

        return $alternativePlaceId;
    }

    /**
     * @param mixed[] $data
     *
     * @return Geometry
     */
    private function buildGeometry(array $data)
    {
        $geometry = new Geometry();
        $geometry->setLocation($this->buildCoordinate($data['location']));

        return $geometry;
    }

    /**
     * @param array $data
     *
     * @return OpeningHours
     */
    private function buildOpeningHours(array $data)
    {
        $openingHours = new OpeningHours();
        $openingHours->setOpenNow($data['open_now']);

        return $openingHours;
    }

    /**
     * @param mixed[] $data
     *
     * @return Coordinate
     */
    private function buildCoordinate(array $data)
    {
        return new Coordinate($data['lat'], $data['lng']);
    }
}


1		<?php
2
3		/*
4		* This file is part of the Ivory Google Map package.
5		*
6		* (c) Eric GELOEN <[email protected]>
7		*
8		* For the full copyright and license information, please read the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Ivory\GoogleMap\Service\Place\Search;
13
14		use Ivory\GoogleMap\Base\Coordinate;
15		use Ivory\GoogleMap\Service\Base\Geometry;
16		use Ivory\GoogleMap\Service\Place\AbstractPlaceParsableService;
17		use Ivory\GoogleMap\Service\Place\Base\AlternatePlaceId;
18		use Ivory\GoogleMap\Service\Place\Base\OpeningHours;
19		use Ivory\GoogleMap\Service\Place\Base\Photo;
20		use Ivory\GoogleMap\Service\Place\Base\Place;
21		use Ivory\GoogleMap\Service\Place\Search\Request\PlaceSearchRequestInterface;
22		use Ivory\GoogleMap\Service\Place\Search\Response\PlaceSearchResponse;
23		use Ivory\GoogleMap\Service\Place\Search\Response\PlaceSearchResponseIterator;
24
25		/**
26		* @author GeLo <[email protected]>
27		*/
28		class PlaceSearchService extends AbstractPlaceParsableService
29		{
30		/**
31		* {@inheritdoc}
32		*/
33		public function setHttps($https)
34		{
35		if (!$https) {
36		throw new \InvalidArgumentException('The http scheme is not supported.');
37		}
38
39		parent::setHttps($https);
40		}
41
42		/**
43		* @param PlaceSearchRequestInterface $request
44		*
45		* @return PlaceSearchResponseIterator
46		*/
47	View Code Duplication	public function process(PlaceSearchRequestInterface $request)
		0 ignored issues – show Duplication introduced 2016-08-27 19:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
48		{
49		$httpRequest = $this->createRequest($request);
50		$httpResponse = $this->getClient()->sendRequest($httpRequest);
51
52		$data = $this->parse((string) $httpResponse->getBody(), [
53		'pluralization_rules' => [
54		'html_attribution' => 'html_attributions',
55		'photo' => 'photos',
56		'result' => 'results',
57		'type' => 'types',
58		],
59		]);
60
61		$response = $this->buildResponse($data);
62		$response->setRequest($request);
63
64		return new PlaceSearchResponseIterator($this, $response);
65		}
66
67		/**
68		* @param mixed[] $data
69		*
70		* @return PlaceSearchResponse
71		*/
72	View Code Duplication	private function buildResponse(array $data)
		0 ignored issues – show Duplication introduced 2016-08-27 19:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
73		{
74		$response = new PlaceSearchResponse();
75		$response->setStatus($data['status']);
76		$response->setResults($this->buildResults($data['results']));
77
78		if (isset($data['html_attributions'])) {
79		$response->setHtmlAttributions($data['html_attributions']);
80		}
81
82		if (isset($data['next_page_token'])) {
83		$response->setNextPageToken($data['next_page_token']);
84		}
85
86		return $response;
87		}
88
89		/**
90		* @param mixed[] $data
91		*
92		* @return Place[]
93		*/
94		private function buildResults(array $data)
95		{
96		$results = [];
97
98		foreach ($data as $result) {
99		$results[] = $this->buildResult($result);
100		}
101
102		return $results;
103		}
104
105		/**
106		* @param mixed[] $data
107		*
108		* @return Place
109		*/
110		private function buildResult(array $data)
111		{
112		$result = new Place();
113		$result->setPlaceId($data['place_id']);
114		$result->setGeometry($this->buildGeometry($data['geometry']));
115
116		if (isset($data['name'])) {
117		$result->setName($data['name']);
118		}
119
120		if (isset($data['formatted_address'])) {
121		$result->setFormattedAddress($data['formatted_address']);
122		}
123
124		if (isset($data['icon'])) {
125		$result->setIcon($data['icon']);
126		}
127
128		if (isset($data['scope'])) {
129		$result->setScope($data['scope']);
130		}
131
132		if (isset($data['price_level'])) {
133		$result->setPriceLevel($data['price_level']);
134		}
135
136		if (isset($data['rating'])) {
137		$result->setRating($data['rating']);
138		}
139
140		if (isset($data['vicinity'])) {
141		$result->setVicinity($data['vicinity']);
142		}
143
144		if (isset($data['permanently_closed'])) {
145		$result->setPermanentlyClose($data['permanently_closed']);
146		}
147
148		if (isset($data['types'])) {
149		$result->setTypes($data['types']);
150		}
151
152		if (isset($data['photos'])) {
153		$result->setPhotos($this->buildPhotos($data['photos']));
154		}
155
156		if (isset($data['alt_ids'])) {
157		$result->setAlternatePlaceIds($this->buildAlternativePlaceIds($data['alt_ids']));
158		}
159
160		if (isset($data['opening_hours'])) {
161		$result->setOpeningHours($this->buildOpeningHours($data['opening_hours']));
162		}
163
164		return $result;
165		}
166
167		/**
168		* @param mixed[] $data
169		*
170		* @return Photo[]
171		*/
172		private function buildPhotos(array $data)
173		{
174		$photos = [];
175
176		foreach ($data as $photo) {
177		$photos[] = $this->buildPhoto($photo);
178		}
179
180		return $photos;
181		}
182
183		/**
184		* @param mixed[] $data
185		*
186		* @return Photo
187		*/
188	View Code Duplication	private function buildPhoto(array $data)
		0 ignored issues – show Duplication introduced 2016-08-27 19:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
189		{
190		$photo = new Photo();
191		$photo->setReference($data['photo_reference']);
192		$photo->setWidth($data['width']);
193		$photo->setHeight($data['height']);
194		$photo->setHtmlAttributions($data['html_attributions']);
195
196		return $photo;
197		}
198
199		/**
200		* @param mixed[] $data
201		*
202		* @return AlternatePlaceId[]
203		*/
204		private function buildAlternativePlaceIds(array $data)
205		{
206		$alternativePlaceIds = [];
207
208		foreach ($data as $alternativePlaceId) {
209		$alternativePlaceIds[] = $this->buildAlternativePlaceId($alternativePlaceId);
210		}
211
212		return $alternativePlaceIds;
213		}
214
215		/**
216		* @param mixed[] $data
217		*
218		* @return AlternatePlaceId
219		*/
220	View Code Duplication	private function buildAlternativePlaceId(array $data)
		0 ignored issues – show Duplication introduced 2016-08-27 19:42 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
221		{
222		$alternativePlaceId = new AlternatePlaceId();
223		$alternativePlaceId->setPlaceId($data['place_id']);
224		$alternativePlaceId->setScope($data['scope']);
225
226		return $alternativePlaceId;
227		}
228
229		/**
230		* @param mixed[] $data
231		*
232		* @return Geometry
233		*/
234		private function buildGeometry(array $data)
235		{
236		$geometry = new Geometry();
237		$geometry->setLocation($this->buildCoordinate($data['location']));
238
239		return $geometry;
240		}
241
242		/**
243		* @param array $data
244		*
245		* @return OpeningHours
246		*/
247		private function buildOpeningHours(array $data)
248		{
249		$openingHours = new OpeningHours();
250		$openingHours->setOpenNow($data['open_now']);
251
252		return $openingHours;
253		}
254
255		/**
256		* @param mixed[] $data
257		*
258		* @return Coordinate
259		*/
260		private function buildCoordinate(array $data)
261		{
262		return new Coordinate($data['lat'], $data['lng']);
263		}
264		}
265

egeloen / ivory-google-map

GitHub Access Token became invalid

Pull Request — master (#177)

PlaceSearchService::buildResult() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like