MarkerShapeCollector - Code Metrics - Inspection of "[Overlay] Add Symbol support" - egeloen/ivory-google-map - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — symbol ( 74f22f )

by Eric

created 2017-02-16 22:39 UTC

MarkerShapeCollector A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	48
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	3
dl	48
loc	48
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	4	4	1
A	getMarkerCollector()	4	4	1
A	setMarkerCollector()	4	4	1
A	collect()	10	10	3

How to fix Duplicated Code

<?php

/*
 * This file is part of the Ivory Google Map package.
 *
 * (c) Eric GELOEN <[email protected]>
 *
 * For the full copyright and license information, please read the LICENSE
 * file that was distributed with this source code.
 */

namespace Ivory\GoogleMap\Helper\Collector\Overlay;

use Ivory\GoogleMap\Helper\Collector\AbstractCollector;
use Ivory\GoogleMap\Map;
use Ivory\GoogleMap\Overlay\MarkerShape;

/**
 * @author GeLo <[email protected]>
 */
class MarkerShapeCollector extends AbstractCollector

{
    /**
     * @var MarkerCollector
     */
    private $markerCollector;

    /**
     * @param MarkerCollector $markerCollector
     */
    public function __construct(MarkerCollector $markerCollector)
    {
        $this->setMarkerCollector($markerCollector);
    }

    /**
     * @return MarkerCollector
     */
    public function getMarkerCollector()
    {
        return $this->markerCollector;
    }

    /**
     * @param MarkerCollector $markerCollector
     */
    public function setMarkerCollector(MarkerCollector $markerCollector)
    {
        $this->markerCollector = $markerCollector;
    }

    /**
     * @param Map           $map
     * @param MarkerShape[] $markerShapes
     *
     * @return MarkerShape[]
     */
    public function collect(Map $map, array $markerShapes = [])
    {
        foreach ($this->markerCollector->collect($map) as $marker) {
            if ($marker->hasShape()) {
                $markerShapes = $this->collectValue($marker->getShape(), $markerShapes);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
            }
        }

        return $markerShapes;
    }
}


1		<?php
2
3		/*
4		* This file is part of the Ivory Google Map package.
5		*
6		* (c) Eric GELOEN <[email protected]>
7		*
8		* For the full copyright and license information, please read the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Ivory\GoogleMap\Helper\Collector\Overlay;
13
14		use Ivory\GoogleMap\Helper\Collector\AbstractCollector;
15		use Ivory\GoogleMap\Map;
16		use Ivory\GoogleMap\Overlay\MarkerShape;
17
18		/**
19		* @author GeLo <[email protected]>
20		*/
21	View Code Duplication	class MarkerShapeCollector extends AbstractCollector
		0 ignored issues – show Duplication introduced 2017-02-16 23:04 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		{
23		/**
24		* @var MarkerCollector
25		*/
26		private $markerCollector;
27
28		/**
29		* @param MarkerCollector $markerCollector
30		*/
31		public function __construct(MarkerCollector $markerCollector)
32		{
33		$this->setMarkerCollector($markerCollector);
34		}
35
36		/**
37		* @return MarkerCollector
38		*/
39		public function getMarkerCollector()
40		{
41		return $this->markerCollector;
42		}
43
44		/**
45		* @param MarkerCollector $markerCollector
46		*/
47		public function setMarkerCollector(MarkerCollector $markerCollector)
48		{
49		$this->markerCollector = $markerCollector;
50		}
51
52		/**
53		* @param Map $map
54		* @param MarkerShape[] $markerShapes
55		*
56		* @return MarkerShape[]
57		*/
58		public function collect(Map $map, array $markerShapes = [])
59		{
60		foreach ($this->markerCollector->collect($map) as $marker) {
61		if ($marker->hasShape()) {
62		$markerShapes = $this->collectValue($marker->getShape(), $markerShapes);
		0 ignored issues – show Bug introduced 2017-02-16 23:04 UTC by Report Bug Copy Issue Report It seems like `$marker->getShape()` can be `null`; however, `collectValue()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
63		}
64		}
65
66		return $markerShapes;
67		}
68		}
69

egeloen / ivory-google-map

GitHub Access Token became invalid

Push — symbol ( 74f22f )

MarkerShapeCollector A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like