| Conditions | 1 |
| Paths | 1 |
| Total Lines | 67 |
| Code Lines | 45 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 93 | protected function createSubscribers() |
||
| 94 | { |
||
| 95 | $formatter = $this->getFormatter(); |
||
| 96 | $jsonBuilder = $this->getJsonBuilder(); |
||
| 97 | |||
| 98 | // Overlay collectors |
||
| 99 | $encodedPolylineCollector = new EncodedPolylineCollector(); |
||
| 100 | $markerCollector = new MarkerCollector(); |
||
| 101 | $infoBoxCollector = new InfoBoxCollector($markerCollector); |
||
| 102 | |||
| 103 | // Control renderers |
||
| 104 | $controlManagerRenderer = new ControlManagerRenderer(); |
||
| 105 | |||
| 106 | // Utility renderers |
||
| 107 | $callbackRenderer = new CallbackRenderer($formatter); |
||
| 108 | $loaderRenderer = new LoaderRenderer($formatter, $jsonBuilder, $this->language); |
||
| 109 | $requirementLoaderRenderer = new RequirementLoaderRenderer($formatter); |
||
| 110 | $requirementRenderer = new RequirementRenderer($formatter); |
||
| 111 | $sourceRenderer = new SourceRenderer($formatter); |
||
| 112 | |||
| 113 | // Map renderers |
||
| 114 | $mapTypeIdRenderer = new MapTypeIdRenderer($formatter); |
||
| 115 | $mapRenderer = new MapRenderer( |
||
| 116 | $formatter, |
||
| 117 | $jsonBuilder, |
||
| 118 | $mapTypeIdRenderer, |
||
| 119 | $controlManagerRenderer, |
||
| 120 | $requirementRenderer |
||
| 121 | ); |
||
| 122 | |||
| 123 | // Overlay renderers |
||
| 124 | $encodingRenderer = new EncodingRenderer($formatter); |
||
| 125 | $encodedPolylineRenderer = new EncodedPolylineRenderer($formatter, $jsonBuilder, $encodingRenderer); |
||
| 126 | $infoBoxRenderer = new InfoBoxRenderer($formatter, $jsonBuilder, $requirementRenderer); |
||
| 127 | $markerClustererRenderer = new MarkerClustererRenderer($formatter, $jsonBuilder, $requirementRenderer); |
||
| 128 | |||
| 129 | // Place renderers |
||
| 130 | $autocompleteRenderer = new AutocompleteRenderer($formatter, $jsonBuilder, $requirementRenderer); |
||
| 131 | |||
| 132 | // Html renderers |
||
| 133 | $tagRenderer = new TagRenderer($formatter); |
||
| 134 | $javascriptTagRenderer = new JavascriptTagRenderer($formatter, $tagRenderer); |
||
| 135 | |||
| 136 | // Api renderers |
||
| 137 | $apiInitRenderer = new ApiInitRenderer($formatter); |
||
| 138 | $apiRenderer = new ApiRenderer( |
||
| 139 | $formatter, |
||
| 140 | $apiInitRenderer, |
||
| 141 | $loaderRenderer, |
||
| 142 | $requirementLoaderRenderer, |
||
| 143 | $sourceRenderer |
||
| 144 | ); |
||
| 145 | |||
| 146 | return array_merge([ |
||
| 147 | new ApiJavascriptSubscriber($formatter, $apiRenderer, $javascriptTagRenderer), |
||
| 148 | new AutocompleteJavascriptSubscriber( |
||
| 149 | $formatter, |
||
| 150 | $autocompleteRenderer, |
||
| 151 | $callbackRenderer, |
||
| 152 | $javascriptTagRenderer |
||
| 153 | ), |
||
| 154 | new EncodedPolylineSubscriber($formatter, $encodedPolylineCollector, $encodedPolylineRenderer), |
||
| 155 | new InfoBoxSubscriber($formatter, $infoBoxCollector, $infoBoxRenderer), |
||
| 156 | new MapJavascriptSubscriber($formatter, $mapRenderer, $callbackRenderer, $javascriptTagRenderer), |
||
| 157 | new MarkerClustererSubscriber($formatter, $markerClustererRenderer), |
||
| 158 | ], parent::createSubscribers()); |
||
| 159 | } |
||
| 160 | } |
||
| 161 |