Complex classes like DistanceMatrixRequest often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use DistanceMatrixRequest, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
21 | class DistanceMatrixRequest |
||
22 | { |
||
23 | /** |
||
24 | * @var LocationInterface[] |
||
25 | */ |
||
26 | private $origins = []; |
||
27 | |||
28 | /** |
||
29 | * @var LocationInterface[] |
||
30 | */ |
||
31 | private $destinations = []; |
||
32 | |||
33 | /** |
||
34 | * @var \DateTime|null |
||
35 | */ |
||
36 | private $departureTime; |
||
37 | |||
38 | /** |
||
39 | * @var \DateTime|null |
||
40 | */ |
||
41 | private $arrivalTime; |
||
42 | |||
43 | /** |
||
44 | * @var string|null |
||
45 | */ |
||
46 | private $travelMode; |
||
47 | |||
48 | /** |
||
49 | * @var string|null |
||
50 | */ |
||
51 | private $avoid; |
||
52 | |||
53 | /** |
||
54 | * @var string|null |
||
55 | */ |
||
56 | private $trafficModel; |
||
57 | |||
58 | /** |
||
59 | * @var string[] |
||
60 | */ |
||
61 | private $transitModes = []; |
||
62 | |||
63 | /** |
||
64 | * @var string|null |
||
65 | */ |
||
66 | private $transitRoutingPreference; |
||
67 | |||
68 | /** |
||
69 | * @var string|null |
||
70 | */ |
||
71 | private $region; |
||
72 | |||
73 | /** |
||
74 | * @var string|null |
||
75 | */ |
||
76 | private $unitSystem; |
||
77 | |||
78 | /** |
||
79 | * @var string|null |
||
80 | */ |
||
81 | private $language; |
||
82 | |||
83 | /** |
||
84 | * @param LocationInterface[] $origins |
||
85 | * @param LocationInterface[] $destinations |
||
86 | */ |
||
87 | public function __construct(array $origins, array $destinations) |
||
92 | |||
93 | /** |
||
94 | * @return bool |
||
95 | */ |
||
96 | public function hasOrigins() |
||
100 | |||
101 | /** |
||
102 | * @return LocationInterface[] |
||
103 | */ |
||
104 | public function getOrigins() |
||
108 | |||
109 | /** |
||
110 | * @param LocationInterface[] $origins |
||
111 | */ |
||
112 | public function setOrigins(array $origins) |
||
117 | |||
118 | /** |
||
119 | * @param LocationInterface[] $origins |
||
120 | */ |
||
121 | public function addOrigins(array $origins) |
||
127 | |||
128 | /** |
||
129 | * @param LocationInterface $origin |
||
130 | * |
||
131 | * @return bool |
||
132 | */ |
||
133 | public function hasOrigin(LocationInterface $origin) |
||
137 | |||
138 | /** |
||
139 | * @param LocationInterface $origin |
||
140 | */ |
||
141 | public function addOrigin(LocationInterface $origin) |
||
147 | |||
148 | /** |
||
149 | * @param LocationInterface $origin |
||
150 | */ |
||
151 | public function removeOrigin(LocationInterface $origin) |
||
156 | |||
157 | /** |
||
158 | * @return bool |
||
159 | */ |
||
160 | public function hasDestinations() |
||
164 | |||
165 | /** |
||
166 | * @return LocationInterface[] |
||
167 | */ |
||
168 | public function getDestinations() |
||
172 | |||
173 | /** |
||
174 | * @param LocationInterface[] $destinations |
||
175 | */ |
||
176 | public function setDestinations(array $destinations) |
||
181 | |||
182 | /** |
||
183 | * @param LocationInterface[] $destinations |
||
184 | */ |
||
185 | public function addDestinations(array $destinations) |
||
191 | |||
192 | /** |
||
193 | * @param LocationInterface $destination |
||
194 | * |
||
195 | * @return bool |
||
196 | */ |
||
197 | public function hasDestination(LocationInterface $destination) |
||
201 | |||
202 | /** |
||
203 | * @param LocationInterface $destination |
||
204 | */ |
||
205 | public function addDestination(LocationInterface $destination) |
||
211 | |||
212 | /** |
||
213 | * @param LocationInterface $destination |
||
214 | */ |
||
215 | public function removeDestination(LocationInterface $destination) |
||
220 | |||
221 | /** |
||
222 | * @return bool |
||
223 | */ |
||
224 | public function hasDepartureTime() |
||
228 | |||
229 | /** |
||
230 | * @return \DateTime|null |
||
231 | */ |
||
232 | public function getDepartureTime() |
||
236 | |||
237 | /** |
||
238 | * @param \DateTime|null $departureTime |
||
239 | */ |
||
240 | public function setDepartureTime(\DateTime $departureTime = null) |
||
244 | |||
245 | /** |
||
246 | * @return bool |
||
247 | */ |
||
248 | public function hasArrivalTime() |
||
252 | |||
253 | /** |
||
254 | * @return \DateTime|null |
||
255 | */ |
||
256 | public function getArrivalTime() |
||
260 | |||
261 | /** |
||
262 | * @param \DateTime|null $arrivalTime |
||
263 | */ |
||
264 | public function setArrivalTime(\DateTime $arrivalTime = null) |
||
268 | |||
269 | /** |
||
270 | * @return bool |
||
271 | */ |
||
272 | public function hasTravelMode() |
||
276 | |||
277 | /** |
||
278 | * @return string|null |
||
279 | */ |
||
280 | public function getTravelMode() |
||
284 | |||
285 | /** |
||
286 | * @param string|null $travelMode |
||
287 | */ |
||
288 | public function setTravelMode($travelMode = null) |
||
292 | |||
293 | /** |
||
294 | * @return bool |
||
295 | */ |
||
296 | public function hasAvoid() |
||
300 | |||
301 | /** |
||
302 | * @return string|null |
||
303 | */ |
||
304 | public function getAvoid() |
||
308 | |||
309 | /** |
||
310 | * @param string|null $avoid |
||
311 | */ |
||
312 | public function setAvoid($avoid = null) |
||
316 | |||
317 | /** |
||
318 | * @return bool |
||
319 | */ |
||
320 | public function hasTrafficModel() |
||
324 | |||
325 | /** |
||
326 | * @return string|null |
||
327 | */ |
||
328 | public function getTrafficModel() |
||
332 | |||
333 | /** |
||
334 | * @param string|null $trafficModel |
||
335 | */ |
||
336 | public function setTrafficModel($trafficModel) |
||
340 | |||
341 | /** |
||
342 | * @return bool |
||
343 | */ |
||
344 | public function hasTransitModes() |
||
348 | |||
349 | /** |
||
350 | * @return string[] |
||
351 | */ |
||
352 | public function getTransitModes() |
||
356 | |||
357 | /** |
||
358 | * @param string[] $transitModes |
||
359 | */ |
||
360 | public function setTransitModes(array $transitModes) |
||
365 | |||
366 | /** |
||
367 | * @param string[] $transitModes |
||
368 | */ |
||
369 | public function addTransitModes(array $transitModes) |
||
375 | |||
376 | /** |
||
377 | * @param string $transitMode |
||
378 | * |
||
379 | * @return bool |
||
380 | */ |
||
381 | public function hasTransitMode($transitMode) |
||
385 | |||
386 | /** |
||
387 | * @param string $transitMode |
||
388 | */ |
||
389 | public function addTransitMode($transitMode) |
||
395 | |||
396 | /** |
||
397 | * @param string $transitMode |
||
398 | */ |
||
399 | public function removeTransitMode($transitMode) |
||
404 | |||
405 | /** |
||
406 | * @return bool |
||
407 | */ |
||
408 | public function hasTransitRoutingPreference() |
||
412 | |||
413 | /** |
||
414 | * @return string|null |
||
415 | */ |
||
416 | public function getTransitRoutingPreference() |
||
420 | |||
421 | /** |
||
422 | * @param string|null $transitRoutingPreference |
||
423 | */ |
||
424 | public function setTransitRoutingPreference($transitRoutingPreference) |
||
428 | |||
429 | /** |
||
430 | * @return bool |
||
431 | */ |
||
432 | public function hasRegion() |
||
436 | |||
437 | /** |
||
438 | * @return string|null |
||
439 | */ |
||
440 | public function getRegion() |
||
444 | |||
445 | /** |
||
446 | * @param string|null $region |
||
447 | */ |
||
448 | public function setRegion($region = null) |
||
452 | |||
453 | /** |
||
454 | * @return bool |
||
455 | */ |
||
456 | public function hasUnitSystem() |
||
460 | |||
461 | /** |
||
462 | * @return string|null |
||
463 | */ |
||
464 | public function getUnitSystem() |
||
468 | |||
469 | /** |
||
470 | * @param string|null $unitSystem |
||
471 | */ |
||
472 | public function setUnitSystem($unitSystem = null) |
||
476 | |||
477 | /** |
||
478 | * @return bool |
||
479 | */ |
||
480 | public function hasLanguage() |
||
484 | |||
485 | /** |
||
486 | * @return string|null |
||
487 | */ |
||
488 | public function getLanguage() |
||
492 | |||
493 | /** |
||
494 | * @param string|null $language |
||
495 | */ |
||
496 | public function setLanguage($language = null) |
||
500 | |||
501 | /** |
||
502 | * @return mixed[] |
||
503 | */ |
||
504 | public function build() |
||
557 | } |
||
558 |