Complex classes like DistanceMatrixRequest often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use DistanceMatrixRequest, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
22 | class DistanceMatrixRequest implements DistanceMatrixRequestInterface |
||
23 | { |
||
24 | /** |
||
25 | * @var LocationInterface[] |
||
26 | */ |
||
27 | private $origins = []; |
||
28 | |||
29 | /** |
||
30 | * @var LocationInterface[] |
||
31 | */ |
||
32 | private $destinations = []; |
||
33 | |||
34 | /** |
||
35 | * @var \DateTime|null |
||
36 | */ |
||
37 | private $departureTime; |
||
38 | |||
39 | /** |
||
40 | * @var \DateTime|null |
||
41 | */ |
||
42 | private $arrivalTime; |
||
43 | |||
44 | /** |
||
45 | * @var string|null |
||
46 | */ |
||
47 | private $travelMode; |
||
48 | |||
49 | /** |
||
50 | * @var string|null |
||
51 | */ |
||
52 | private $avoid; |
||
53 | |||
54 | /** |
||
55 | * @var string|null |
||
56 | */ |
||
57 | private $trafficModel; |
||
58 | |||
59 | /** |
||
60 | * @var string[] |
||
61 | */ |
||
62 | private $transitModes = []; |
||
63 | |||
64 | /** |
||
65 | * @var string|null |
||
66 | */ |
||
67 | private $transitRoutingPreference; |
||
68 | |||
69 | /** |
||
70 | * @var string|null |
||
71 | */ |
||
72 | private $region; |
||
73 | |||
74 | /** |
||
75 | * @var string|null |
||
76 | */ |
||
77 | private $unitSystem; |
||
78 | |||
79 | /** |
||
80 | * @var string|null |
||
81 | */ |
||
82 | private $language; |
||
83 | |||
84 | /** |
||
85 | * @param LocationInterface[] $origins |
||
86 | * @param LocationInterface[] $destinations |
||
87 | */ |
||
88 | 348 | public function __construct(array $origins, array $destinations) |
|
93 | |||
94 | /** |
||
95 | * @return bool |
||
96 | */ |
||
97 | 20 | public function hasOrigins() |
|
101 | |||
102 | /** |
||
103 | * @return LocationInterface[] |
||
104 | */ |
||
105 | 20 | public function getOrigins() |
|
109 | |||
110 | /** |
||
111 | * @param LocationInterface[] $origins |
||
112 | */ |
||
113 | 348 | public function setOrigins(array $origins) |
|
118 | |||
119 | /** |
||
120 | * @param LocationInterface[] $origins |
||
121 | */ |
||
122 | 348 | public function addOrigins(array $origins) |
|
128 | |||
129 | /** |
||
130 | * @param LocationInterface $origin |
||
131 | * |
||
132 | * @return bool |
||
133 | */ |
||
134 | 348 | public function hasOrigin(LocationInterface $origin) |
|
138 | |||
139 | /** |
||
140 | * @param LocationInterface $origin |
||
141 | */ |
||
142 | 348 | public function addOrigin(LocationInterface $origin) |
|
148 | |||
149 | /** |
||
150 | * @param LocationInterface $origin |
||
151 | */ |
||
152 | 4 | public function removeOrigin(LocationInterface $origin) |
|
157 | |||
158 | /** |
||
159 | * @return bool |
||
160 | */ |
||
161 | 20 | public function hasDestinations() |
|
165 | |||
166 | /** |
||
167 | * @return LocationInterface[] |
||
168 | */ |
||
169 | 20 | public function getDestinations() |
|
173 | |||
174 | /** |
||
175 | * @param LocationInterface[] $destinations |
||
176 | */ |
||
177 | 348 | public function setDestinations(array $destinations) |
|
182 | |||
183 | /** |
||
184 | * @param LocationInterface[] $destinations |
||
185 | */ |
||
186 | 348 | public function addDestinations(array $destinations) |
|
192 | |||
193 | /** |
||
194 | * @param LocationInterface $destination |
||
195 | * |
||
196 | * @return bool |
||
197 | */ |
||
198 | 348 | public function hasDestination(LocationInterface $destination) |
|
202 | |||
203 | /** |
||
204 | * @param LocationInterface $destination |
||
205 | */ |
||
206 | 348 | public function addDestination(LocationInterface $destination) |
|
212 | |||
213 | /** |
||
214 | * @param LocationInterface $destination |
||
215 | */ |
||
216 | 4 | public function removeDestination(LocationInterface $destination) |
|
221 | |||
222 | /** |
||
223 | * @return bool |
||
224 | */ |
||
225 | 232 | public function hasDepartureTime() |
|
229 | |||
230 | /** |
||
231 | * @return \DateTime|null |
||
232 | */ |
||
233 | 12 | public function getDepartureTime() |
|
237 | |||
238 | /** |
||
239 | * @param \DateTime|null $departureTime |
||
240 | */ |
||
241 | 28 | public function setDepartureTime(\DateTime $departureTime = null) |
|
245 | |||
246 | /** |
||
247 | * @return bool |
||
248 | */ |
||
249 | 232 | public function hasArrivalTime() |
|
253 | |||
254 | /** |
||
255 | * @return \DateTime|null |
||
256 | */ |
||
257 | 12 | public function getArrivalTime() |
|
261 | |||
262 | /** |
||
263 | * @param \DateTime|null $arrivalTime |
||
264 | */ |
||
265 | 28 | public function setArrivalTime(\DateTime $arrivalTime = null) |
|
269 | |||
270 | /** |
||
271 | * @return bool |
||
272 | */ |
||
273 | 232 | public function hasTravelMode() |
|
277 | |||
278 | /** |
||
279 | * @return string|null |
||
280 | */ |
||
281 | 12 | public function getTravelMode() |
|
285 | |||
286 | /** |
||
287 | * @param string|null $travelMode |
||
288 | */ |
||
289 | 28 | public function setTravelMode($travelMode = null) |
|
293 | |||
294 | /** |
||
295 | * @return bool |
||
296 | */ |
||
297 | 232 | public function hasAvoid() |
|
301 | |||
302 | /** |
||
303 | * @return string|null |
||
304 | */ |
||
305 | 12 | public function getAvoid() |
|
309 | |||
310 | /** |
||
311 | * @param string|null $avoid |
||
312 | */ |
||
313 | 28 | public function setAvoid($avoid = null) |
|
317 | |||
318 | /** |
||
319 | * @return bool |
||
320 | */ |
||
321 | 232 | public function hasTrafficModel() |
|
325 | |||
326 | /** |
||
327 | * @return string|null |
||
328 | */ |
||
329 | 12 | public function getTrafficModel() |
|
333 | |||
334 | /** |
||
335 | * @param string|null $trafficModel |
||
336 | */ |
||
337 | 12 | public function setTrafficModel($trafficModel) |
|
341 | |||
342 | /** |
||
343 | * @return bool |
||
344 | */ |
||
345 | 240 | public function hasTransitModes() |
|
349 | |||
350 | /** |
||
351 | * @return string[] |
||
352 | */ |
||
353 | 20 | public function getTransitModes() |
|
357 | |||
358 | /** |
||
359 | * @param string[] $transitModes |
||
360 | */ |
||
361 | 12 | public function setTransitModes(array $transitModes) |
|
366 | |||
367 | /** |
||
368 | * @param string[] $transitModes |
||
369 | */ |
||
370 | 12 | public function addTransitModes(array $transitModes) |
|
376 | |||
377 | /** |
||
378 | * @param string $transitMode |
||
379 | * |
||
380 | * @return bool |
||
381 | */ |
||
382 | 20 | public function hasTransitMode($transitMode) |
|
386 | |||
387 | /** |
||
388 | * @param string $transitMode |
||
389 | */ |
||
390 | 20 | public function addTransitMode($transitMode) |
|
396 | |||
397 | /** |
||
398 | * @param string $transitMode |
||
399 | */ |
||
400 | 4 | public function removeTransitMode($transitMode) |
|
405 | |||
406 | /** |
||
407 | * @return bool |
||
408 | */ |
||
409 | 232 | public function hasTransitRoutingPreference() |
|
413 | |||
414 | /** |
||
415 | * @return string|null |
||
416 | */ |
||
417 | 12 | public function getTransitRoutingPreference() |
|
421 | |||
422 | /** |
||
423 | * @param string|null $transitRoutingPreference |
||
424 | */ |
||
425 | 12 | public function setTransitRoutingPreference($transitRoutingPreference) |
|
429 | |||
430 | /** |
||
431 | * @return bool |
||
432 | */ |
||
433 | 232 | public function hasRegion() |
|
437 | |||
438 | /** |
||
439 | * @return string|null |
||
440 | */ |
||
441 | 12 | public function getRegion() |
|
445 | |||
446 | /** |
||
447 | * @param string|null $region |
||
448 | */ |
||
449 | 28 | public function setRegion($region = null) |
|
453 | |||
454 | /** |
||
455 | * @return bool |
||
456 | */ |
||
457 | 232 | public function hasUnitSystem() |
|
461 | |||
462 | /** |
||
463 | * @return string|null |
||
464 | */ |
||
465 | 12 | public function getUnitSystem() |
|
469 | |||
470 | /** |
||
471 | * @param string|null $unitSystem |
||
472 | */ |
||
473 | 28 | public function setUnitSystem($unitSystem = null) |
|
477 | |||
478 | /** |
||
479 | * @return bool |
||
480 | */ |
||
481 | 232 | public function hasLanguage() |
|
485 | |||
486 | /** |
||
487 | * @return string|null |
||
488 | */ |
||
489 | 12 | public function getLanguage() |
|
493 | |||
494 | /** |
||
495 | * @param string|null $language |
||
496 | */ |
||
497 | 28 | public function setLanguage($language = null) |
|
501 | |||
502 | /** |
||
503 | * {@inheritdoc} |
||
504 | */ |
||
505 | public function buildQuery() |
||
564 | } |
||
565 |