| Conditions | 1 |
| Paths | 1 |
| Total Lines | 67 |
| Code Lines | 45 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 3 | ||
| Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 127 | protected function createSubscribers() |
||
| 128 | { |
||
| 129 | $formatter = $this->getFormatter(); |
||
| 130 | $jsonBuilder = $this->getJsonBuilder(); |
||
| 131 | |||
| 132 | // Overlay collectors |
||
| 133 | $encodedPolylineCollector = new EncodedPolylineCollector(); |
||
| 134 | $markerCollector = new MarkerCollector(); |
||
| 135 | $infoBoxCollector = new InfoBoxCollector($markerCollector); |
||
| 136 | |||
| 137 | // Control renderers |
||
| 138 | $controlManagerRenderer = new ControlManagerRenderer(); |
||
| 139 | |||
| 140 | // Utility renderers |
||
| 141 | $callbackRenderer = new CallbackRenderer($formatter); |
||
| 142 | $loaderRenderer = new LoaderRenderer($formatter, $jsonBuilder, $this->language, $this->key); |
||
| 143 | $requirementLoaderRenderer = new RequirementLoaderRenderer($formatter); |
||
| 144 | $requirementRenderer = new RequirementRenderer($formatter); |
||
| 145 | $sourceRenderer = new SourceRenderer($formatter); |
||
| 146 | |||
| 147 | // Map renderers |
||
| 148 | $mapTypeIdRenderer = new MapTypeIdRenderer($formatter); |
||
| 149 | $mapRenderer = new MapRenderer( |
||
| 150 | $formatter, |
||
| 151 | $jsonBuilder, |
||
| 152 | $mapTypeIdRenderer, |
||
| 153 | $controlManagerRenderer, |
||
| 154 | $requirementRenderer |
||
| 155 | ); |
||
| 156 | |||
| 157 | // Overlay renderers |
||
| 158 | $encodingRenderer = new EncodingRenderer($formatter); |
||
| 159 | $encodedPolylineRenderer = new EncodedPolylineRenderer($formatter, $jsonBuilder, $encodingRenderer); |
||
| 160 | $infoBoxRenderer = new InfoBoxRenderer($formatter, $jsonBuilder, $requirementRenderer); |
||
| 161 | $markerClustererRenderer = new MarkerClustererRenderer($formatter, $jsonBuilder, $requirementRenderer); |
||
| 162 | |||
| 163 | // Place renderers |
||
| 164 | $autocompleteRenderer = new AutocompleteRenderer($formatter, $jsonBuilder, $requirementRenderer); |
||
| 165 | |||
| 166 | // Html renderers |
||
| 167 | $tagRenderer = new TagRenderer($formatter); |
||
| 168 | $javascriptTagRenderer = new JavascriptTagRenderer($formatter, $tagRenderer); |
||
| 169 | |||
| 170 | // Api renderers |
||
| 171 | $apiInitRenderer = new ApiInitRenderer($formatter); |
||
| 172 | $apiRenderer = new ApiRenderer( |
||
| 173 | $formatter, |
||
| 174 | $apiInitRenderer, |
||
| 175 | $loaderRenderer, |
||
| 176 | $requirementLoaderRenderer, |
||
| 177 | $sourceRenderer |
||
| 178 | ); |
||
| 179 | |||
| 180 | return array_merge([ |
||
| 181 | new ApiJavascriptSubscriber($formatter, $apiRenderer, $javascriptTagRenderer), |
||
| 182 | new AutocompleteJavascriptSubscriber( |
||
| 183 | $formatter, |
||
| 184 | $autocompleteRenderer, |
||
| 185 | $callbackRenderer, |
||
| 186 | $javascriptTagRenderer |
||
| 187 | ), |
||
| 188 | new EncodedPolylineSubscriber($formatter, $encodedPolylineCollector, $encodedPolylineRenderer), |
||
| 189 | new InfoBoxSubscriber($formatter, $infoBoxCollector, $infoBoxRenderer), |
||
| 190 | new MapJavascriptSubscriber($formatter, $mapRenderer, $callbackRenderer, $javascriptTagRenderer), |
||
| 191 | new MarkerClustererSubscriber($formatter, $markerClustererRenderer), |
||
| 192 | ], parent::createSubscribers()); |
||
| 193 | } |
||
| 194 | } |
||
| 195 |
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.