SURFnet\VPN\Common\Http\TwoFactorModule

Complexity

Total Complexity

7

Size/Duplication

Total Lines	71
Duplicated Lines	8.45 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
B	init()	6	52	6

<?php
/**
 *  Copyright (C) 2016 SURFnet.
 *
 *  This program is free software: you can redistribute it and/or modify
 *  it under the terms of the GNU Affero General Public License as
 *  published by the Free Software Foundation, either version 3 of the
 *  License, or (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU Affero General Public License for more details.
 *
 *  You should have received a copy of the GNU Affero General Public License
 *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
namespace SURFnet\VPN\Common\Http;

use SURFnet\VPN\Common\TplInterface;
use SURFnet\VPN\Common\Http\Exception\HttpException;
use SURFnet\VPN\Common\HttpClient\ServerClient;

class TwoFactorModule implements ServiceModuleInterface
{
    /** @var \SURFnet\VPN\Common\HttpClient\ServerClient */
    private $serverClient;

    /** @var SessionInterface */
    private $session;

    /** @var \SURFnet\VPN\Common\TplInterface */
    private $tpl;

    public function __construct(ServerClient $serverClient, SessionInterface $session, TplInterface $tpl)
    {
        $this->serverClient = $serverClient;
        $this->session = $session;
        $this->tpl = $tpl;
    }

    public function init(Service $service)
    {
        $service->post(
            '/_two_factor/auth/verify',
            function (Request $request, array $hookData) {
                $userId = $hookData['auth'];

                $this->session->delete('_two_factor_verified');

                $otpKey = $request->getPostParameter('otpKey');
                $redirectTo = $request->getPostParameter('_two_factor_auth_redirect_to');

                // validate OTP key
                if (0 === preg_match('/^[0-9]{6}$/', $otpKey)) {
                    throw new HttpException('invalid OTP key format', 400);
                }

                // validate the URL
                if (false === filter_var($redirectTo, FILTER_VALIDATE_URL, FILTER_FLAG_SCHEME_REQUIRED | FILTER_FLAG_HOST_REQUIRED | FILTER_FLAG_PATH_REQUIRED)) {

This code seems to be duplicated across your project.

                    throw new HttpException('invalid redirect_to URL', 400);
                }

                // extract the "host" part of the URL
                if (false === $redirectToHost = parse_url($redirectTo, PHP_URL_HOST)) {

This code seems to be duplicated across your project.

                    throw new HttpException('invalid redirect_to URL, unable to extract host', 400);
                }
                if ($request->getServerName() !== $redirectToHost) {
                    throw new HttpException('redirect_to does not match expected host', 400);
                }

                if ($this->serverClient->verifyOtpKey($userId, $otpKey)) {
                    $this->session->set('_two_factor_verified', true);

                    return new RedirectResponse($redirectTo, 302);
                }

                // invalid otp
                $response = new Response(200, 'text/html');
                $response->setBody(
                    $this->tpl->render(
                        'twoFactorAuthentication',
                        [
                            '_two_factor_auth_invalid_key' => true,
                            '_two_factor_auth_redirect_to' => $redirectTo,
                        ]
                    )
                );

                return $response;
            }
        );
    }
}