TestHttpClient::get() - Code Metrics - Inspection of "refactor connect/disconnect and otp verify" - eduVPN/vpn-server-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 71cc31...7de261 )

by François

created 2016-10-10 13:59 UTC

TestHttpClient::get() C

↳ Parent: TestHttpClient

Complexity

Conditions	11
Paths	11

Size

Total Lines	49
Code Lines	33

Duplication

Lines	18
Ratio	36.73 %

Importance

Changes

Metric	Value
cc	11
eloc	33
nc	11
nop	1
dl	18
loc	49
rs	5.2653
c	0
b	0
f	0

How to fix Complexity

<?php
/**
 *  Copyright (C) 2016 SURFnet.
 *
 *  This program is free software: you can redistribute it and/or modify
 *  it under the terms of the GNU Affero General Public License as
 *  published by the Free Software Foundation, either version 3 of the
 *  License, or (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU Affero General Public License for more details.
 *
 *  You should have received a copy of the GNU Affero General Public License
 *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
namespace SURFnet\VPN\Server\Test;

use SURFnet\VPN\Common\HttpClient\HttpClientInterface;
use RuntimeException;
use SURFnet\VPN\Server\PoolConfig;

class TestHttpClient implements HttpClientInterface
{
    public function get($requestUri)
    {
        switch ($requestUri) {
            case 'serverClient/has_otp_secret?user_id=foo':
                return self::wrap('has_otp_secret', true);
            case 'serverClient/has_otp_secret?user_id=bar':
                return self::wrap('has_otp_secret', false);

            case 'connectionServerClient/is_disabled_user?user_id=foo':
                return self::wrap('is_disabled_user', false);
            case 'connectionServerClient/is_disabled_user?user_id=bar':
                return self::wrap('is_disabled_user', true);
            case 'connectionServerClient/is_disabled_common_name?common_name=foo_bar':
                return self::wrap('is_disabled_common_name', false);
            case 'connectionServerClient/is_disabled_common_name?common_name=foo_baz':
                return self::wrap('is_disabled_common_name', true);
            case 'connectionServerClient/server_pool?pool_id=internet':
                $poolConfig = new PoolConfig([]);

                return self::wrap('server_pool', $poolConfig->v());
            case 'connectionServerClient/server_pool?pool_id=acl':

                $poolConfig = new PoolConfig(
                    [
                        'enableAcl' => true,
                        'aclGroupList' => ['all'],
                    ]
                );

                return self::wrap('server_pool', $poolConfig->v());
            case 'connectionServerClient/server_pool?pool_id=acl2':

                $poolConfig = new PoolConfig(
                    [
                        'enableAcl' => true,
                        'aclGroupList' => ['students'],
                    ]
                );

                return self::wrap('server_pool', $poolConfig->v());
            case 'connectionServerClient/user_groups?user_id=foo':
                return self::wrap(
                    'user_groups',
                    [
                        ['id' => 'all', 'displayName' => 'All'],
                    ]
                );
            default:
                throw new RuntimeException(sprintf('unexpected requestUri "%s"', $requestUri));
        }
    }

    public function post($requestUri, array $postData)
    {
        switch ($requestUri) {
            case 'serverClient/verify_otp_key':
                if ('123456' === $postData['otp_key']) {
                    return self::wrap('verify_otp_key', true);
                }

                return self::wrap('verify_otp_key', false);
            case 'connectionServerClient/log_connect':
                return self::wrap('log_connect', true);
            case 'connectionServerClient/log_disconnect':
                return self::wrap('log_disconnect', true);
            default:
                throw new RuntimeException(sprintf('unexpected requestUri "%s"', $requestUri));
        }
    }

    private static function wrap($key, $response)
    {
        return [
            'data' => [
                $key => $response,
            ],
        ];
    }
}


GitHub Access Token became invalid

Push — master ( 71cc31...7de261 )

TestHttpClient::get() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

1		<?php
2		/**
3		* Copyright (C) 2016 SURFnet.
4		*
5		* This program is free software: you can redistribute it and/or modify
6		* it under the terms of the GNU Affero General Public License as
7		* published by the Free Software Foundation, either version 3 of the
8		* License, or (at your option) any later version.
9		*
10		* This program is distributed in the hope that it will be useful,
11		* but WITHOUT ANY WARRANTY; without even the implied warranty of
12		* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13		* GNU Affero General Public License for more details.
14		*
15		* You should have received a copy of the GNU Affero General Public License
16		* along with this program. If not, see <http://www.gnu.org/licenses/>.
17		*/
18		namespace SURFnet\VPN\Server\Test;
19
20		use SURFnet\VPN\Common\HttpClient\HttpClientInterface;
21		use RuntimeException;
22		use SURFnet\VPN\Server\PoolConfig;
23
24		class TestHttpClient implements HttpClientInterface
25		{
26		public function get($requestUri)
27		{
28		switch ($requestUri) {
29		case 'serverClient/has_otp_secret?user_id=foo':
30		return self::wrap('has_otp_secret', true);
31		case 'serverClient/has_otp_secret?user_id=bar':
32		return self::wrap('has_otp_secret', false);
33
34		case 'connectionServerClient/is_disabled_user?user_id=foo':
35		return self::wrap('is_disabled_user', false);
36		case 'connectionServerClient/is_disabled_user?user_id=bar':
37		return self::wrap('is_disabled_user', true);
38		case 'connectionServerClient/is_disabled_common_name?common_name=foo_bar':
39		return self::wrap('is_disabled_common_name', false);
40		case 'connectionServerClient/is_disabled_common_name?common_name=foo_baz':
41		return self::wrap('is_disabled_common_name', true);
42		case 'connectionServerClient/server_pool?pool_id=internet':
43		$poolConfig = new PoolConfig([]);
44
45		return self::wrap('server_pool', $poolConfig->v());
46	View Code Duplication	case 'connectionServerClient/server_pool?pool_id=acl':
		0 ignored issues – show Duplication introduced 2016-10-10 14:03 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47		$poolConfig = new PoolConfig(
48		[
49		'enableAcl' => true,
50		'aclGroupList' => ['all'],
51		]
52		);
53
54		return self::wrap('server_pool', $poolConfig->v());
55	View Code Duplication	case 'connectionServerClient/server_pool?pool_id=acl2':
		0 ignored issues – show Duplication introduced 2016-10-10 14:03 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		$poolConfig = new PoolConfig(
57		[
58		'enableAcl' => true,
59		'aclGroupList' => ['students'],
60		]
61		);
62
63		return self::wrap('server_pool', $poolConfig->v());
64		case 'connectionServerClient/user_groups?user_id=foo':
65		return self::wrap(
66		'user_groups',
67		[
68		['id' => 'all', 'displayName' => 'All'],
69		]
70		);
71		default:
72		throw new RuntimeException(sprintf('unexpected requestUri "%s"', $requestUri));
73		}
74		}
75
76		public function post($requestUri, array $postData)
77		{
78		switch ($requestUri) {
79		case 'serverClient/verify_otp_key':
80		if ('123456' === $postData['otp_key']) {
81		return self::wrap('verify_otp_key', true);
82		}
83
84		return self::wrap('verify_otp_key', false);
85		case 'connectionServerClient/log_connect':
86		return self::wrap('log_connect', true);
87		case 'connectionServerClient/log_disconnect':
88		return self::wrap('log_disconnect', true);
89		default:
90		throw new RuntimeException(sprintf('unexpected requestUri "%s"', $requestUri));
91		}
92		}
93
94		private static function wrap($key, $response)
95		{
96		return [
97		'data' => [
98		$key => $response,
99		],
100		];
101		}
102		}
103

eduVPN / vpn-server-api

GitHub Access Token became invalid

Push — master ( 71cc31...7de261 )

TestHttpClient::get() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like