Stats::get() - Code Metrics - Inspection of "refactor Stats a bit" - eduVPN/vpn-server-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 874bad...cd49ac )

by François

created 2016-11-08 23:05 UTC

Stats::get() F

↳ Parent: Stats

Complexity

Conditions	14
Paths	970

Size

Total Lines	100
Code Lines	60

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	100
rs	2.4369
cc	14
eloc	60
nc	970
nop	1

How to fix Long Method Complexity

<?php
/**
 *  Copyright (C) 2016 SURFnet.
 *
 *  This program is free software: you can redistribute it and/or modify
 *  it under the terms of the GNU Affero General Public License as
 *  published by the Free Software Foundation, either version 3 of the
 *  License, or (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU Affero General Public License for more details.
 *
 *  You should have received a copy of the GNU Affero General Public License
 *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

namespace SURFnet\VPN\Server;

use DateTime;

class Stats
{
    /** @var \DateTime */
    private $now;

    public function __construct(DateTime $now)
    {
        $this->now = $now;
    }

    public function get(array $logEntries)
    {
        $statsData = [];
        $timeConnection = [];
        $uniqueUsers = [];
        $activeUserCount = 0;

        foreach ($logEntries as $entry) {
            // determine user_id

            $userId = substr($entry['common_name'], 0, strpos($entry['common_name'], '_'));
            $connectedAt = $entry['connected_at'];
            $disconnectedAt = $entry['disconnected_at'];
            $dateOfConnection = date('Y-m-d', $connectedAt);

            if (!array_key_exists($dateOfConnection, $statsData)) {
                $statsData[$dateOfConnection] = [
                    'number_of_connections' => 0,
                    'bytes_transferred' => 0,
                    'unique_user_list' => [],
                ];
            }

            if (is_null($disconnectedAt)) {
                $activeUserCount += 1;
            }

            $statsData[$dateOfConnection]['number_of_connections'] += 1;
            $statsData[$dateOfConnection]['bytes_transferred'] += $entry['bytes_transferred'];

            // add it to table to be able to determine max concurrent connection
            // count
            if (!array_key_exists($connectedAt, $timeConnection)) {
                $timeConnection[$connectedAt] = [];
            }
            $timeConnection[$connectedAt][] = 'C';

            if (!is_null($disconnectedAt)) {
                if (!array_key_exists($disconnectedAt, $timeConnection)) {
                    $timeConnection[$disconnectedAt] = [];
                }
                $timeConnection[$disconnectedAt][] = 'D';
            }

            // unique user list per day
            if (!in_array($userId, $statsData[$dateOfConnection]['unique_user_list'])) {
                $statsData[$dateOfConnection]['unique_user_list'][] = $userId;
            }

            // unique user list for the whole logging period
            if (!in_array($userId, $uniqueUsers)) {
                $uniqueUsers[] = $userId;
            }
        }

        ksort($timeConnection);
        $firstEntryTime = intval(key($timeConnection));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        end($timeConnection);
        $lastEntryTime = intval(key($timeConnection));
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        reset($timeConnection);

        $maxConcurrentConnections = 0;
        $maxConcurrentConnectionsTime = 0;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $concurrentConnections = 0;
        foreach ($timeConnection as $unixTime => $eventArray) {
            foreach ($eventArray as $event) {
                if ('C' === $event) {
                    ++$concurrentConnections;
                    if ($concurrentConnections > $maxConcurrentConnections) {
                        $maxConcurrentConnections = $concurrentConnections;
                        $maxConcurrentConnectionsTime = $unixTime;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                    }
                } else {
                    --$concurrentConnections;
                }
            }
        }

        $totalTraffic = 0;
        // convert the user list in unique user count for that day, rework array
        // key and determine total amount of traffic
        foreach ($statsData as $date => $entry) {
            $statsData[$date]['date'] = $date;
            $statsData[$date]['unique_user_count'] = count($entry['unique_user_list']);
            unset($statsData[$date]['unique_user_list']);
            $totalTraffic += $entry['bytes_transferred'];
        }

        return [
            'days' => array_values($statsData),
            'total_traffic' => $totalTraffic,
            'generated_at' => $this->now->getTimestamp(),
            'max_concurrent_connections' => $maxConcurrentConnections,
//            'max_concurrent_connections_time' => $maxConcurrentConnectionsTime,

//            'first_entry' => $firstEntryTime,
//            'last_entry' => $lastEntryTime,
            'unique_user_count' => count($uniqueUsers),
            'active_user_count' => $activeUserCount,
        ];
    }
}


1			<?php
2			/**
3			* Copyright (C) 2016 SURFnet.
4			*
5			* This program is free software: you can redistribute it and/or modify
6			* it under the terms of the GNU Affero General Public License as
7			* published by the Free Software Foundation, either version 3 of the
8			* License, or (at your option) any later version.
9			*
10			* This program is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13			* GNU Affero General Public License for more details.
14			*
15			* You should have received a copy of the GNU Affero General Public License
16			* along with this program. If not, see <http://www.gnu.org/licenses/>.
17			*/
18
19			namespace SURFnet\VPN\Server;
20
21			use DateTime;
22
23			class Stats
24			{
25			/** @var \DateTime */
26			private $now;
27
28			public function __construct(DateTime $now)
29			{
30			$this->now = $now;
31			}
32
33			public function get(array $logEntries)
34			{
35			$statsData = [];
36			$timeConnection = [];
37			$uniqueUsers = [];
38			$activeUserCount = 0;
39
40			foreach ($logEntries as $entry) {
41			// determine user_id
42
43			$userId = substr($entry['common_name'], 0, strpos($entry['common_name'], '_'));
44			$connectedAt = $entry['connected_at'];
45			$disconnectedAt = $entry['disconnected_at'];
46			$dateOfConnection = date('Y-m-d', $connectedAt);
47
48			if (!array_key_exists($dateOfConnection, $statsData)) {
49			$statsData[$dateOfConnection] = [
50			'number_of_connections' => 0,
51			'bytes_transferred' => 0,
52			'unique_user_list' => [],
53			];
54			}
55
56			if (is_null($disconnectedAt)) {
57			$activeUserCount += 1;
58			}
59
60			$statsData[$dateOfConnection]['number_of_connections'] += 1;
61			$statsData[$dateOfConnection]['bytes_transferred'] += $entry['bytes_transferred'];
62
63			// add it to table to be able to determine max concurrent connection
64			// count
65			if (!array_key_exists($connectedAt, $timeConnection)) {
66			$timeConnection[$connectedAt] = [];
67			}
68			$timeConnection[$connectedAt][] = 'C';
69
70			if (!is_null($disconnectedAt)) {
71			if (!array_key_exists($disconnectedAt, $timeConnection)) {
72			$timeConnection[$disconnectedAt] = [];
73			}
74			$timeConnection[$disconnectedAt][] = 'D';
75			}
76
77			// unique user list per day
78			if (!in_array($userId, $statsData[$dateOfConnection]['unique_user_list'])) {
79			$statsData[$dateOfConnection]['unique_user_list'][] = $userId;
80			}
81
82			// unique user list for the whole logging period
83			if (!in_array($userId, $uniqueUsers)) {
84			$uniqueUsers[] = $userId;
85			}
86			}
87
88			ksort($timeConnection);
89			$firstEntryTime = intval(key($timeConnection));
			0 ignored issues – show Unused Code introduced 2016-11-08 23:07 UTC by Report Bug Copy Issue Report `$firstEntryTime` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
90			end($timeConnection);
91			$lastEntryTime = intval(key($timeConnection));
			0 ignored issues – show Unused Code introduced 2016-11-08 23:07 UTC by Report Bug Copy Issue Report `$lastEntryTime` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
92			reset($timeConnection);
93
94			$maxConcurrentConnections = 0;
95			$maxConcurrentConnectionsTime = 0;
			0 ignored issues – show Unused Code introduced 2016-11-08 23:07 UTC by Report Bug Copy Issue Report `$maxConcurrentConnectionsTime` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
96			$concurrentConnections = 0;
97			foreach ($timeConnection as $unixTime => $eventArray) {
98			foreach ($eventArray as $event) {
99			if ('C' === $event) {
100			++$concurrentConnections;
101			if ($concurrentConnections > $maxConcurrentConnections) {
102			$maxConcurrentConnections = $concurrentConnections;
103			$maxConcurrentConnectionsTime = $unixTime;
			0 ignored issues – show Unused Code introduced 2016-11-08 23:07 UTC by Report Bug Copy Issue Report `$maxConcurrentConnectionsTime` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
104			}
105			} else {
106			--$concurrentConnections;
107			}
108			}
109			}
110
111			$totalTraffic = 0;
112			// convert the user list in unique user count for that day, rework array
113			// key and determine total amount of traffic
114			foreach ($statsData as $date => $entry) {
115			$statsData[$date]['date'] = $date;
116			$statsData[$date]['unique_user_count'] = count($entry['unique_user_list']);
117			unset($statsData[$date]['unique_user_list']);
118			$totalTraffic += $entry['bytes_transferred'];
119			}
120
121			return [
122			'days' => array_values($statsData),
123			'total_traffic' => $totalTraffic,
124			'generated_at' => $this->now->getTimestamp(),
125			'max_concurrent_connections' => $maxConcurrentConnections,
126			// 'max_concurrent_connections_time' => $maxConcurrentConnectionsTime,
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-11-08 23:07 UTC by Report Bug Copy Issue Report `53%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
127			// 'first_entry' => $firstEntryTime,
128			// 'last_entry' => $lastEntryTime,
129			'unique_user_count' => count($uniqueUsers),
130			'active_user_count' => $activeUserCount,
131			];
132			}
133			}
134

eduVPN / vpn-server-api

GitHub Access Token became invalid

Push — master ( 874bad...cd49ac )

Stats::get() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like