Pool - Code Metrics - Inspection of "- redo group support to have identifiers and displ..." - eduVPN/vpn-server-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9b308f...ba5807 )

by François

created 2016-07-13 13:51 UTC

Pool C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	401
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	21
Bugs	5	Features	5

Metric	Value
wmc	65
c	21
b	5
f	5
lcom	1
cbo	2
dl	0
loc	401
rs	5.7894

42 Methods

Rating	Name	Size	Complexity
A	getId()	4	1
A	setName()	5	1
A	getName()	4	1
A	setHostName()	5	1
A	getHostName()	4	1
A	setDefaultGateway()	4	1
A	getDefaultGateway()	4	1
A	setRange()	4	1
A	getRange()	4	1
A	setRange6()	4	1
A	getRange6()	4	1
A	setRoutes()	8	2
A	getRoutes()	4	1
A	setDns()	8	2
A	getDns()	4	1
A	setUseNat()	4	1
A	getUseNat()	4	1
A	setExtIf()	5	1
A	getExtIf()	4	1
A	setTwoFactor()	4	1
A	getTwoFactor()	4	1
A	setClientToClient()	4	1
A	getClientToClient()	4	1
A	setManagementIp()	4	1
A	getManagementIp()	4	1
A	setListen()	4	1
A	getListen()	4	1
A	getInstances()	4	1
A	setEnableLog()	4	1
A	getEnableLog()	4	1
A	setEnableAcl()	4	1
A	getEnableAcl()	4	1
A	__construct()	21	1
A	setId()	5	1
A	setAclGroupList()	8	2
A	getAclGroupList()	4	1
B	populateInstances()	29	4
B	getNetCount()	20	10
B	toArray()	38	4
A	validate()	12	3
A	validateString()	9	3
A	validateSimpleString()	10	2

How to fix Complexity

<?php
/**
 * Copyright 2016 François Kooman <[email protected]>.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace fkooman\VPN\Server;

use RuntimeException;
use InvalidArgumentException;
use DomainException;

class Pool
{
    /** @var string */
    private $id;

    /** @var string */
    private $poolName;

    /** @var string */
    private $hostName;

    /** @var bool */
    private $defaultGateway;

    /** @var IP */
    private $range;

    /** @var IP */
    private $range6;

    /** @var array */
    private $routes;

    /** @var array */
    private $dns;

    /** @var bool */
    private $useNat;

    /** @var string */
    private $extIf;

    /** @var bool */
    private $twoFactor;

    /** @var bool */
    private $clientToClient;

    /** @var IP */
    private $managementIp;

    /** @var IP */
    private $listen;

    /** @var array */
    private $instances;

    /** @var bool */
    private $enableLog;

    /** @var bool */
    private $enableAcl;

    /** @var array */
    private $aclGroupList;

    public function __construct($poolNumber, array $poolData)
    {
        $this->setId(self::validate($poolData, 'id'));
        $this->setName(self::validate($poolData, 'name', false, $this->getId()));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->setHostName(self::validate($poolData, 'hostName'));
        $this->setDefaultGateway(self::validate($poolData, 'defaultGateway', false, false));
        $this->setRange(new IP(self::validate($poolData, 'range')));
        $this->setRange6(new IP(self::validate($poolData, 'range6')));
        $this->setRoutes(self::validate($poolData, 'routes', false, []));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->setDns(self::validate($poolData, 'dns', false, []));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->setUseNat(self::validate($poolData, 'useNat', false, false));
        $this->setExtIf(self::validate($poolData, 'extIf'));
        $this->setTwoFactor(self::validate($poolData, 'twoFactor', false, false));
        $this->setClientToClient(self::validate($poolData, 'clientToClient', false, false));
        $this->setManagementIp(new IP(sprintf('127.42.%d.1', $poolNumber)));
        $this->setListen(new IP(self::validate($poolData, 'listen', false, '::')));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->setEnableLog(self::validate($poolData, 'enableLog', false, false));
        $this->setEnableAcl(self::validate($poolData, 'enableAcl', false, false));
        $this->setAclGroupList(self::validate($poolData, 'aclGroupList', false, []));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->populateInstances();
    }

    public function setId($id)
    {
        self::validateSimpleString($id);
        $this->id = $id;
    }

    public function getId()
    {
        return $this->id;
    }

    public function setName($poolName)
    {
        self::validateString($poolName);
        $this->poolName = $poolName;
    }

    public function getName()
    {
        return $this->poolName;
    }

    public function setHostName($hostName)
    {
        self::validateString($hostName);
        $this->hostName = $hostName;
    }

    public function getHostName()
    {
        return $this->hostName;
    }

    public function setDefaultGateway($defaultGateway)
    {
        $this->defaultGateway = (bool) $defaultGateway;
    }

    public function getDefaultGateway()
    {
        return $this->defaultGateway;
    }

    public function setRange(IP $range)
    {
        $this->range = $range;
    }

    public function getRange()
    {
        return $this->range;
    }

    public function setRange6(IP $range6)
    {
        $this->range6 = $range6;
    }

    public function getRange6()
    {
        return $this->range6;
    }

    public function setRoutes(array $routes)
    {
        $this->routes = [];

        foreach ($routes as $route) {
            $this->routes[] = new IP($route);
        }
    }

    public function getRoutes()
    {
        return $this->routes;
    }

    public function setDns(array $dns)
    {
        $this->dns = [];

        foreach ($dns as $server) {
            $this->dns[] = new IP($server);
        }
    }

    public function getDns()
    {
        return $this->dns;
    }

    public function setUseNat($useNat)
    {
        $this->useNat = (bool) $useNat;
    }

    public function getUseNat()
    {
        return $this->useNat;
    }

    public function setExtIf($extIf)
    {
        self::validateString($extIf);
        $this->extIf = $extIf;
    }

    public function getExtIf()
    {
        return $this->extIf;
    }

    public function setTwoFactor($twoFactor)
    {
        $this->twoFactor = (bool) $twoFactor;
    }

    public function getTwoFactor()
    {
        return $this->twoFactor;
    }

    public function setClientToClient($clientToClient)
    {
        $this->clientToClient = (bool) $clientToClient;
    }

    public function getClientToClient()
    {
        return $this->clientToClient;
    }

    public function setManagementIp(IP $managementIp)
    {
        $this->managementIp = $managementIp;
    }

    public function getManagementIp()
    {
        return $this->managementIp;
    }

    public function setListen(IP $listen)
    {
        $this->listen = $listen;
    }

    public function getListen()
    {
        return $this->listen;
    }

    public function getInstances()
    {
        return $this->instances;
    }

    public function setEnableLog($enableLog)
    {
        $this->enableLog = (bool) $enableLog;
    }

    public function getEnableLog()
    {
        return $this->enableLog;
    }

    public function setEnableAcl($enableAcl)
    {
        $this->enableAcl = (bool) $enableAcl;
    }

    public function getEnableAcl()
    {
        return $this->enableAcl;
    }

    public function setAclGroupList(array $aclGroupList)
    {
        foreach ($aclGroupList as $aclGroup) {
            self::validateString($aclGroup);
        }

        $this->aclGroupList = array_values($aclGroupList);
    }

    public function getAclGroupList()
    {
        return $this->aclGroupList;
    }

    private function populateInstances()
    {
        $instanceCount = self::getNetCount($this->getRange()->getPrefix());
        $splitRange = $this->getRange()->split($instanceCount);
        $splitRange6 = $this->getRange6()->split($instanceCount);

        for ($i = 0; $i < $instanceCount; ++$i) {
            // protocol is udp unless it is the last instance when there is
            // not just one instance
            if (1 === $instanceCount || $i !== $instanceCount - 1) {
                $proto = 'udp';
                $port = 1194 + $i;
            } else {
                $proto = 'tcp';
                $port = 1194;
            }

            $this->instances[] = new Instance(
                [
                    'range' => $splitRange[$i],
                    'range6' => $splitRange6[$i],
                    'dev' => sprintf('tun-%s-%d', $this->getId(), $i),
                    'proto' => $proto,
                    'port' => $port,
                    'managementPort' => 11940 + $i,
                ]
            );
        }
    }

    /**
     * Depending on the prefix we will divide it in a number of nets to
     * balance the load over the instances, it is recommended to use a least
     * a /24.
     *
     * A /24 or 'bigger' will be split in 4 networks, everything 'smaller'
     * will be either be split in 2 networks or remain 1 network.
     */
    private static function getNetCount($prefix)
    {
        switch ($prefix) {
            case 32:    // 1 IP
            case 31:    // 2 IPs
                throw new RuntimeException('not enough available IPs in range');
            case 30:    // 4 IPs (1 usable for client, no splitting)
            case 29:    // 8 IPs (5 usable for clients, no splitting)
                return 1;
            case 28:    // 16 IPs (12 usable for clients)

            case 27:    // 32 IPs
            case 26:    // 64 IPs
            case 25:    // 128 IPs
                return 2;
            case 24:
                return 4;
        }

        return 8;
    }

    public function toArray()
    {
        $routesList = [];
        foreach ($this->getRoutes() as $route) {
            $routesList[] = $route->getAddressPrefix();
        }

        $dnsList = [];
        foreach ($this->getDns() as $dns) {
            $dnsList[] = $dns->getAddress();
        }

        $instancesList = [];
        foreach ($this->getInstances() as $instance) {
            $instancesList[] = $instance->toArray();
        }

        return [
            'aclGroupList' => $this->getAclGroupList(),
            'clientToClient' => $this->getClientToClient(),
            'defaultGateway' => $this->getDefaultGateway(),
            'dns' => $dnsList,
            'enableAcl' => $this->getEnableAcl(),
            'enableLog' => $this->getEnableLog(),
            'extIf' => $this->getExtIf(),
            'hostName' => $this->getHostName(),
            'id' => $this->getId(),
            'instances' => $instancesList,
            'listen' => $this->getListen()->getAddress(),
            'managementIp' => $this->getManagementIp()->getAddress(),
            'name' => $this->getName(),
            'range' => $this->getRange()->getAddressPrefix(),
            'range6' => $this->getRange6()->getAddressPrefix(),
            'routes' => $routesList,
            'twoFactor' => $this->getTwoFactor(),
            'useNat' => $this->getUseNat(),
        ];
    }

    private static function validate(array $configData, $configName, $requiredField = true, $defaultValue = false)
    {
        if (!array_key_exists($configName, $configData)) {
            if ($requiredField) {
                throw new RuntimeException(sprintf('missing configuration field "%s"', $configName));
            }

            return $defaultValue;
        }

        return $configData[$configName];
    }

    private static function validateString($input)
    {
        if (!is_string($input)) {
            throw new InvalidArgumentException('parameter must be string');
        }
        if (0 >= strlen($input)) {
            throw new DomainException('parameter must be non-empty string');
        }
    }

    private static function validateSimpleString($input)
    {
        self::validateString($input);
        $matchPattern = '/^[a-zA-Z0-9]+$/';
        if (1 !== preg_match($matchPattern, $input)) {
            throw new DomainException(
                sprintf('parameter must match pattern "%s"', $matchPattern)
            );
        }
    }
}


GitHub Access Token became invalid

Push — master ( 9b308f...ba5807 )

Pool C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

42 Methods

How to fix Complexity

Complex Class

1			<?php
2			/**
3			* Copyright 2016 François Kooman <[email protected]>.
4			*
5			* Licensed under the Apache License, Version 2.0 (the "License");
6			* you may not use this file except in compliance with the License.
7			* You may obtain a copy of the License at
8			*
9			* http://www.apache.org/licenses/LICENSE-2.0
10			*
11			* Unless required by applicable law or agreed to in writing, software
12			* distributed under the License is distributed on an "AS IS" BASIS,
13			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14			* See the License for the specific language governing permissions and
15			* limitations under the License.
16			*/
17
18			namespace fkooman\VPN\Server;
19
20			use RuntimeException;
21			use InvalidArgumentException;
22			use DomainException;
23
24			class Pool
25			{
26			/** @var string */
27			private $id;
28
29			/** @var string */
30			private $poolName;
31
32			/** @var string */
33			private $hostName;
34
35			/** @var bool */
36			private $defaultGateway;
37
38			/** @var IP */
39			private $range;
40
41			/** @var IP */
42			private $range6;
43
44			/** @var array */
45			private $routes;
46
47			/** @var array */
48			private $dns;
49
50			/** @var bool */
51			private $useNat;
52
53			/** @var string */
54			private $extIf;
55
56			/** @var bool */
57			private $twoFactor;
58
59			/** @var bool */
60			private $clientToClient;
61
62			/** @var IP */
63			private $managementIp;
64
65			/** @var IP */
66			private $listen;
67
68			/** @var array */
69			private $instances;
70
71			/** @var bool */
72			private $enableLog;
73
74			/** @var bool */
75			private $enableAcl;
76
77			/** @var array */
78			private $aclGroupList;
79
80			public function __construct($poolNumber, array $poolData)
81			{
82			$this->setId(self::validate($poolData, 'id'));
83			$this->setName(self::validate($poolData, 'name', false, $this->getId()));
			0 ignored issues – show Documentation introduced 2016-05-20 19:42 UTC by Report Bug Copy Issue Report `$this->getId()` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
84			$this->setHostName(self::validate($poolData, 'hostName'));
85			$this->setDefaultGateway(self::validate($poolData, 'defaultGateway', false, false));
86			$this->setRange(new IP(self::validate($poolData, 'range')));
87			$this->setRange6(new IP(self::validate($poolData, 'range6')));
88			$this->setRoutes(self::validate($poolData, 'routes', false, []));
			0 ignored issues – show Documentation introduced 2016-05-18 12:21 UTC by Report Bug Copy Issue Report `array()` is of type `array`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
89			$this->setDns(self::validate($poolData, 'dns', false, []));
			0 ignored issues – show Documentation introduced 2016-05-18 12:21 UTC by Report Bug Copy Issue Report `array()` is of type `array`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
90			$this->setUseNat(self::validate($poolData, 'useNat', false, false));
91			$this->setExtIf(self::validate($poolData, 'extIf'));
92			$this->setTwoFactor(self::validate($poolData, 'twoFactor', false, false));
93			$this->setClientToClient(self::validate($poolData, 'clientToClient', false, false));
94			$this->setManagementIp(new IP(sprintf('127.42.%d.1', $poolNumber)));
95			$this->setListen(new IP(self::validate($poolData, 'listen', false, '::')));
			0 ignored issues – show Documentation introduced 2016-05-18 12:21 UTC by Report Bug Copy Issue Report `'::'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
96			$this->setEnableLog(self::validate($poolData, 'enableLog', false, false));
97			$this->setEnableAcl(self::validate($poolData, 'enableAcl', false, false));
98			$this->setAclGroupList(self::validate($poolData, 'aclGroupList', false, []));
			0 ignored issues – show Documentation introduced 2016-07-13 13:54 UTC by Report Bug Copy Issue Report `array()` is of type `array`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
99			$this->populateInstances();
100			}
101
102			public function setId($id)
103			{
104			self::validateSimpleString($id);
105			$this->id = $id;
106			}
107
108			public function getId()
109			{
110			return $this->id;
111			}
112
113			public function setName($poolName)
114			{
115			self::validateString($poolName);
116			$this->poolName = $poolName;
117			}
118
119			public function getName()
120			{
121			return $this->poolName;
122			}
123
124			public function setHostName($hostName)
125			{
126			self::validateString($hostName);
127			$this->hostName = $hostName;
128			}
129
130			public function getHostName()
131			{
132			return $this->hostName;
133			}
134
135			public function setDefaultGateway($defaultGateway)
136			{
137			$this->defaultGateway = (bool) $defaultGateway;
138			}
139
140			public function getDefaultGateway()
141			{
142			return $this->defaultGateway;
143			}
144
145			public function setRange(IP $range)
146			{
147			$this->range = $range;
148			}
149
150			public function getRange()
151			{
152			return $this->range;
153			}
154
155			public function setRange6(IP $range6)
156			{
157			$this->range6 = $range6;
158			}
159
160			public function getRange6()
161			{
162			return $this->range6;
163			}
164
165			public function setRoutes(array $routes)
166			{
167			$this->routes = [];
168
169			foreach ($routes as $route) {
170			$this->routes[] = new IP($route);
171			}
172			}
173
174			public function getRoutes()
175			{
176			return $this->routes;
177			}
178
179			public function setDns(array $dns)
180			{
181			$this->dns = [];
182
183			foreach ($dns as $server) {
184			$this->dns[] = new IP($server);
185			}
186			}
187
188			public function getDns()
189			{
190			return $this->dns;
191			}
192
193			public function setUseNat($useNat)
194			{
195			$this->useNat = (bool) $useNat;
196			}
197
198			public function getUseNat()
199			{
200			return $this->useNat;
201			}
202
203			public function setExtIf($extIf)
204			{
205			self::validateString($extIf);
206			$this->extIf = $extIf;
207			}
208
209			public function getExtIf()
210			{
211			return $this->extIf;
212			}
213
214			public function setTwoFactor($twoFactor)
215			{
216			$this->twoFactor = (bool) $twoFactor;
217			}
218
219			public function getTwoFactor()
220			{
221			return $this->twoFactor;
222			}
223
224			public function setClientToClient($clientToClient)
225			{
226			$this->clientToClient = (bool) $clientToClient;
227			}
228
229			public function getClientToClient()
230			{
231			return $this->clientToClient;
232			}
233
234			public function setManagementIp(IP $managementIp)
235			{
236			$this->managementIp = $managementIp;
237			}
238
239			public function getManagementIp()
240			{
241			return $this->managementIp;
242			}
243
244			public function setListen(IP $listen)
245			{
246			$this->listen = $listen;
247			}
248
249			public function getListen()
250			{
251			return $this->listen;
252			}
253
254			public function getInstances()
255			{
256			return $this->instances;
257			}
258
259			public function setEnableLog($enableLog)
260			{
261			$this->enableLog = (bool) $enableLog;
262			}
263
264			public function getEnableLog()
265			{
266			return $this->enableLog;
267			}
268
269			public function setEnableAcl($enableAcl)
270			{
271			$this->enableAcl = (bool) $enableAcl;
272			}
273
274			public function getEnableAcl()
275			{
276			return $this->enableAcl;
277			}
278
279			public function setAclGroupList(array $aclGroupList)
280			{
281			foreach ($aclGroupList as $aclGroup) {
282			self::validateString($aclGroup);
283			}
284
285			$this->aclGroupList = array_values($aclGroupList);
286			}
287
288			public function getAclGroupList()
289			{
290			return $this->aclGroupList;
291			}
292
293			private function populateInstances()
294			{
295			$instanceCount = self::getNetCount($this->getRange()->getPrefix());
296			$splitRange = $this->getRange()->split($instanceCount);
297			$splitRange6 = $this->getRange6()->split($instanceCount);
298
299			for ($i = 0; $i < $instanceCount; ++$i) {
300			// protocol is udp unless it is the last instance when there is
301			// not just one instance
302			if (1 === $instanceCount \|\| $i !== $instanceCount - 1) {
303			$proto = 'udp';
304			$port = 1194 + $i;
305			} else {
306			$proto = 'tcp';
307			$port = 1194;
308			}
309
310			$this->instances[] = new Instance(
311			[
312			'range' => $splitRange[$i],
313			'range6' => $splitRange6[$i],
314			'dev' => sprintf('tun-%s-%d', $this->getId(), $i),
315			'proto' => $proto,
316			'port' => $port,
317			'managementPort' => 11940 + $i,
318			]
319			);
320			}
321			}
322
323			/**
324			* Depending on the prefix we will divide it in a number of nets to
325			* balance the load over the instances, it is recommended to use a least
326			* a /24.
327			*
328			* A /24 or 'bigger' will be split in 4 networks, everything 'smaller'
329			* will be either be split in 2 networks or remain 1 network.
330			*/
331			private static function getNetCount($prefix)
332			{
333			switch ($prefix) {
334			case 32: // 1 IP
335			case 31: // 2 IPs
336			throw new RuntimeException('not enough available IPs in range');
337			case 30: // 4 IPs (1 usable for client, no splitting)
338			case 29: // 8 IPs (5 usable for clients, no splitting)
339			return 1;
340			case 28: // 16 IPs (12 usable for clients)
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-05-20 19:12 UTC by Report Bug Copy Issue Report `36%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
341			case 27: // 32 IPs
342			case 26: // 64 IPs
343			case 25: // 128 IPs
344			return 2;
345			case 24:
346			return 4;
347			}
348
349			return 8;
350			}
351
352			public function toArray()
353			{
354			$routesList = [];
355			foreach ($this->getRoutes() as $route) {
356			$routesList[] = $route->getAddressPrefix();
357			}
358
359			$dnsList = [];
360			foreach ($this->getDns() as $dns) {
361			$dnsList[] = $dns->getAddress();
362			}
363
364			$instancesList = [];
365			foreach ($this->getInstances() as $instance) {
366			$instancesList[] = $instance->toArray();
367			}
368
369			return [
370			'aclGroupList' => $this->getAclGroupList(),
371			'clientToClient' => $this->getClientToClient(),
372			'defaultGateway' => $this->getDefaultGateway(),
373			'dns' => $dnsList,
374			'enableAcl' => $this->getEnableAcl(),
375			'enableLog' => $this->getEnableLog(),
376			'extIf' => $this->getExtIf(),
377			'hostName' => $this->getHostName(),
378			'id' => $this->getId(),
379			'instances' => $instancesList,
380			'listen' => $this->getListen()->getAddress(),
381			'managementIp' => $this->getManagementIp()->getAddress(),
382			'name' => $this->getName(),
383			'range' => $this->getRange()->getAddressPrefix(),
384			'range6' => $this->getRange6()->getAddressPrefix(),
385			'routes' => $routesList,
386			'twoFactor' => $this->getTwoFactor(),
387			'useNat' => $this->getUseNat(),
388			];
389			}
390
391			private static function validate(array $configData, $configName, $requiredField = true, $defaultValue = false)
392			{
393			if (!array_key_exists($configName, $configData)) {
394			if ($requiredField) {
395			throw new RuntimeException(sprintf('missing configuration field "%s"', $configName));
396			}
397
398			return $defaultValue;
399			}
400
401			return $configData[$configName];
402			}
403
404			private static function validateString($input)
405			{
406			if (!is_string($input)) {
407			throw new InvalidArgumentException('parameter must be string');
408			}
409			if (0 >= strlen($input)) {
410			throw new DomainException('parameter must be non-empty string');
411			}
412			}
413
414			private static function validateSimpleString($input)
415			{
416			self::validateString($input);
417			$matchPattern = '/^[a-zA-Z0-9]+$/';
418			if (1 !== preg_match($matchPattern, $input)) {
419			throw new DomainException(
420			sprintf('parameter must match pattern "%s"', $matchPattern)
421			);
422			}
423			}
424			}
425

eduVPN / vpn-server-api

GitHub Access Token became invalid

Push — master ( 9b308f...ba5807 )

Pool C

Complexity

Size/Duplication

Coupling/Cohesion

Importance

42 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like