VootProviderTest::setUp() - Code Metrics - Inspection of "update fkooman/oauth2-client" - eduVPN/vpn-server-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 70617b...52097e )

by François

created 2017-05-09 11:51 UTC

VootProviderTest::setUp() A

↳ Parent: VootProviderTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	51
Code Lines	35

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	51
rs	9.4109
c	0
b	0
f	0
cc	1
eloc	35
nc	1
nop	0

How to fix Long Method

<?php
/**
 *  Copyright (C) 2016 SURFnet.
 *
 *  This program is free software: you can redistribute it and/or modify
 *  it under the terms of the GNU Affero General Public License as
 *  published by the Free Software Foundation, either version 3 of the
 *  License, or (at your option) any later version.
 *
 *  This program is distributed in the hope that it will be useful,
 *  but WITHOUT ANY WARRANTY; without even the implied warranty of
 *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 *  GNU Affero General Public License for more details.
 *
 *  You should have received a copy of the GNU Affero General Public License
 *  along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

namespace SURFnet\VPN\Server\Tests\Acl\Provider;

use DateTime;
use fkooman\OAuth\Client\AccessToken;
use fkooman\OAuth\Client\Http\Response;
use fkooman\OAuth\Client\OAuthClient;
use fkooman\OAuth\Client\Provider;
use PDO;
use PHPUnit_Framework_TestCase;
use SURFnet\VPN\Server\Acl\Provider\VootProvider;
use SURFnet\VPN\Server\Storage;

class VootProviderTest extends PHPUnit_Framework_TestCase
{
    /** @var VootProvider */
    private $vootProvider;

    public function setUp()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $vootClient = $this->getMockBuilder('\fkooman\OAuth\Client\Http\HttpClientInterface')->getMock();
        $vootClient->method('send')->will(
            $this->onConsecutiveCalls(
                new Response(200, file_get_contents(sprintf('%s/data/response.json', __DIR__)), ['Content-Type' => 'application/json']),
                new Response(401, file_get_contents(sprintf('%s/data/response_invalid_token.json', __DIR__)), ['Content-Type' => 'application/json'])
            )
        );

        $storage = new Storage(
            new PDO(
                $GLOBALS['DB_DSN'],
                $GLOBALS['DB_USER'],
                $GLOBALS['DB_PASSWD']
            ),
            new DateTime()
        );
        $storage->init();
//        $storage->setAccessToken('foo', 'voot', new AccessToken('AT', 'bearer', 'groups', 'RT', new DateTime('2016-01-02')));

        $storage->setAccessToken(
            'foo',
            'voot',
            AccessToken::fromStorage(
                json_encode([
                    'access_token' => 'AT',
                    'token_type' => 'bearer',
                    'scope' => 'groups',
                    'refresh_token' => 'RT',
                    'expires_in' => 3600,
                    'issued_at' => '2016-01-02 00:00:00',
                ])
            )
        );

        $random = $this->getMockBuilder('fkooman\OAuth\Client\RandomInterface')->getMock();
        $random->method('get')->will($this->onConsecutiveCalls('random_1', 'random_2'));

        $oauthClient = new OAuthClient(
            $storage,
            $vootClient
        );
        $oauthClient->addProvider('voot', new Provider('a', 'b', 'c', 'd'));
        $oauthClient->setRandom($random);
        $oauthClient->setDateTime(new DateTime('2016-01-01'));

        $this->vootProvider = new VootProvider(
            $oauthClient,
            'https://voot.surfconext.nl/me/groups'
        );
    }

    public function testVootCall()
    {
        $this->assertSame(
            [
                [
                    'id' => 'urn:collab:group:surfteams.nl:nl:surfnet:diensten:eduvpn',
                    'displayName' => 'EduVPN',
                ],
                [
                    'id' => 'urn:collab:group:surfteams.nl:nl:surfnet:diensten:eduvpn-test',
                    'displayName' => 'eduVPN-test',
                ],
                [
                    'id' => 'urn:collab:group:surfteams.nl:nl:surfnet:diensten:enabling_dynamic_services_2015',
                    'displayName' => 'Enabling Dynamic Services 2015',
                ],
                [
                    'id' => 'urn:collab:group:surfteams.nl:nl:surfnet:diensten:surfcloud_utrecht_users',
                    'displayName' => 'SURFcloud Utrecht users',
                ],
            ],
            $this->vootProvider->getGroups('foo')
        );
    }

    public function testVootCallNoToken()
    {
        $this->assertSame(
            [
            ],
            $this->vootProvider->getGroups('bar')
        );
    }

    public function testVootCallInvalidToken()
    {
        // first call succeeds, second call is invalid token response
        $this->vootProvider->getGroups('foo');
        $this->assertSame(
            [
            ],
            $this->vootProvider->getGroups('foo')
        );
    }
}


1			<?php
2			/**
3			* Copyright (C) 2016 SURFnet.
4			*
5			* This program is free software: you can redistribute it and/or modify
6			* it under the terms of the GNU Affero General Public License as
7			* published by the Free Software Foundation, either version 3 of the
8			* License, or (at your option) any later version.
9			*
10			* This program is distributed in the hope that it will be useful,
11			* but WITHOUT ANY WARRANTY; without even the implied warranty of
12			* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13			* GNU Affero General Public License for more details.
14			*
15			* You should have received a copy of the GNU Affero General Public License
16			* along with this program. If not, see <http://www.gnu.org/licenses/>.
17			*/
18
19			namespace SURFnet\VPN\Server\Tests\Acl\Provider;
20
21			use DateTime;
22			use fkooman\OAuth\Client\AccessToken;
23			use fkooman\OAuth\Client\Http\Response;
24			use fkooman\OAuth\Client\OAuthClient;
25			use fkooman\OAuth\Client\Provider;
26			use PDO;
27			use PHPUnit_Framework_TestCase;
28			use SURFnet\VPN\Server\Acl\Provider\VootProvider;
29			use SURFnet\VPN\Server\Storage;
30
31			class VootProviderTest extends PHPUnit_Framework_TestCase
32			{
33			/** @var VootProvider */
34			private $vootProvider;
35
36			public function setUp()
			0 ignored issues – show Coding Style introduced 2016-12-22 13:49 UTC by Report Bug Copy Issue Report `setUp` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
37			{
38			$vootClient = $this->getMockBuilder('\fkooman\OAuth\Client\Http\HttpClientInterface')->getMock();
39			$vootClient->method('send')->will(
40			$this->onConsecutiveCalls(
41			new Response(200, file_get_contents(sprintf('%s/data/response.json', __DIR__)), ['Content-Type' => 'application/json']),
42			new Response(401, file_get_contents(sprintf('%s/data/response_invalid_token.json', __DIR__)), ['Content-Type' => 'application/json'])
43			)
44			);
45
46			$storage = new Storage(
47			new PDO(
48			$GLOBALS['DB_DSN'],
49			$GLOBALS['DB_USER'],
50			$GLOBALS['DB_PASSWD']
51			),
52			new DateTime()
53			);
54			$storage->init();
55			// $storage->setAccessToken('foo', 'voot', new AccessToken('AT', 'bearer', 'groups', 'RT', new DateTime('2016-01-02')));
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-09 11:56 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
56			$storage->setAccessToken(
57			'foo',
58			'voot',
59			AccessToken::fromStorage(
60			json_encode([
61			'access_token' => 'AT',
62			'token_type' => 'bearer',
63			'scope' => 'groups',
64			'refresh_token' => 'RT',
65			'expires_in' => 3600,
66			'issued_at' => '2016-01-02 00:00:00',
67			])
68			)
69			);
70
71			$random = $this->getMockBuilder('fkooman\OAuth\Client\RandomInterface')->getMock();
72			$random->method('get')->will($this->onConsecutiveCalls('random_1', 'random_2'));
73
74			$oauthClient = new OAuthClient(
75			$storage,
76			$vootClient
77			);
78			$oauthClient->addProvider('voot', new Provider('a', 'b', 'c', 'd'));
79			$oauthClient->setRandom($random);
80			$oauthClient->setDateTime(new DateTime('2016-01-01'));
81
82			$this->vootProvider = new VootProvider(
83			$oauthClient,
84			'https://voot.surfconext.nl/me/groups'
85			);
86			}
87
88			public function testVootCall()
89			{
90			$this->assertSame(
91			[
92			[
93			'id' => 'urn:collab:group:surfteams.nl:nl:surfnet:diensten:eduvpn',
94			'displayName' => 'EduVPN',
95			],
96			[
97			'id' => 'urn:collab:group:surfteams.nl:nl:surfnet:diensten:eduvpn-test',
98			'displayName' => 'eduVPN-test',
99			],
100			[
101			'id' => 'urn:collab:group:surfteams.nl:nl:surfnet:diensten:enabling_dynamic_services_2015',
102			'displayName' => 'Enabling Dynamic Services 2015',
103			],
104			[
105			'id' => 'urn:collab:group:surfteams.nl:nl:surfnet:diensten:surfcloud_utrecht_users',
106			'displayName' => 'SURFcloud Utrecht users',
107			],
108			],
109			$this->vootProvider->getGroups('foo')
110			);
111			}
112
113			public function testVootCallNoToken()
114			{
115			$this->assertSame(
116			[
117			],
118			$this->vootProvider->getGroups('bar')
119			);
120			}
121
122			public function testVootCallInvalidToken()
123			{
124			// first call succeeds, second call is invalid token response
125			$this->vootProvider->getGroups('foo');
126			$this->assertSame(
127			[
128			],
129			$this->vootProvider->getGroups('foo')
130			);
131			}
132			}
133

eduVPN / vpn-server-api

GitHub Access Token became invalid

Push — master ( 70617b...52097e )

VootProviderTest::setUp() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like