fkooman\VPN\Server\Config\ConfigModule

Complexity

Total Complexity

8

Size/Duplication

Total Lines	137
Duplicated Lines	37.23 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
C	init()	51	126	7

<?php
/**
 * Copyright 2015 François Kooman <fkooman@tuxed.net>.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */
namespace fkooman\VPN\Server\Config;

use fkooman\Http\Request;
use fkooman\Rest\Service;
use fkooman\Rest\ServiceModuleInterface;
use fkooman\VPN\Server\Utils;
use fkooman\Rest\Plugin\Authentication\UserInfoInterface;
use fkooman\Http\JsonResponse;
use fkooman\Http\Exception\BadRequestException;

class ConfigModule implements ServiceModuleInterface
{
    /** @var StaticConfig */
    private $staticConfig;

    public function __construct(StaticConfig $staticConfig)
    {
        $this->staticConfig = $staticConfig;
    }

    public function init(Service $service)
    {
        $service->get(
            '/static/ip',
           function (Request $request, UserInfoInterface $userInfo) {

The parameter $userInfo is not used and could be removed.

                // we typically deal with CNs, not user IDs, but the part of 
                // the CN before the first '_' is considered the user ID
                $userId = $request->getUrl()->getQueryParameter('user_id');
                $commonName = $request->getUrl()->getQueryParameter('common_name');
                if (!is_null($userId)) {
                    // per user
                    Utils::validateUserId($userId);
                    $ipConfig = $this->staticConfig->getStaticAddresses($userId);
                } elseif (!is_null($commonName)) {
                    // per CN
                    Utils::validateCommonName($commonName);
                    $ipConfig = $this->staticConfig->getStaticAddress($commonName);
                } else {
                    // all
                    $ipConfig = $this->staticConfig->getStaticAddresses();
                }

                $response = new JsonResponse();
                $response->setBody(
                    array(
                        'ok' => true,
                        'ip' => $ipConfig,
                        'ipRange' => $this->staticConfig->getIpRange()->getRange(),
                        'poolRange' => $this->staticConfig->getPoolRange()->getRange(),
                    )
                );

                return $response;
            }
        );

        $service->post(
            '/static/ip',
           function (Request $request, UserInfoInterface $userInfo) {

The parameter $userInfo is not used and could be removed.

                $commonName = $request->getPostParameter('common_name');
                if (is_null($commonName)) {
                    throw new BadRequestException('missing common_name');
                }
                Utils::validateCommonName($commonName);

                $v4 = $request->getPostParameter('v4');
                if (empty($v4)) {
                    $v4 = null;
                }

                $response = new JsonResponse();
                $response->setBody(
                    array(
                        'ok' => $this->staticConfig->setStaticAddresses($commonName, $v4),
                    )
                );

                // $this->logInfo('setting static IP', array('api_user' => $userInfo->getUserId(), 'cn' => $commonName, 'v4' => $v4));

67% of this comment could be valid code. Did you maybe forget this after debugging?

                return $response;
            }
        );

        $service->post(
            '/ccd/disable',
            function (Request $request, UserInfoInterface $userInfo) {

The parameter $userInfo is not used and could be removed.

This code seems to be duplicated across your project.

                $commonName = $request->getPostParameter('common_name');
                if (is_null($commonName)) {
                    throw new BadRequestException('missing common_name');
                }
                Utils::validateCommonName($commonName);

                // $this->logInfo('disabling cn', array('api_user' => $userInfo->getUserId(), 'cn' => $commonName));

69% of this comment could be valid code. Did you maybe forget this after debugging?

                $response = new JsonResponse();
                $response->setBody(
                    array(
                        'ok' => $this->staticConfig->disableCommonName($commonName),
                    )
                );

                return $response;
            }
        );

        $service->delete(
            '/ccd/disable',
            function (Request $request, UserInfoInterface $userInfo) {

The parameter $userInfo is not used and could be removed.

This code seems to be duplicated across your project.

                $commonName = $request->getUrl()->getQueryParameter('common_name');
                Utils::validateCommonName($commonName);

                // $this->logInfo('enabling cn', array('api_user' => $userInfo->getUserId(), 'cn' => $commonName));

69% of this comment could be valid code. Did you maybe forget this after debugging?

                $response = new JsonResponse();
                $response->setBody(
                    array(
                        'ok' => $this->staticConfig->enableCommonName($commonName),
                    )
                );

                return $response;
            }
        );

        $service->get(
            '/ccd/disable',
            function (Request $request, UserInfoInterface $userInfo) {

The parameter $userInfo is not used and could be removed.

This code seems to be duplicated across your project.

                // we typically deal with CNs, not user IDs, but the part of 
                // the CN before the first '_' is considered the user ID
                $userId = $request->getUrl()->getQueryParameter('user_id');
                if (!is_null($userId)) {
                    Utils::validateUserId($userId);
                }

                $response = new JsonResponse();
                $response->setBody(
                    array(
                        'ok' => true,
                        'disabled' => $this->staticConfig->getDisabledCommonNames($userId),
                    )
                );

                return $response;
            }
        );
    }
}