UserConfig::getOtpSecret() - Code Metrics - Inspection of "- refactor storing common name and user configurat..." - eduVPN/vpn-server-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a07628...6a1128 )

by François

created 2016-04-22 13:57 UTC

UserConfig::getOtpSecret() A

↳ Parent: UserConfig

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	0

<?php
/**
 * Copyright 2015 François Kooman <[email protected]>.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace fkooman\VPN\Server\Config;

use fkooman\VPN\Server\InputValidation;

class UserConfig
{
    /** @var bool */
    private $disable;

    /** @var string|false */
    private $otpSecret;

    public function __construct(array $configData)
    {
        $disable = array_key_exists('disable', $configData) ? $configData['disable'] : false;
        InputValidation::disable($disable);
        $this->disable = $disable;

        $disable = array_key_exists('otpSecret', $configData) ? $configData['otpSecret'] : false;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        // XXX: InputValidation::otpSecret($otpSecret);

        $this->otpSecret = $otpSecret;

    }

    public function getDisable()
    {
        return $this->disable;
    }

    public function getOtpSecret()
    {
        return $this->otpSecret;
    }

    public function toArray()
    {
        return [
            'disable' => $this->disable,
            'otpSecret' => $this->otpSecret,
        ];
    }
}


1			<?php
2			/**
3			* Copyright 2015 François Kooman <[email protected]>.
4			*
5			* Licensed under the Apache License, Version 2.0 (the "License");
6			* you may not use this file except in compliance with the License.
7			* You may obtain a copy of the License at
8			*
9			* http://www.apache.org/licenses/LICENSE-2.0
10			*
11			* Unless required by applicable law or agreed to in writing, software
12			* distributed under the License is distributed on an "AS IS" BASIS,
13			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14			* See the License for the specific language governing permissions and
15			* limitations under the License.
16			*/
17
18			namespace fkooman\VPN\Server\Config;
19
20			use fkooman\VPN\Server\InputValidation;
21
22			class UserConfig
23			{
24			/** @var bool */
25			private $disable;
26
27			/** @var string\|false */
28			private $otpSecret;
29
30			public function __construct(array $configData)
31			{
32			$disable = array_key_exists('disable', $configData) ? $configData['disable'] : false;
33			InputValidation::disable($disable);
34			$this->disable = $disable;
35
36			$disable = array_key_exists('otpSecret', $configData) ? $configData['otpSecret'] : false;
			0 ignored issues – show Unused Code introduced 2016-04-22 14:01 UTC by Report Bug Copy Issue Report `$disable` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
37			// XXX: InputValidation::otpSecret($otpSecret);
			0 ignored issues – show Unused Code Comprehensibility introduced 2016-04-22 14:01 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
38			$this->otpSecret = $otpSecret;
			0 ignored issues – show Bug introduced 2016-04-22 14:01 UTC by Report Bug Copy Issue Report The variable `$otpSecret` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
39			}
40
41			public function getDisable()
42			{
43			return $this->disable;
44			}
45
46			public function getOtpSecret()
47			{
48			return $this->otpSecret;
49			}
50
51			public function toArray()
52			{
53			return [
54			'disable' => $this->disable,
55			'otpSecret' => $this->otpSecret,
56			];
57			}
58			}
59

eduVPN / vpn-server-api

GitHub Access Token became invalid

Push — master ( a07628...6a1128 )

UserConfig::getOtpSecret() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like