VootToken::__construct() - Code Metrics - Inspection of "implement VootAcl backend" - eduVPN/vpn-server-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 00c2b4...ff24ee )

by François

created 2016-05-27 15:11 UTC

VootToken::__construct() A

↳ Parent: VootToken

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	8
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	8
loc	8
rs	9.4285
cc	2
eloc	5
nc	2
nop	2

<?php
/**
 * Copyright 2016 François Kooman <[email protected]>.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

namespace fkooman\VPN\Server;

use fkooman\IO\IOInterface;
use fkooman\IO\IO;

class VootToken
{
    /** @var string */
    private $configDir;

    /** @var \fkooman\IO\IOInterface */
    private $io;

    public function __construct($configDir, IOInterface $io = null)

    {
        $this->configDir = $configDir;
        if (is_null($io)) {
            $io = new IO();
        }
        $this->io = $io;
    }

    /**
     * Check whether a particular user has a VOOT token set.
     */
    public function getVootToken($userId)

    {
        $vootTokenFile = sprintf('%s/%s', $this->configDir, $userId);

        if ($this->io->isFile($vootTokenFile)) {
            return $this->io->readFile($vootTokenFile);
        }

        return false;
    }

    /**
     * Set or delete the VOOT token for a particular user.
     */
    public function setVootToken($userId, $vootToken)

    {
        $vootTokenFile = sprintf('%s/%s', $this->configDir, $userId);

        if (false === $vootToken) {
            // remove the token
            if ($this->io->isFile($vootTokenFile)) {
                $this->io->deleteFile($vootTokenFile);

                return true;
            }

            return false;
        }

        // set the token, if it is already set override
        $this->io->writeFile($vootTokenFile, $vootToken, true);
if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) {
    throw new \InvalidArgumentException('This input is not allowed.');
}

        return true;
    }
}


1		<?php
2		/**
3		* Copyright 2016 François Kooman <[email protected]>.
4		*
5		* Licensed under the Apache License, Version 2.0 (the "License");
6		* you may not use this file except in compliance with the License.
7		* You may obtain a copy of the License at
8		*
9		* http://www.apache.org/licenses/LICENSE-2.0
10		*
11		* Unless required by applicable law or agreed to in writing, software
12		* distributed under the License is distributed on an "AS IS" BASIS,
13		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
14		* See the License for the specific language governing permissions and
15		* limitations under the License.
16		*/
17
18		namespace fkooman\VPN\Server;
19
20		use fkooman\IO\IOInterface;
21		use fkooman\IO\IO;
22
23		class VootToken
24		{
25		/** @var string */
26		private $configDir;
27
28		/** @var \fkooman\IO\IOInterface */
29		private $io;
30
31	View Code Duplication	public function __construct($configDir, IOInterface $io = null)
		0 ignored issues – show Duplication introduced 2016-05-27 15:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
32		{
33		$this->configDir = $configDir;
34		if (is_null($io)) {
35		$io = new IO();
36		}
37		$this->io = $io;
38		}
39
40		/**
41		* Check whether a particular user has a VOOT token set.
42		*/
43	View Code Duplication	public function getVootToken($userId)
		0 ignored issues – show Duplication introduced 2016-05-27 15:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		{
45		$vootTokenFile = sprintf('%s/%s', $this->configDir, $userId);
46
47		if ($this->io->isFile($vootTokenFile)) {
48		return $this->io->readFile($vootTokenFile);
49		}
50
51		return false;
52		}
53
54		/**
55		* Set or delete the VOOT token for a particular user.
56		*/
57	View Code Duplication	public function setVootToken($userId, $vootToken)
		0 ignored issues – show Duplication introduced 2016-05-27 15:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58		{
59		$vootTokenFile = sprintf('%s/%s', $this->configDir, $userId);
60
61		if (false === $vootToken) {
62		// remove the token
63		if ($this->io->isFile($vootTokenFile)) {
64		$this->io->deleteFile($vootTokenFile);
65
66		return true;
67		}
68
69		return false;
70		}
71
72		// set the token, if it is already set override
73		$this->io->writeFile($vootTokenFile, $vootToken, true);
		0 ignored issues – show Security File Manipulation introduced 2016-05-27 15:14 UTC by Report Bug Copy Issue Report `$vootToken` can contain request data and is used in file manipulation context(s) leading to a potential security vulnerability. General Strategies to prevent injection In general, it is advisable to prevent any user-data to reach this point. This can be done by white-listing certain values: if ( ! in_array($value, array('this-is-allowed', 'and-this-too'), true)) { throw new \InvalidArgumentException('This input is not allowed.'); } For numeric data, we recommend to explicitly cast the data: $sanitized = (integer) $tainted; Loading history...
74
75		return true;
76		}
77		}
78

eduVPN / vpn-server-api

GitHub Access Token became invalid

Push — master ( 00c2b4...ff24ee )

VootToken::__construct() A

Complexity

Size

Duplication

Importance

General Strategies to prevent injection

Duplication Side-by-Side

Filter issues like