TotpTest::setUp() - Code Metrics - eduVPN/vpn-server-api - Measure and Improve Code Quality continuously with Scrutinizer

TotpTest::setUp() A
last analyzed 2017-07-23 14:51 UTC

↳ Parent: TotpTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	0

<?php

/**
 * eduVPN - End-user friendly VPN.
 *
 * Copyright: 2016-2017, The Commons Conservancy eduVPN Programme
 * SPDX-License-Identifier: AGPL-3.0+
 */

namespace SURFnet\VPN\Server\Tests;

use DateTime;
use PDO;
use PHPUnit_Framework_TestCase;
use SURFnet\VPN\Server\Exception\TotpException;
use SURFnet\VPN\Server\Storage;
use SURFnet\VPN\Server\Totp;

class TotpTest extends PHPUnit_Framework_TestCase
{
    /** @var Totp */
    private $totp;

    public function setUp()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $storage = new Storage(
            new PDO(
                $GLOBALS['DB_DSN'],
                $GLOBALS['DB_USER'],
                $GLOBALS['DB_PASSWD']
            ),
            new DateTime()
        );
        $storage->init();
        $storage->setTotpSecret('foo', 'CN2XAL23SIFTDFXZ');

        $this->totp = new Totp($storage);
    }

    /**
     * @expectedException \SURFnet\VPN\Server\Exception\TotpException
     * @expectedExceptionMessage too many attempts at TOTP
     */
    public function testTooManyReplays()
    {
        for ($i = 0; $i < 10; ++$i) {
            try {
                $this->totp->verify('foo', (string) 123456 + $i);
            } catch (TotpException $e) {
                $this->assertSame('invalid TOTP key', $e->getMessage());
            }
        }
        $this->totp->verify('foo', '555555');
    }
}


1			<?php
2
3			/**
4			* eduVPN - End-user friendly VPN.
5			*
6			* Copyright: 2016-2017, The Commons Conservancy eduVPN Programme
7			* SPDX-License-Identifier: AGPL-3.0+
8			*/
9
10			namespace SURFnet\VPN\Server\Tests;
11
12			use DateTime;
13			use PDO;
14			use PHPUnit_Framework_TestCase;
15			use SURFnet\VPN\Server\Exception\TotpException;
16			use SURFnet\VPN\Server\Storage;
17			use SURFnet\VPN\Server\Totp;
18
19			class TotpTest extends PHPUnit_Framework_TestCase
20			{
21			/** @var Totp */
22			private $totp;
23
24			public function setUp()
			0 ignored issues – show Coding Style introduced 2017-04-21 17:27 UTC by Report Bug Copy Issue Report `setUp` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
25			{
26			$storage = new Storage(
27			new PDO(
28			$GLOBALS['DB_DSN'],
29			$GLOBALS['DB_USER'],
30			$GLOBALS['DB_PASSWD']
31			),
32			new DateTime()
33			);
34			$storage->init();
35			$storage->setTotpSecret('foo', 'CN2XAL23SIFTDFXZ');
36
37			$this->totp = new Totp($storage);
38			}
39
40			/**
41			* @expectedException \SURFnet\VPN\Server\Exception\TotpException
42			* @expectedExceptionMessage too many attempts at TOTP
43			*/
44			public function testTooManyReplays()
45			{
46			for ($i = 0; $i < 10; ++$i) {
47			try {
48			$this->totp->verify('foo', (string) 123456 + $i);
49			} catch (TotpException $e) {
50			$this->assertSame('invalid TOTP key', $e->getMessage());
51			}
52			}
53			$this->totp->verify('foo', '555555');
54			}
55			}
56

eduVPN / vpn-server-api

GitHub Access Token became invalid

TotpTest::setUp() A last analyzed 2017-07-23 14:51 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

TotpTest::setUp() A
last analyzed 2017-07-23 14:51 UTC