VootProviderTest - Code Metrics - eduVPN/vpn-server-api - Measure and Improve Code Quality continuously with Scrutinizer

VootProviderTest A
last analyzed 2017-07-23 14:51 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	100
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	10

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	10
dl	0
loc	100
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	setUp()	49	1
B	testVootCall()	24	1
A	testVootCallNoToken()	8	1
A	testVootCallInvalidToken()	10	1

<?php

/**
 * eduVPN - End-user friendly VPN.
 *
 * Copyright: 2016-2017, The Commons Conservancy eduVPN Programme
 * SPDX-License-Identifier: AGPL-3.0+
 */

namespace SURFnet\VPN\Server\Tests\Acl\Provider;

use DateTime;
use fkooman\OAuth\Client\AccessToken;
use fkooman\OAuth\Client\Http\Response;
use fkooman\OAuth\Client\OAuthClient;
use fkooman\OAuth\Client\Provider;
use PDO;
use PHPUnit_Framework_TestCase;
use SURFnet\VPN\Server\Acl\Provider\VootProvider;
use SURFnet\VPN\Server\Storage;
use SURFnet\VPN\Server\Tests\TestOAuthClientRandom;
use SURFnet\VPN\Server\Tests\TestOAuthClientSession;

class VootProviderTest extends PHPUnit_Framework_TestCase
{
    /** @var VootProvider */
    private $vootProvider;

    public function setUp()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $vootClient = $this->getMockBuilder('\fkooman\OAuth\Client\Http\HttpClientInterface')->getMock();
        $vootClient->method('send')->will(
            $this->onConsecutiveCalls(
                new Response(200, file_get_contents(sprintf('%s/data/response.json', __DIR__)), ['Content-Type' => 'application/json']),
                new Response(401, file_get_contents(sprintf('%s/data/response_invalid_token.json', __DIR__)), ['Content-Type' => 'application/json'])
            )
        );

        $storage = new Storage(
            new PDO(
                $GLOBALS['DB_DSN'],
                $GLOBALS['DB_USER'],
                $GLOBALS['DB_PASSWD']
            ),
            new DateTime()
        );
        $storage->init();
//        $storage->setAccessToken('foo', 'voot', new AccessToken('AT', 'bearer', 'groups', 'RT', new DateTime('2016-01-02')));

        $storage->storeAccessToken(
            'foo',
            AccessToken::fromJson(
                json_encode([
                    'provider_id' => 'c|a',
                    'user_id' => 'foo',
                    'access_token' => 'AT',
                    'token_type' => 'bearer',
                    'scope' => 'groups',
                    'refresh_token' => 'RT',
                    'expires_in' => 3600,
                    'issued_at' => '2016-01-02 00:00:00',
                ])
            )
        );

        $oauthClient = new OAuthClient(
            $storage,
            $vootClient,
            new TestOAuthClientSession(),
            new TestOAuthClientRandom(),
            new DateTime('2016-01-01')
        );
        $oauthClient->setProvider(new Provider('a', 'b', 'c', 'd'));
        $this->vootProvider = new VootProvider(
            $oauthClient,
            'https://voot.surfconext.nl/me/groups'
        );
    }

    public function testVootCall()
    {
        $this->assertSame(
            [
                [
                    'id' => 'urn:collab:group:surfteams.nl:nl:surfnet:diensten:eduvpn',
                    'displayName' => 'EduVPN',
                ],
                [
                    'id' => 'urn:collab:group:surfteams.nl:nl:surfnet:diensten:eduvpn-test',
                    'displayName' => 'eduVPN-test',
                ],
                [
                    'id' => 'urn:collab:group:surfteams.nl:nl:surfnet:diensten:enabling_dynamic_services_2015',
                    'displayName' => 'Enabling Dynamic Services 2015',
                ],
                [
                    'id' => 'urn:collab:group:surfteams.nl:nl:surfnet:diensten:surfcloud_utrecht_users',
                    'displayName' => 'SURFcloud Utrecht users',
                ],
            ],
            $this->vootProvider->getGroups('foo')
        );
    }

    public function testVootCallNoToken()
    {
        $this->assertSame(
            [
            ],
            $this->vootProvider->getGroups('bar')
        );
    }

    public function testVootCallInvalidToken()
    {
        // first call succeeds, second call is invalid token response
        $this->vootProvider->getGroups('foo');
        $this->assertSame(
            [
            ],
            $this->vootProvider->getGroups('foo')
        );
    }
}


1			<?php
2
3			/**
4			* eduVPN - End-user friendly VPN.
5			*
6			* Copyright: 2016-2017, The Commons Conservancy eduVPN Programme
7			* SPDX-License-Identifier: AGPL-3.0+
8			*/
9
10			namespace SURFnet\VPN\Server\Tests\Acl\Provider;
11
12			use DateTime;
13			use fkooman\OAuth\Client\AccessToken;
14			use fkooman\OAuth\Client\Http\Response;
15			use fkooman\OAuth\Client\OAuthClient;
16			use fkooman\OAuth\Client\Provider;
17			use PDO;
18			use PHPUnit_Framework_TestCase;
19			use SURFnet\VPN\Server\Acl\Provider\VootProvider;
20			use SURFnet\VPN\Server\Storage;
21			use SURFnet\VPN\Server\Tests\TestOAuthClientRandom;
22			use SURFnet\VPN\Server\Tests\TestOAuthClientSession;
23
24			class VootProviderTest extends PHPUnit_Framework_TestCase
25			{
26			/** @var VootProvider */
27			private $vootProvider;
28
29			public function setUp()
			0 ignored issues – show Coding Style introduced 2016-12-22 13:49 UTC by Report Bug Copy Issue Report `setUp` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
30			{
31			$vootClient = $this->getMockBuilder('\fkooman\OAuth\Client\Http\HttpClientInterface')->getMock();
32			$vootClient->method('send')->will(
33			$this->onConsecutiveCalls(
34			new Response(200, file_get_contents(sprintf('%s/data/response.json', __DIR__)), ['Content-Type' => 'application/json']),
35			new Response(401, file_get_contents(sprintf('%s/data/response_invalid_token.json', __DIR__)), ['Content-Type' => 'application/json'])
36			)
37			);
38
39			$storage = new Storage(
40			new PDO(
41			$GLOBALS['DB_DSN'],
42			$GLOBALS['DB_USER'],
43			$GLOBALS['DB_PASSWD']
44			),
45			new DateTime()
46			);
47			$storage->init();
48			// $storage->setAccessToken('foo', 'voot', new AccessToken('AT', 'bearer', 'groups', 'RT', new DateTime('2016-01-02')));
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-05-09 11:56 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
49			$storage->storeAccessToken(
50			'foo',
51			AccessToken::fromJson(
52			json_encode([
53			'provider_id' => 'c\|a',
54			'user_id' => 'foo',
55			'access_token' => 'AT',
56			'token_type' => 'bearer',
57			'scope' => 'groups',
58			'refresh_token' => 'RT',
59			'expires_in' => 3600,
60			'issued_at' => '2016-01-02 00:00:00',
61			])
62			)
63			);
64
65			$oauthClient = new OAuthClient(
66			$storage,
67			$vootClient,
68			new TestOAuthClientSession(),
69			new TestOAuthClientRandom(),
70			new DateTime('2016-01-01')
71			);
72			$oauthClient->setProvider(new Provider('a', 'b', 'c', 'd'));
73			$this->vootProvider = new VootProvider(
74			$oauthClient,
75			'https://voot.surfconext.nl/me/groups'
76			);
77			}
78
79			public function testVootCall()
80			{
81			$this->assertSame(
82			[
83			[
84			'id' => 'urn:collab:group:surfteams.nl:nl:surfnet:diensten:eduvpn',
85			'displayName' => 'EduVPN',
86			],
87			[
88			'id' => 'urn:collab:group:surfteams.nl:nl:surfnet:diensten:eduvpn-test',
89			'displayName' => 'eduVPN-test',
90			],
91			[
92			'id' => 'urn:collab:group:surfteams.nl:nl:surfnet:diensten:enabling_dynamic_services_2015',
93			'displayName' => 'Enabling Dynamic Services 2015',
94			],
95			[
96			'id' => 'urn:collab:group:surfteams.nl:nl:surfnet:diensten:surfcloud_utrecht_users',
97			'displayName' => 'SURFcloud Utrecht users',
98			],
99			],
100			$this->vootProvider->getGroups('foo')
101			);
102			}
103
104			public function testVootCallNoToken()
105			{
106			$this->assertSame(
107			[
108			],
109			$this->vootProvider->getGroups('bar')
110			);
111			}
112
113			public function testVootCallInvalidToken()
114			{
115			// first call succeeds, second call is invalid token response
116			$this->vootProvider->getGroups('foo');
117			$this->assertSame(
118			[
119			],
120			$this->vootProvider->getGroups('foo')
121			);
122			}
123			}
124

eduVPN / vpn-server-api

GitHub Access Token became invalid

VootProviderTest A last analyzed 2017-07-23 14:51 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Duplication Side-by-Side

Filter issues like

VootProviderTest A
last analyzed 2017-07-23 14:51 UTC