Inspection of "Remove magic numbers from Group controller" - edno/kleis - Measure and Improve Code Quality continuously with Scrutinizer

kleis

Completed

Push — develop ( 07098b...f03e4a )

by Greg

created 2019-03-09 22:19 UTC

Status

All Patches
45
New
2

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -101,7 +101,7 @@
 block discarded – undo
     {
         $group = Group::findOrFail($id);
         $accounts = Group::Find($id)->accounts()->where('status', Account::ACCOUNT_DISABLE);
-        if (count($accounts) > 0 ) {
+        if (count($accounts) > 0) {
             $accounts->delete();
         }
         return redirect()->back()->with(

Please login to merge, or discard this patch.

		@@ -101,7 +101,7 @@
		block discarded – undo
101	101	{
102	102	$group = Group::findOrFail($id);
103	103	$accounts = Group::Find($id)->accounts()->where('status', Account::ACCOUNT_DISABLE);
104		- if (count($accounts) > 0 ) {
	104	+ if (count($accounts) > 0) {
105	105	$accounts->delete();
106	106	}
107	107	return redirect()->back()->with(

edno / kleis

Push — develop ( 07098b...f03e4a )

Status

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch