ExportAccountsTrait::exportAccount() - Code Metrics - Inspection of "Refactor export account into trait method :recycle..." - edno/kleis - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 957723...53a684 )

by Greg

created 2019-03-10 08:32 UTC

ExportAccountsTrait::exportAccount() B

↳ Parent: ExportAccountsTrait

Complexity

Conditions	6
Paths	20

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	26
rs	8.8817
c	0
b	0
f	0
cc	6
nc	20
nop	4

<?php

namespace App\Console\Commands\Traits;

trait ExportAccountsTrait
{
    public function exportAccount($accounts, $filename, $password = false, $flagCI = false)
    {
        $this->storage->put($filename, '');
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $count = count($accounts);

        if ($flagCI === false) {
          $bar = $this->output->createProgressBar($count);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        }

        foreach ($accounts as $account) {
            $record = "{$account->netlogin}";
            $record .= $password ? ":{$account->netpass}" : '';
            $this->storage->prepend($filename, $record);
            if (isset($bar)) {
              $bar->advance();
            }
        }

        if (isset($bar)) {
          $bar->finish();
          $this->info("\n");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }

        return $count;
    }
}


1			<?php
2
3			namespace App\Console\Commands\Traits;
4
5			trait ExportAccountsTrait
6			{
7			public function exportAccount($accounts, $filename, $password = false, $flagCI = false)
8			{
9			$this->storage->put($filename, '');
			0 ignored issues – show Bug introduced 2019-03-10 08:34 UTC by Report Bug Copy Issue Report The property `storage` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
10
11			$count = count($accounts);
12
13			if ($flagCI === false) {
14			$bar = $this->output->createProgressBar($count);
			0 ignored issues – show Bug introduced 2019-03-10 08:34 UTC by Report Bug Copy Issue Report The property `output` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
15			}
16
17			foreach ($accounts as $account) {
18			$record = "{$account->netlogin}";
19			$record .= $password ? ":{$account->netpass}" : '';
20			$this->storage->prepend($filename, $record);
21			if (isset($bar)) {
22			$bar->advance();
23			}
24			}
25
26			if (isset($bar)) {
27			$bar->finish();
28			$this->info("\n");
			0 ignored issues – show Bug introduced 2019-03-10 08:34 UTC by Report Bug Copy Issue Report It seems like `info()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29			}
30
31			return $count;
32			}
33			}
34

edno / kleis

Push — develop ( 957723...53a684 )

ExportAccountsTrait::exportAccount() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like