AccountController::editAccount() - Code Metrics - edno/kleis - Measure and Improve Code Quality continuously with Scrutinizer

AccountController::editAccount() A
last analyzed 2019-08-20 11:53 UTC

↳ Parent: Project

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.7333
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace App\Http\Controllers;

use Illuminate\Http\Request;
use App\Account;
use App\Group;
use App\Category;
use Auth;

class AccountController extends Controller
{
    use SearchTrait;

    /**
     * Create a new controller instance.
     *
     * @return void

     */
    public function __construct()
    {
        $this->middleware('auth');
    }

    /**
     * List existing accounts
     *
     * @return Response
     */
    public function showAccounts(Request $request, $group_id = null, $category_id = null)
    {
        $accounts = Account::orderBy('netlogin', 'asc');
        $group = null;

        // because request routing is not smart
        if ($request->is('accounts/category/*')) {
            $category_id = $group_id;
            $group_id = null;
        }

        // case when admin can only manager its own group§
        if (Auth::user()->level == 1) {
            $group_id = Auth::user()->group->id;
        }

        // if a group filter is set
        if (false === is_null($group_id)) {
            $group = Group::find($group_id);
            $accounts = $accounts->where('group_id', $group_id);
        }

        // if a category filter is set
        if (false === is_null($category_id)) {
            $accounts = $accounts->where('category_id', $category_id);
        }

        $results = $this->search($accounts, $request->input('type'), $request->input('search'));

        // store search criteria
        if (false === is_null($results)) {
            $request->session()->flash(
                'results',
                trans_choice(
                    'accounts.message.search',
                    $results,
                    ['number' => $results]
                )
            );
            $request->session()->flash('search', $request->input('search'));
            $request->session()->flash('type', $request->input('type'));
        }

        return view('account/accounts',
            [
                'accounts' => $accounts->paginate(20),
                'group' => $group,
                'categories' => Category::orderBy('name', 'asc')->get()
            ]
        );
    }

    /**
     * Edit the given account.
     *
     * @param  int  $id
     * @return Response
     */
    public function editAccount($id = null)
    {
        // if no ID then new account
        if (empty($id)) {
            $account = new Account;
        } else {
            $account = Account::findOrFail($id);
        }
        return view('account/account',
            [
                'account' => $account,
                'groups' => Group::orderBy('name', 'asc')->get(),
                'categories' => Category::orderBy('name', 'asc')->get()
            ]
        );
    }

    /**
     * Add a new account.
     *
     * @return Response
     */
    public function addAccount(Request $request)
    {
        $this->validate($request, [
            'firstname' => 'required|alpha_num|max:100',
            'lastname' => 'required|alpha_num|max:100',
            'netlogin' => 'required|unique:accounts,netlogin',
            'netpass' => 'required|min:8|different:netlogin',
            'expirydate' => 'required_if:status,1|date|after:today',
            'category' => 'required|exists:categories,id',
            'status' => 'required|boolean',
            'group' => 'required|exists:groups,id'
        ]);

        $account = new Account;
        $account->netlogin = $request->netlogin;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $account->netpass = Account::generateHash($request->netpass);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $account->firstname = ucwords($request->firstname);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $account->lastname = ucwords($request->lastname);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $account->category_id = $request->category;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if (empty($request->expirydate)) {
            $account->expire = date_create('+90 day')->format('Y-m-d');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {
            $account->expire = $request->expirydate;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        $account->status = $request->status;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $account->group_id = $request->group;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $account->created_by = $request->user()->id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $account->save();
        return redirect('accounts')->with(
            'status',
            trans('accounts.message.add', ['account' => $account->netlogin])
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        );
    }

    /**
     * Update an account.
     *
     * @param  Request  $request
     * @param  int  $id
     * @return Response
     */
    public function updateAccount(Request $request, $id)
    {
        $this->validate($request, [
            'netlogin' => 'required|exists:accounts,netlogin',
            'expirydate' => 'required_if:status,1|date|after:today',
            'category' => 'required|exists:categories,id',
            'status' => 'required|boolean',
            'group' => 'required|exists:groups,id'
        ]);

        $account = Account::findOrFail($id);
        if (false === empty($request->netpass)) {
            $account->netpass = Account::generateHash($request->netpass);
        }
        if (false === empty($request->expirydate)) {
            $account->expire = $request->expirydate;
        }
        $account->category_id = $request->category;
        $account->status = $request->status;
        $account->group_id = $request->group;
        $account->update();
        return redirect('accounts')->with(
            'status',
            trans('accounts.message.update', ['account' => $account->netlogin])
        );
    }

    /**
     * Enable an account.
     *
     * @param  int  $id
     * @return Response
     */
    public function enableAccount($id)
    {
        $account = Account::findOrFail($id);
        $account->enable();
        return redirect()->back()->with(
            'status',
            trans(
                'accounts.message.enable',
                [
                    'account' => $account->netlogin,
                    'date'    => $account->expire
                ]
            )
        );
    }

    /**
     * Disable an account.
     *
     * @param  int  $id
     * @return Response
     */
    public function disableAccount($id)

    {
        $account = Account::findOrFail($id);
        $account->disable();
        return redirect()->back()->with(
            'status',
            trans('accounts.message.disable', ['account' => $account->netlogin])
        );
    }

    /**
     * Remove an account.
     *
     * @param  int  $id
     * @return Response
     */
    public function removeAccount($id)

    {
        $account = Account::findOrFail($id);
        $netlogin = $account->netlogin;
        $account->delete();
        return redirect()->back()->with(
            'status',
            trans('accounts.message.delete', ['account' => $netlogin])
        );
    }
}


1			<?php
2
3			namespace App\Http\Controllers;
4
5			use Illuminate\Http\Request;
6			use App\Account;
7			use App\Group;
8			use App\Category;
9			use Auth;
10
11			class AccountController extends Controller
12			{
13			use SearchTrait;
14
15			/**
16			* Create a new controller instance.
17			*
18			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-02-03 22:41 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
19			*/
20			public function __construct()
21			{
22			$this->middleware('auth');
23			}
24
25			/**
26			* List existing accounts
27			*
28			* @return Response
29			*/
30			public function showAccounts(Request $request, $group_id = null, $category_id = null)
31			{
32			$accounts = Account::orderBy('netlogin', 'asc');
33			$group = null;
34
35			// because request routing is not smart
36			if ($request->is('accounts/category/*')) {
37			$category_id = $group_id;
38			$group_id = null;
39			}

edno / kleis

AccountController::editAccount() A last analyzed 2019-08-20 11:53 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

AccountController::editAccount() A
last analyzed 2019-08-20 11:53 UTC